From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC72C48BD6 for ; Wed, 26 Jun 2019 11:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D26B520656 for ; Wed, 26 Jun 2019 11:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727200AbfFZLhd (ORCPT ); Wed, 26 Jun 2019 07:37:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:44512 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726077AbfFZLhd (ORCPT ); Wed, 26 Jun 2019 07:37:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 96F2AAB9B; Wed, 26 Jun 2019 11:37:32 +0000 (UTC) Date: Wed, 26 Jun 2019 20:37:26 +0900 From: Benjamin Poirier To: Manish Chopra Cc: GR-Linux-NIC-Dev , "netdev@vger.kernel.org" Subject: Re: [EXT] [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size Message-ID: <20190626113726.GB27420@f1> References: <20190617074858.32467-1-bpoirier@suse.com> <20190617074858.32467-3-bpoirier@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/06/26 09:24, Manish Chopra wrote: > > -----Original Message----- > > From: Benjamin Poirier > > Sent: Monday, June 17, 2019 1:19 PM > > To: Manish Chopra ; GR-Linux-NIC-Dev > NIC-Dev@marvell.com>; netdev@vger.kernel.org > > Subject: [EXT] [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size > > > > External Email > > > > ---------------------------------------------------------------------- > > lbq_buf_size is duplicated to every rx_ring structure whereas lbq_buf_order is > > present once in the ql_adapter structure. All rings use the same buf size, keep > > only one copy of it. Also factor out the calculation of lbq_buf_size instead of > > having two copies. > > > > Signed-off-by: Benjamin Poirier > > --- [...] > > Not sure if this change is really required, I think fields relevant to rx_ring should be present in the rx_ring structure. > There are various other fields like "lbq_len" and "lbq_size" which would be same for all rx rings but still under the relevant rx_ring structure. Indeed, those members are also removed by this patch series, in patch 11.