From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 03/23] ASoC: tegra: tegra_pcm.c: use devm_snd_dmaengine_pcm_register()
Date: Thu, 27 Jun 2019 09:43:26 +0200 [thread overview]
Message-ID: <20190627094326.7f8c0c60@xxx> (raw)
In-Reply-To: <87y31niycl.wl-kuninori.morimoto.gx@renesas.com>
On 27 Jun 2019 11:00:10 +0900
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> We have devm_xxx version of snd_dmaengine_pcm_register,
> let's use it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/tegra/tegra_pcm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_pcm.c b/sound/soc/tegra/tegra_pcm.c
> index f246df8..1814791 100644
> --- a/sound/soc/tegra/tegra_pcm.c
> +++ b/sound/soc/tegra/tegra_pcm.c
> @@ -44,7 +44,8 @@ static const struct snd_dmaengine_pcm_config
> tegra_dmaengine_pcm_config = {
> int tegra_pcm_platform_register(struct device *dev)
> {
> - return snd_dmaengine_pcm_register(dev,
> &tegra_dmaengine_pcm_config, 0);
> + return devm_snd_dmaengine_pcm_register(dev,
> + &tegra_dmaengine_pcm_config,
> 0); }
> EXPORT_SYMBOL_GPL(tegra_pcm_platform_register);
>
> @@ -57,13 +58,12 @@ int
> tegra_pcm_platform_register_with_chan_names(struct device *dev,
> config->chan_names[0] = txdmachan; config->chan_names[1] = rxdmachan;
>
> - return snd_dmaengine_pcm_register(dev, config, 0);
> + return devm_snd_dmaengine_pcm_register(dev, config, 0);
> }
> EXPORT_SYMBOL_GPL(tegra_pcm_platform_register_with_chan_names);
>
> void tegra_pcm_platform_unregister(struct device *dev)
> {
> - return snd_dmaengine_pcm_unregister(dev);
> }
> EXPORT_SYMBOL_GPL(tegra_pcm_platform_unregister);
>
Again, do we need to keep empty function?
next prev parent reply other threads:[~2019-06-27 7:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 1:59 [PATCH 00/23] ASoC: use devm_xxx Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 01/23] ASoC: atmel: atmel-pcm:dma.c: use devm_snd_dmaengine_pcm_register() Kuninori Morimoto
2019-06-27 7:43 ` Amadeusz Sławiński
2019-06-27 8:20 ` Codrin.Ciubotariu
2019-06-27 8:24 ` Kuninori Morimoto
2019-06-27 11:38 ` Mark Brown
2019-06-28 1:53 ` Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 02/23] ASoC: sunxi: sun4i-i2s.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 03/23] ASoC: tegra: tegra_pcm.c: " Kuninori Morimoto
2019-06-27 7:43 ` Amadeusz Sławiński [this message]
2019-06-27 2:00 ` [PATCH 04/23] ASoC: ux500: ux500_pcm.c: " Kuninori Morimoto
2019-06-27 7:43 ` Amadeusz Sławiński
2019-06-27 2:00 ` [PATCH 05/23] ASoC: au1x: i2sc.c: use devm_snd_soc_register_component() Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 06/23] ASoC: au1x: ac97c.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 07/23] ASoC: au1x: psc-ac97.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 08/23] ASoC: au1x: psc-i2s.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 09/23] ASoC: cirrus: ep93xx-i2s.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 10/23] ASoC: cirrus: ep93xx-ac97.c: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 11/23] ASoC: rt5682: " Kuninori Morimoto
2019-06-27 7:43 ` Amadeusz Sławiński
2019-06-27 2:00 ` [PATCH 12/23] ASoC: ak4118: " Kuninori Morimoto
2019-06-27 7:43 ` Amadeusz Sławiński
2019-06-27 7:51 ` Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 13/23] ASoC: cros_ec_codec: " Kuninori Morimoto
2019-06-27 2:00 ` [PATCH 14/23] ASoC: fsl: imx-ssi.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 15/23] ASoC: fsl: mpc5200_psc_i2s.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 16/23] ASoC: fsl: mpc5200_psc_ac97.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 17/23] ASoC: pxa: pxa2xx-ac97.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 18/23] ASoC: tegra: tegra20_i2s.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 19/23] ASoC: tegra: tegra20_spdif.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 20/23] ASoC: tegra: tegra30_i2s.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 21/23] ASoC: tegra: tegra20_ac97.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 22/23] ASoC: ti: davinci-i2s.c: " Kuninori Morimoto
2019-06-27 2:01 ` [PATCH 23/23] ASoC: ux500: ux500_msp_dai.c: " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627094326.7f8c0c60@xxx \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.