From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BECC5B578 for ; Mon, 1 Jul 2019 07:14:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3CB620652 for ; Mon, 1 Jul 2019 07:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727749AbfGAHOA convert rfc822-to-8bit (ORCPT ); Mon, 1 Jul 2019 03:14:00 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37173 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727206AbfGAHOA (ORCPT ); Mon, 1 Jul 2019 03:14:00 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D61AEE0007; Mon, 1 Jul 2019 07:13:52 +0000 (UTC) Date: Mon, 1 Jul 2019 09:13:52 +0200 From: Miquel Raynal To: Colin King Cc: Sascha Hauer , Han Xu , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size Message-ID: <20190701091352.3e3caf11@xps13> In-Reply-To: <20190604105859.16627-1-colin.king@canonical.com> References: <20190604105859.16627-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, Colin King wrote on Tue, 4 Jun 2019 11:58:59 +0100: > From: Colin Ian King > > The variable block_size is being assigned to itself and to > geo->ecc_chunk_size. Clean up the double assignment by removing > the assignment to itself. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 5db84178edff..334fe3130285 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data *this) > struct bch_geometry *geo = &this->bch_geometry; > unsigned int ecc_strength = geo->ecc_strength >> 1; > unsigned int gf_len = geo->gf_len; > - unsigned int block_size = block_size = geo->ecc_chunk_size; > + unsigned int block_size = geo->ecc_chunk_size; > > this->bch_flashlayout0 = > BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) | Applied to nand/next, thanks. Miquèl Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86A4C5B578 for ; Mon, 1 Jul 2019 07:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97414208C4 for ; Mon, 1 Jul 2019 07:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbfGAHOG convert rfc822-to-8bit (ORCPT ); Mon, 1 Jul 2019 03:14:06 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:48267 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727723AbfGAHOE (ORCPT ); Mon, 1 Jul 2019 03:14:04 -0400 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 929212000C; Mon, 1 Jul 2019 07:14:01 +0000 (UTC) Date: Mon, 1 Jul 2019 09:14:00 +0200 From: Miquel Raynal To: Colin King Cc: Sascha Hauer , Han Xu , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size Message-ID: <20190701091352.3e3caf11@xps13> In-Reply-To: <20190604105859.16627-1-colin.king@canonical.com> References: <20190604105859.16627-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20190701071400.u9y2YPzkvJYlqWmnqT2mBbQ3gOWGF9uVZOhjEUBKQJI@z> Hi Colin, Colin King wrote on Tue, 4 Jun 2019 11:58:59 +0100: > From: Colin Ian King > > The variable block_size is being assigned to itself and to > geo->ecc_chunk_size. Clean up the double assignment by removing > the assignment to itself. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 5db84178edff..334fe3130285 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data *this) > struct bch_geometry *geo = &this->bch_geometry; > unsigned int ecc_strength = geo->ecc_strength >> 1; > unsigned int gf_len = geo->gf_len; > - unsigned int block_size = block_size = geo->ecc_chunk_size; > + unsigned int block_size = geo->ecc_chunk_size; > > this->bch_flashlayout0 = > BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) | Applied to nand/next, thanks. Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Mon, 01 Jul 2019 07:13:52 +0000 Subject: Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size Message-Id: <20190701091352.3e3caf11@xps13> List-Id: References: <20190604105859.16627-1-colin.king@canonical.com> In-Reply-To: <20190604105859.16627-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Colin King Cc: Vignesh Raghavendra , Richard Weinberger , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Han Xu , Brian Norris , David Woodhouse Hi Colin, Colin King wrote on Tue, 4 Jun 2019 11:58:59 +0100: > From: Colin Ian King > > The variable block_size is being assigned to itself and to > geo->ecc_chunk_size. Clean up the double assignment by removing > the assignment to itself. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 5db84178edff..334fe3130285 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data *this) > struct bch_geometry *geo = &this->bch_geometry; > unsigned int ecc_strength = geo->ecc_strength >> 1; > unsigned int gf_len = geo->gf_len; > - unsigned int block_size = block_size = geo->ecc_chunk_size; > + unsigned int block_size = geo->ecc_chunk_size; > > this->bch_flashlayout0 > BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) | Applied to nand/next, thanks. Miquèl Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C594DC0650E for ; Mon, 1 Jul 2019 07:14:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ADBE20652 for ; Mon, 1 Jul 2019 07:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j7bMKBHf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ADBE20652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=in8G85WTaz7v2WMSviw6mPl9FWLIRHypSMw9V53F0co=; b=j7bMKBHf4W08rL +4jw5Yv4R/PscCMI46xP2cbGClpqFWf24u4lMxpEa7VzQl3tPvpz5O1klUytLJ+RT6kBnF/zedSBd OP3cz7cB45ONjMvZg5MEaqgwYmptx1jMfPXwoehmsLknoElAbUYdkd2bOXpig2GW3Rp6fRx3Fs0vo hIT3Qlht+GXvt1xDdEGKRxRpBdVsNPtdF04wKjcdrwAkdIx8qAH5i53T1aWkzkQ9lfJac4iFH2EWR TqxIes2ClAPU26zCM2wzTdmwQGGMW6fuPd2MmFg+vpV64wsrLKufGiztDX8DqBzWekrsNqaax+CTJ WSvuUUuT4UbXVbsLb4TA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhqVr-0001Og-FO; Mon, 01 Jul 2019 07:14:07 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hhqVp-0001Nf-71 for linux-mtd@lists.infradead.org; Mon, 01 Jul 2019 07:14:06 +0000 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 929212000C; Mon, 1 Jul 2019 07:14:01 +0000 (UTC) Date: Mon, 1 Jul 2019 09:14:00 +0200 From: Miquel Raynal To: Colin King Subject: Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size Message-ID: <20190701091352.3e3caf11@xps13> In-Reply-To: <20190604105859.16627-1-colin.king@canonical.com> References: <20190604105859.16627-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_001405_410925_52D64256 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Han Xu , Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQ29saW4sCgpDb2xpbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+IHdyb3RlIG9u IFR1ZSwgIDQgSnVuIDIwMTkKMTE6NTg6NTkgKzAxMDA6Cgo+IEZyb206IENvbGluIElhbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gCj4gVGhlIHZhcmlhYmxlIGJsb2NrX3NpemUg aXMgYmVpbmcgYXNzaWduZWQgdG8gaXRzZWxmIGFuZCB0bwo+IGdlby0+ZWNjX2NodW5rX3NpemUu ICBDbGVhbiB1cCB0aGUgZG91YmxlIGFzc2lnbm1lbnQgYnkgcmVtb3ZpbmcKPiB0aGUgYXNzaWdu bWVudCB0byBpdHNlbGYuCj4gCj4gQWRkcmVzc2VzLUNvdmVyaXR5OiAoIkV2YWx1YXRpb24gb3Jk ZXIgdmlvbGF0aW9uIikKPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2lu Z0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQv Z3BtaS1uYW5kLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5h bmQvZ3BtaS1uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5k LmMKPiBpbmRleCA1ZGI4NDE3OGVkZmYuLjMzNGZlMzEzMDI4NSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5kLmMKPiArKysgYi9kcml2ZXJzL210 ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5kLmMKPiBAQCAtMTQyOCw3ICsxNDI4LDcgQEAg c3RhdGljIHZvaWQgZ3BtaV9iY2hfbGF5b3V0X3N0ZChzdHJ1Y3QgZ3BtaV9uYW5kX2RhdGEgKnRo aXMpCj4gIAlzdHJ1Y3QgYmNoX2dlb21ldHJ5ICpnZW8gPSAmdGhpcy0+YmNoX2dlb21ldHJ5Owo+ ICAJdW5zaWduZWQgaW50IGVjY19zdHJlbmd0aCA9IGdlby0+ZWNjX3N0cmVuZ3RoID4+IDE7Cj4g IAl1bnNpZ25lZCBpbnQgZ2ZfbGVuID0gZ2VvLT5nZl9sZW47Cj4gLQl1bnNpZ25lZCBpbnQgYmxv Y2tfc2l6ZSA9IGJsb2NrX3NpemUgPSBnZW8tPmVjY19jaHVua19zaXplOwo+ICsJdW5zaWduZWQg aW50IGJsb2NrX3NpemUgPSBnZW8tPmVjY19jaHVua19zaXplOwo+ICAKPiAgCXRoaXMtPmJjaF9m bGFzaGxheW91dDAgPQo+ICAJCUJGX0JDSF9GTEFTSDBMQVlPVVQwX05CTE9DS1MoZ2VvLT5lY2Nf Y2h1bmtfY291bnQgLSAxKSB8CgoKCkFwcGxpZWQgdG8gbmFuZC9uZXh0LCB0aGFua3MuCgpNaXF1 w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB49C0650E for ; Mon, 1 Jul 2019 07:14:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D782520652 for ; Mon, 1 Jul 2019 07:14:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KpLXs91m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D782520652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qb259xbol0buZ9yTMtBOffoAG0coZVCuuoSzWzZ7Tag=; b=KpLXs91mzobFez JSEBPX0nyS6w7pwVyF4q20hI1gF19WAGaR+H762h9gx+lLoO9hCx9q0I6eBOxOa2EqZ7pOsPN+pgd p4pbc3o48YI0f+mQlhhogEHW+MFxYH37kQNnF7gTFOxxmTYVk7V8MIKiONyLPIKCn1KYjlD3mA7wi tCDa/BWym0bX6dmNicOoFWKg1dlTy4tbKmaCq3qidxLDnjsyb7qog4pShTpZpfEKu/eMyvWmrK3mK v/p8RhoBr+gLe0WmuU/rCkmcIhTI2Z+KbAlqwsjTvo+DgKcJyJXCiHsl4EOa69A8jWJN51gcAvmWM egJNbB+foB5fKyNnPgRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhqW0-0001Zv-Ts; Mon, 01 Jul 2019 07:14:16 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hhqVq-0001Ng-Hn for linux-mtd@lists.infradead.org; Mon, 01 Jul 2019 07:14:08 +0000 X-Originating-IP: 86.250.200.211 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D61AEE0007; Mon, 1 Jul 2019 07:13:52 +0000 (UTC) Date: Mon, 1 Jul 2019 09:13:52 +0200 From: Miquel Raynal To: Colin King Subject: Re: [PATCH][next] mtd: rawnand: gpmi: remove double assignment to block_size Message-ID: <20190701091352.3e3caf11@xps13> In-Reply-To: <20190604105859.16627-1-colin.king@canonical.com> References: <20190604105859.16627-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_001406_745234_D6989D6E X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Han Xu , Brian Norris , David Woodhouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Message-ID: <20190701071352.LWktV_ouFujxA8nBEVAQmjRYaRsRXGrGZ_bf8ZhhSm4@z> SGkgQ29saW4sCgpDb2xpbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+IHdyb3RlIG9u IFR1ZSwgIDQgSnVuIDIwMTkKMTE6NTg6NTkgKzAxMDA6Cgo+IEZyb206IENvbGluIElhbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gCj4gVGhlIHZhcmlhYmxlIGJsb2NrX3NpemUg aXMgYmVpbmcgYXNzaWduZWQgdG8gaXRzZWxmIGFuZCB0bwo+IGdlby0+ZWNjX2NodW5rX3NpemUu ICBDbGVhbiB1cCB0aGUgZG91YmxlIGFzc2lnbm1lbnQgYnkgcmVtb3ZpbmcKPiB0aGUgYXNzaWdu bWVudCB0byBpdHNlbGYuCj4gCj4gQWRkcmVzc2VzLUNvdmVyaXR5OiAoIkV2YWx1YXRpb24gb3Jk ZXIgdmlvbGF0aW9uIikKPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2lu Z0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQv Z3BtaS1uYW5kLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5h bmQvZ3BtaS1uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5k LmMKPiBpbmRleCA1ZGI4NDE3OGVkZmYuLjMzNGZlMzEzMDI4NSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5kLmMKPiArKysgYi9kcml2ZXJzL210 ZC9uYW5kL3Jhdy9ncG1pLW5hbmQvZ3BtaS1uYW5kLmMKPiBAQCAtMTQyOCw3ICsxNDI4LDcgQEAg c3RhdGljIHZvaWQgZ3BtaV9iY2hfbGF5b3V0X3N0ZChzdHJ1Y3QgZ3BtaV9uYW5kX2RhdGEgKnRo aXMpCj4gIAlzdHJ1Y3QgYmNoX2dlb21ldHJ5ICpnZW8gPSAmdGhpcy0+YmNoX2dlb21ldHJ5Owo+ ICAJdW5zaWduZWQgaW50IGVjY19zdHJlbmd0aCA9IGdlby0+ZWNjX3N0cmVuZ3RoID4+IDE7Cj4g IAl1bnNpZ25lZCBpbnQgZ2ZfbGVuID0gZ2VvLT5nZl9sZW47Cj4gLQl1bnNpZ25lZCBpbnQgYmxv Y2tfc2l6ZSA9IGJsb2NrX3NpemUgPSBnZW8tPmVjY19jaHVua19zaXplOwo+ICsJdW5zaWduZWQg aW50IGJsb2NrX3NpemUgPSBnZW8tPmVjY19jaHVua19zaXplOwo+ICAKPiAgCXRoaXMtPmJjaF9m bGFzaGxheW91dDAgPQo+ICAJCUJGX0JDSF9GTEFTSDBMQVlPVVQwX05CTE9DS1MoZ2VvLT5lY2Nf Y2h1bmtfY291bnQgLSAxKSB8CgoKCkFwcGxpZWQgdG8gbmFuZC9uZXh0LCB0aGFua3MuCgpNaXF1 w6hsCgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=