From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40398C0650E for ; Mon, 1 Jul 2019 14:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FBD22064B for ; Mon, 1 Jul 2019 14:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729790AbfGAOvJ (ORCPT ); Mon, 1 Jul 2019 10:51:09 -0400 Received: from foss.arm.com ([217.140.110.172]:36418 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728354AbfGAOvI (ORCPT ); Mon, 1 Jul 2019 10:51:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D8A4344; Mon, 1 Jul 2019 07:51:08 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B3D73F246; Mon, 1 Jul 2019 07:51:06 -0700 (PDT) Date: Mon, 1 Jul 2019 15:51:04 +0100 From: Catalin Marinas To: Raphael Gault Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org, will.deacon@arm.com, julien.thierry@arm.com Subject: Re: [RFC V3 11/18] arm64: alternative: Mark .altinstr_replacement as containing executable instructions Message-ID: <20190701145104.GE21774@arrakis.emea.arm.com> References: <20190624095548.8578-1-raphael.gault@arm.com> <20190624095548.8578-12-raphael.gault@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624095548.8578-12-raphael.gault@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 10:55:41AM +0100, Raphael Gault wrote: > Until now, the section .altinstr_replacement wasn't marked as containing > executable instructions on arm64. This patch changes that so that it is > coherent with what is done on x86. > > Signed-off-by: Raphael Gault > --- > arch/arm64/include/asm/alternative.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/alternative.h b/arch/arm64/include/asm/alternative.h > index b9f8d787eea9..e9e6b81e3eb4 100644 > --- a/arch/arm64/include/asm/alternative.h > +++ b/arch/arm64/include/asm/alternative.h > @@ -71,7 +71,7 @@ static inline void apply_alternatives_module(void *start, size_t length) { } > ALTINSTR_ENTRY(feature,cb) \ > ".popsection\n" \ > " .if " __stringify(cb) " == 0\n" \ > - ".pushsection .altinstr_replacement, \"a\"\n" \ > + ".pushsection .altinstr_replacement, \"ax\"\n" \ > "663:\n\t" \ > newinstr "\n" \ > "664:\n\t" \ I guess that's an inconsistency we missed since the asm macro has "ax". -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104C8C0650E for ; Mon, 1 Jul 2019 14:51:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD33C2064B for ; Mon, 1 Jul 2019 14:51:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y7cW39Te" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD33C2064B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=20HS2JFMj+4k1TUy/pQo0OZPwcaUiyg91SY+3dvspPM=; b=Y7cW39Te8lHZI+ FnahFdpXqwquxUeFQbUxpB8ic4V9XSh1VYaTAZH5cqEeqWoeVIWDDEx+WsibDQ6PJafuS7p6hsQxm IKZ7N0NVraBObLeuEhQsH6hfRc2Y+ZdycvW/ICswlJ8sJe5JhuqNuRuAZOWCRZAICDJCS3AuMQXwh pF6Grz3x1MeRkBsOcN03OIgkOnvj2n1UYSxjbGI/igxYaN4NtyFT9QrDiBGFlovAp/OrzYP7DkMSi wb3uGg6iivUWYJ4e05RSy5RlcKTd/zWSusyJORpzIXnSiINTHy9E6ZeRMWsalpFE51JCN1vJ3dDLY LRzrfoC8LrlPFbiR7MVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhxeB-00085N-FK; Mon, 01 Jul 2019 14:51:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhxe8-00084w-NO for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2019 14:51:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D8A4344; Mon, 1 Jul 2019 07:51:08 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B3D73F246; Mon, 1 Jul 2019 07:51:06 -0700 (PDT) Date: Mon, 1 Jul 2019 15:51:04 +0100 From: Catalin Marinas To: Raphael Gault Subject: Re: [RFC V3 11/18] arm64: alternative: Mark .altinstr_replacement as containing executable instructions Message-ID: <20190701145104.GE21774@arrakis.emea.arm.com> References: <20190624095548.8578-1-raphael.gault@arm.com> <20190624095548.8578-12-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190624095548.8578-12-raphael.gault@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_075108_814951_DDED1108 X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, peterz@infradead.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 24, 2019 at 10:55:41AM +0100, Raphael Gault wrote: > Until now, the section .altinstr_replacement wasn't marked as containing > executable instructions on arm64. This patch changes that so that it is > coherent with what is done on x86. > > Signed-off-by: Raphael Gault > --- > arch/arm64/include/asm/alternative.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/alternative.h b/arch/arm64/include/asm/alternative.h > index b9f8d787eea9..e9e6b81e3eb4 100644 > --- a/arch/arm64/include/asm/alternative.h > +++ b/arch/arm64/include/asm/alternative.h > @@ -71,7 +71,7 @@ static inline void apply_alternatives_module(void *start, size_t length) { } > ALTINSTR_ENTRY(feature,cb) \ > ".popsection\n" \ > " .if " __stringify(cb) " == 0\n" \ > - ".pushsection .altinstr_replacement, \"a\"\n" \ > + ".pushsection .altinstr_replacement, \"ax\"\n" \ > "663:\n\t" \ > newinstr "\n" \ > "664:\n\t" \ I guess that's an inconsistency we missed since the asm macro has "ax". -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel