From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128B5C0650E for ; Mon, 1 Jul 2019 18:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBA4320B7C for ; Mon, 1 Jul 2019 18:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbfGAS63 (ORCPT ); Mon, 1 Jul 2019 14:58:29 -0400 Received: from mail.us.es ([193.147.175.20]:34414 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbfGAS63 (ORCPT ); Mon, 1 Jul 2019 14:58:29 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id AFCB26D009 for ; Mon, 1 Jul 2019 20:58:27 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9EEC0DA4CA for ; Mon, 1 Jul 2019 20:58:27 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 9DF9FDA708; Mon, 1 Jul 2019 20:58:27 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8A6C6A0AAB; Mon, 1 Jul 2019 20:58:25 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 01 Jul 2019 20:58:25 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 640B34102CA1; Mon, 1 Jul 2019 20:58:25 +0200 (CEST) Date: Mon, 1 Jul 2019 20:58:25 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Ibrahim Ercan Cc: Florian Westphal , netfilter-devel@vger.kernel.org, ibrahim.metu@gmail.com Subject: Re: [PATCH v2] netfilter: synproxy: erroneous TCP mss option fixed. Message-ID: <20190701185825.32mmnw4jdtsj7avr@salvia> References: <1561441324-19193-1-git-send-email-ibrahim.ercan@labristeknoloji.com> <20190627185744.ynxyes7an6gd7hlg@salvia> <20190627190019.hrlowm5lxw7grmsk@breakpoint.cc> <20190627190857.f6lwop54735wo6dg@salvia> <20190627192109.zpkn2vff3ykin6ya@breakpoint.cc> <20190627192705.eyy4aond5yl5jjrr@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627192705.eyy4aond5yl5jjrr@salvia> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Ibrahim, On Thu, Jun 27, 2019 at 09:27:05PM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 27, 2019 at 09:21:09PM +0200, Florian Westphal wrote: > > Pablo Neira Ayuso wrote: > > > On Thu, Jun 27, 2019 at 09:00:19PM +0200, Florian Westphal wrote: > > > > Pablo Neira Ayuso wrote: [...] > > > I see, probably place client_mss field into the synproxy_options > > > structure? > > > > I worked on a fix for this too (Ibrahim was faster), I > > tried to rename opts.mss so we have > > > > u16 mss_peer; > > u16 mss_configured; > > > > but I got confused myself as to where which mss is to be used. > > > > perhaps > > u16 mss_option; > > u16 mss_encode; > > > > ... would have been better. > > I would leave the opts.mss as is by now. Given there will be a > conflict between nf-next and nf, I was trying to minimize the number > of chunks for this fix, but that's just my preference (I'll have to > sort out this it seems). > > Then, adding follow up patches to rename fields would be great indeed > as you suggest. @Ibrahim: Would you follow up with patch v3? I'd name this 'mss_backend' to opts, instead of adding client_mss as parameter. Since this is the MSS that the server backend behind the proxy. I don't mind names, if you prefer Florian's, that's also fine. I'd just like not to add a new parameter to synproxy_send_client_synack(). Thanks.