From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tytso@mit.edu>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 2EF06F94
	for <ksummit-discuss@lists.linuxfoundation.org>;
	Tue,  2 Jul 2019 23:19:04 +0000 (UTC)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D801870D
	for <ksummit-discuss@lists.linuxfoundation.org>;
	Tue,  2 Jul 2019 23:19:02 +0000 (UTC)
Date: Tue, 2 Jul 2019 19:18:58 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Kees Cook <keescook@chromium.org>
Message-ID: <20190702231858.GK3032@mit.edu>
References: <1562080257.3321.19.camel@HansenPartnership.com>
	<1562080696.3321.21.camel@HansenPartnership.com>
	<37eb32f3-f341-b1d8-293b-c119ae278b4f@linuxfoundation.org>
	<1562082713.3321.38.camel@HansenPartnership.com>
	<201907020926.FB19EDEBCC@keescook>
	<1562103238.3321.66.camel@HansenPartnership.com>
	<alpine.DEB.2.21.1907030000050.1802@nanos.tec.linutronix.de>
	<1562106408.29304.11.camel@HansenPartnership.com>
	<20190702224347.GJ3032@mit.edu> <201907021559.FEC3922@keescook>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201907021559.FEC3922@keescook>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in
 commit logs?
List-Id: <ksummit-discuss.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/ksummit-discuss>,
	<mailto:ksummit-discuss-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/ksummit-discuss/>
List-Post: <mailto:ksummit-discuss@lists.linuxfoundation.org>
List-Help: <mailto:ksummit-discuss-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss>,
	<mailto:ksummit-discuss-request@lists.linuxfoundation.org?subject=subscribe>

On Tue, Jul 02, 2019 at 04:04:31PM -0700, Kees Cook wrote:
> > Step 1)   git config am.messageid true
> 
> This is a lossy action: we don't know which list the ID came from (e.g.
> many things are sent to subsystem lists and not lkml).

Why do we need to care which list the ID came from?  Many messages are
cc'ed to multiple lists that are archived on lore.kernel.org.  And it
doesn't matter:

	lore.kernel.org/r/<message-id>

... will work without needing to know which list it was sent to.

> > Step 2)   Write and install a .git/hooks/applypatch-msg script which
> > 	  looks for Message-Id: and transmogrifies that line to a
> > 	  Link: trailer, using the lore.kernel.org URL template
> 
> I think the lorifier.py[1] mentioned earlier has 90% of the "step 2"
> logic, including caching the lore list mappings. Is there a "git am" hook
> we could build on instead? /me looks. Yes; seems to be "applypatch-msg"?
> Unclear if the email headers are included...

applypatch-msg is the git hoook I had suggested above.

The documentation states:

    This hook is invoked by git-am[1]. It takes a single parameter,
    the name of the file that holds the proposed commit log
    message. Exiting with a non-zero status causes git am to abort
    before applying the patch.

    The hook is allowed to edit the message file in place, and can be
    used to normalize the message into some project standard
    format. It can also be used to refuse the commit after inspecting
    the message file.


That to me says the e-mail headers have already been stripped.
Fortunately, using am.messageid=true should work since that is part of
the proposed commit message.

					- Ted