From: kbuild test robot <lkp@intel.com>
To: Dariusz Marcinkiewicz <darekm@google.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
hverkuil-cisco@xs4all.nl, hverkuil@xs4all.nl,
Dariusz Marcinkiewicz <darekm@google.com>
Subject: Re: [PATCH 4/5] drm: dw-hdmi: use cec_notifier_conn_(un)register
Date: Wed, 3 Jul 2019 05:08:07 +0800 [thread overview]
Message-ID: <201907030530.JDAF8KHr%lkp@intel.com> (raw)
In-Reply-To: <20190701083545.74639-5-darekm@google.com>
[-- Attachment #1: Type: text/plain, Size: 3640 bytes --]
Hi Dariusz,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.2-rc7]
[cannot apply to next-20190702]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dariusz-Marcinkiewicz/cec-convert-remaining-drivers-to-the-new-notifier-API/20190702-213026
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu//drm/bridge/synopsys/dw-hdmi.c: In function 'dw_hdmi_bridge_attach':
>> drivers/gpu//drm/bridge/synopsys/dw-hdmi.c:2116:28: error: storage size of 'conn_info' isn't known
struct cec_connector_info conn_info;
^~~~~~~~~
>> drivers/gpu//drm/bridge/synopsys/dw-hdmi.c:2129:2: error: implicit declaration of function 'cec_fill_conn_info_from_drm' [-Werror=implicit-function-declaration]
cec_fill_conn_info_from_drm(&conn_info, connector);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu//drm/bridge/synopsys/dw-hdmi.c:2131:13: error: implicit declaration of function 'cec_notifier_conn_register'; did you mean 'cec_notifier_unregister'? [-Werror=implicit-function-declaration]
notifier = cec_notifier_conn_register(hdmi->dev, NULL, &conn_info);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cec_notifier_unregister
drivers/gpu//drm/bridge/synopsys/dw-hdmi.c:2116:28: warning: unused variable 'conn_info' [-Wunused-variable]
struct cec_connector_info conn_info;
^~~~~~~~~
drivers/gpu//drm/bridge/synopsys/dw-hdmi.c: In function '__dw_hdmi_remove':
>> drivers/gpu//drm/bridge/synopsys/dw-hdmi.c:2722:3: error: implicit declaration of function 'cec_notifier_conn_unregister'; did you mean 'cec_notifier_unregister'? [-Werror=implicit-function-declaration]
cec_notifier_conn_unregister(hdmi->cec_notifier);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
cec_notifier_unregister
cc1: some warnings being treated as errors
vim +2116 drivers/gpu//drm/bridge/synopsys/dw-hdmi.c
2110
2111 static int dw_hdmi_bridge_attach(struct drm_bridge *bridge)
2112 {
2113 struct dw_hdmi *hdmi = bridge->driver_private;
2114 struct drm_encoder *encoder = bridge->encoder;
2115 struct drm_connector *connector = &hdmi->connector;
> 2116 struct cec_connector_info conn_info;
2117 struct cec_notifier *notifier;
2118
2119 connector->interlace_allowed = 1;
2120 connector->polled = DRM_CONNECTOR_POLL_HPD;
2121
2122 drm_connector_helper_add(connector, &dw_hdmi_connector_helper_funcs);
2123
2124 drm_connector_init(bridge->dev, connector, &dw_hdmi_connector_funcs,
2125 DRM_MODE_CONNECTOR_HDMIA);
2126
2127 drm_connector_attach_encoder(connector, encoder);
2128
> 2129 cec_fill_conn_info_from_drm(&conn_info, connector);
2130
> 2131 notifier = cec_notifier_conn_register(hdmi->dev, NULL, &conn_info);
2132 if (!notifier)
2133 return -ENOMEM;
2134 WRITE_ONCE(hdmi->cec_notifier, notifier);
2135
2136 return 0;
2137 }
2138
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54101 bytes --]
next prev parent reply other threads:[~2019-07-03 0:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 8:35 [PATCH 0/5] cec: convert remaining drivers to the new notifier API Dariusz Marcinkiewicz
2019-07-01 8:35 ` [PATCH 1/5] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-07-01 8:35 ` [PATCH 2/5] drm: sti: " Dariusz Marcinkiewicz
2019-07-01 8:35 ` [PATCH 3/5] drm: tegra: " Dariusz Marcinkiewicz
2019-07-01 8:35 ` [PATCH 4/5] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-07-02 21:08 ` kbuild test robot [this message]
2019-07-01 8:35 ` [PATCH 5/5] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz
2019-07-04 19:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907030530.JDAF8KHr%lkp@intel.com \
--to=lkp@intel.com \
--cc=darekm@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@01.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.