[PATCH 1/2] drm/i915/guc: Upgrade to GuC 33.0.0

[PATCH 1/2] drm/i915/guc: Upgrade to GuC 33.0.0

[Michal Wajdeczko]

New GuC firmware is available. Let's use it.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/intel_guc_fw.c   | 20 ++++++++++----------
 drivers/gpu/drm/i915/intel_guc_fwif.h |  7 +------
 2 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
index 970f39ef248b..db1e0daca7db 100644
--- a/drivers/gpu/drm/i915/intel_guc_fw.c
+++ b/drivers/gpu/drm/i915/intel_guc_fw.c
@@ -38,37 +38,37 @@
 	__stringify(KEY##_GUC_FW_PATCH) ".bin"
 
 #define SKL_GUC_FW_PREFIX skl
-#define SKL_GUC_FW_MAJOR 32
+#define SKL_GUC_FW_MAJOR 33
 #define SKL_GUC_FW_MINOR 0
-#define SKL_GUC_FW_PATCH 3
+#define SKL_GUC_FW_PATCH 0
 #define SKL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(SKL)
 MODULE_FIRMWARE(SKL_GUC_FIRMWARE_PATH);
 
 #define BXT_GUC_FW_PREFIX bxt
-#define BXT_GUC_FW_MAJOR 32
+#define BXT_GUC_FW_MAJOR 33
 #define BXT_GUC_FW_MINOR 0
-#define BXT_GUC_FW_PATCH 3
+#define BXT_GUC_FW_PATCH 0
 #define BXT_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(BXT)
 MODULE_FIRMWARE(BXT_GUC_FIRMWARE_PATH);
 
 #define KBL_GUC_FW_PREFIX kbl
-#define KBL_GUC_FW_MAJOR 32
+#define KBL_GUC_FW_MAJOR 33
 #define KBL_GUC_FW_MINOR 0
-#define KBL_GUC_FW_PATCH 3
+#define KBL_GUC_FW_PATCH 0
 #define KBL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(KBL)
 MODULE_FIRMWARE(KBL_GUC_FIRMWARE_PATH);
 
 #define GLK_GUC_FW_PREFIX glk
-#define GLK_GUC_FW_MAJOR 32
+#define GLK_GUC_FW_MAJOR 33
 #define GLK_GUC_FW_MINOR 0
-#define GLK_GUC_FW_PATCH 3
+#define GLK_GUC_FW_PATCH 0
 #define GLK_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(GLK)
 MODULE_FIRMWARE(GLK_GUC_FIRMWARE_PATH);
 
 #define ICL_GUC_FW_PREFIX icl
-#define ICL_GUC_FW_MAJOR 32
+#define ICL_GUC_FW_MAJOR 33
 #define ICL_GUC_FW_MINOR 0
-#define ICL_GUC_FW_PATCH 3
+#define ICL_GUC_FW_PATCH 0
 #define ICL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(ICL)
 MODULE_FIRMWARE(ICL_GUC_FIRMWARE_PATH);
 
diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
index 92bd7ffb5b10..30cca3a29323 100644
--- a/drivers/gpu/drm/i915/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
@@ -43,13 +43,8 @@
 #define GUC_VIDEO_ENGINE2		4
 #define GUC_MAX_ENGINES_NUM		(GUC_VIDEO_ENGINE2 + 1)
 
-/*
- * XXX: Beware that Gen9 firmware 32.x uses wrong definition for
- * GUC_MAX_INSTANCES_PER_CLASS (1) but this is harmless for us now
- * as we are not enabling GuC submission mode where this will be used
- */
 #define GUC_MAX_ENGINE_CLASSES		5
-#define GUC_MAX_INSTANCES_PER_CLASS	4
+#define GUC_MAX_INSTANCES_PER_CLASS	16
 
 #define GUC_DOORBELL_INVALID		256
 
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

GuC firmware is now mature, so let it run by default.
Note that today GuC is only used for HuC authentication.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index d29ade3b7de6..5736c55694fe 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -54,7 +54,7 @@ struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, 0) \
+	param(int, enable_guc, -1) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Michal Wajdeczko (2019-07-03 12:36:40)
> GuC firmware is now mature, so let it run by default.
> Note that today GuC is only used for HuC authentication.

https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson  
<chris@chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2019-07-03 12:36:40)
>> GuC firmware is now mature, so let it run by default.
>> Note that today GuC is only used for HuC authentication.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?

Above bug was found on suspicious kernel with old GuC 9.39:

[    2.381803] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
(version 2.0)
[    2.386316] [drm] GuC: Loaded firmware i915/kbl_guc_ver9_39.bin  
(version 9.39)
[    2.438318] [drm:intel_huc_auth] *ERROR* HuC: Firmware not verified  
0x6000
[    2.445235] [drm:intel_huc_auth] *ERROR* HuC: Authentication failed -110
[    2.451975] i915 0000:00:02.0: GuC initialization failed -110

while results from try-bot [1] with 33.0.0 on KBL are looking fine:

[    3.854084] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
(version 2.0)
[    3.865419] [drm] GuC: Loaded firmware i915/kbl_guc_33.0.0.bin (version  
33.0)
[    3.876243] i915 0000:00:02.0: GuC submission disabled
[    3.876245] i915 0000:00:02.0: HuC enabled

Note that newer GuC fixes other known issue [2] that has similar signature:

[160.168623] [drm:intel_huc_auth [i915]] *ERROR* HuC: Firmware not  
verified -110
[160.168839] [drm:intel_huc_auth [i915]] *ERROR* HuC: Authentication  
failed -110
[160.169159] [drm:i915_gem_init_hw [i915]] *ERROR* Enabling uc failed  
(-110)

Michal

[1]  
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4514/fi-kbl-7567u/boot0.log
[2] https://bugs.freedesktop.org/show_bug.cgi?id=110820




_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0
URL   : https://patchwork.freedesktop.org/series/63123/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6404 -> Patchwork_13506
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/

Known issues
------------

  Here are the changes found in Patchwork_13506 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - fi-icl-u3:          [INCOMPLETE][1] ([fdo#107713] / [fdo#109100]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/fi-icl-u3/igt@gem_ctx_create@basic-files.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/fi-icl-u3/igt@gem_ctx_create@basic-files.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][3] ([fdo#109485]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485


Participating hosts (54 -> 46)
------------------------------

  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6404 -> Patchwork_13506

  CI_DRM_6404: 1b853e6e181c6015faca908b57956ea836e1f440 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5079: 873df2fa9e8f5fd02d4532b30ef2579f4fe4f27f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13506: db9522feaa837af2c91d64996719462f00ffd78d @ git://anongit.freedesktop.org/gfx-ci/linux


== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/build_32bit.log

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready  (#1)
  Building modules, stage 2.
  MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2


== Linux commits ==

db9522feaa83 drm/i915/guc: Turn on GuC/HuC auto mode
5bb81368534c drm/i915/guc: Upgrade to GuC 33.0.0

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915/guc: Upgrade to GuC 33.0.0

[Daniele Ceraolo Spurio]

On 7/3/19 4:36 AM, Michal Wajdeczko wrote:
> New GuC firmware is available. Let's use it.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

The only applicable diff in the FW header is indeed the 
GUC_MAX_INSTANCES_PER_CLASS define.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/intel_guc_fw.c   | 20 ++++++++++----------
>   drivers/gpu/drm/i915/intel_guc_fwif.h |  7 +------
>   2 files changed, 11 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c
> index 970f39ef248b..db1e0daca7db 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fw.c
> +++ b/drivers/gpu/drm/i915/intel_guc_fw.c
> @@ -38,37 +38,37 @@
>   	__stringify(KEY##_GUC_FW_PATCH) ".bin"
>   
>   #define SKL_GUC_FW_PREFIX skl
> -#define SKL_GUC_FW_MAJOR 32
> +#define SKL_GUC_FW_MAJOR 33
>   #define SKL_GUC_FW_MINOR 0
> -#define SKL_GUC_FW_PATCH 3
> +#define SKL_GUC_FW_PATCH 0
>   #define SKL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(SKL)
>   MODULE_FIRMWARE(SKL_GUC_FIRMWARE_PATH);
>   
>   #define BXT_GUC_FW_PREFIX bxt
> -#define BXT_GUC_FW_MAJOR 32
> +#define BXT_GUC_FW_MAJOR 33
>   #define BXT_GUC_FW_MINOR 0
> -#define BXT_GUC_FW_PATCH 3
> +#define BXT_GUC_FW_PATCH 0
>   #define BXT_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(BXT)
>   MODULE_FIRMWARE(BXT_GUC_FIRMWARE_PATH);
>   
>   #define KBL_GUC_FW_PREFIX kbl
> -#define KBL_GUC_FW_MAJOR 32
> +#define KBL_GUC_FW_MAJOR 33
>   #define KBL_GUC_FW_MINOR 0
> -#define KBL_GUC_FW_PATCH 3
> +#define KBL_GUC_FW_PATCH 0
>   #define KBL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(KBL)
>   MODULE_FIRMWARE(KBL_GUC_FIRMWARE_PATH);
>   
>   #define GLK_GUC_FW_PREFIX glk
> -#define GLK_GUC_FW_MAJOR 32
> +#define GLK_GUC_FW_MAJOR 33
>   #define GLK_GUC_FW_MINOR 0
> -#define GLK_GUC_FW_PATCH 3
> +#define GLK_GUC_FW_PATCH 0
>   #define GLK_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(GLK)
>   MODULE_FIRMWARE(GLK_GUC_FIRMWARE_PATH);
>   
>   #define ICL_GUC_FW_PREFIX icl
> -#define ICL_GUC_FW_MAJOR 32
> +#define ICL_GUC_FW_MAJOR 33
>   #define ICL_GUC_FW_MINOR 0
> -#define ICL_GUC_FW_PATCH 3
> +#define ICL_GUC_FW_PATCH 0
>   #define ICL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(ICL)
>   MODULE_FIRMWARE(ICL_GUC_FIRMWARE_PATH);
>   
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 92bd7ffb5b10..30cca3a29323 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -43,13 +43,8 @@
>   #define GUC_VIDEO_ENGINE2		4
>   #define GUC_MAX_ENGINES_NUM		(GUC_VIDEO_ENGINE2 + 1)
>   
> -/*
> - * XXX: Beware that Gen9 firmware 32.x uses wrong definition for
> - * GUC_MAX_INSTANCES_PER_CLASS (1) but this is harmless for us now
> - * as we are not enabling GuC submission mode where this will be used
> - */
>   #define GUC_MAX_ENGINE_CLASSES		5
> -#define GUC_MAX_INSTANCES_PER_CLASS	4
> +#define GUC_MAX_INSTANCES_PER_CLASS	16
>   
>   #define GUC_DOORBELL_INVALID		256
>   
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0
URL   : https://patchwork.freedesktop.org/series/63123/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13506_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13506_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@close-race:
    - shard-kbl:          [PASS][1] -> [DMESG-FAIL][2] ([fdo#111063])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-kbl6/igt@gem_busy@close-race.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-kbl2/igt@gem_busy@close-race.html
    - shard-apl:          [PASS][3] -> [DMESG-FAIL][4] ([fdo#111063])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-apl8/igt@gem_busy@close-race.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-apl7/igt@gem_busy@close-race.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +9 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +8 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#110854])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb5/igt@gem_exec_balancer@smoke.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#110933])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb5/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb8/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#104873])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#105363])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-glk3/igt@kms_flip@flip-vs-expired-vblank.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-glk7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible:
    - shard-skl:          [PASS][17] -> [FAIL][18] ([fdo#100368])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
    - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167]) +4 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109642] / [fdo#111068])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb5/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][23] -> [SKIP][24] ([fdo#109441]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][25] -> [FAIL][26] ([fdo#99912])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-kbl4/igt@kms_setmode@basic.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-kbl3/igt@kms_setmode@basic.html

  * igt@perf_pmu@rc6:
    - shard-apl:          [PASS][27] -> [SKIP][28] ([fdo#109271]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-apl6/igt@perf_pmu@rc6.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-apl7/igt@perf_pmu@rc6.html
    - shard-glk:          [PASS][29] -> [SKIP][30] ([fdo#109271]) +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-glk2/igt@perf_pmu@rc6.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-glk7/igt@perf_pmu@rc6.html
    - shard-skl:          [PASS][31] -> [SKIP][32] ([fdo#109271]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl3/igt@perf_pmu@rc6.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl8/igt@perf_pmu@rc6.html
    - shard-kbl:          [PASS][33] -> [SKIP][34] ([fdo#109271]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-kbl3/igt@perf_pmu@rc6.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-kbl2/igt@perf_pmu@rc6.html
    - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#110877])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb2/igt@perf_pmu@rc6.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb3/igt@perf_pmu@rc6.html

  
#### Possible fixes ####

  * igt@gem_busy@close-race:
    - shard-skl:          [DMESG-FAIL][37] ([fdo#111063]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl1/igt@gem_busy@close-race.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl1/igt@gem_busy@close-race.html
    - shard-iclb:         [DMESG-FAIL][39] ([fdo#111063]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb8/igt@gem_busy@close-race.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb1/igt@gem_busy@close-race.html

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
    - shard-glk:          [FAIL][41] ([fdo#104873]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-glk2/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-glk4/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
    - shard-iclb:         [INCOMPLETE][43] ([fdo#106978] / [fdo#107713]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [FAIL][45] ([fdo#103167]) -> [PASS][46] +2 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-skl:          [FAIL][47] ([fdo#103167]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
    - shard-skl:          [FAIL][49] ([fdo#108145]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][51] ([fdo#108145] / [fdo#110403]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][53] ([fdo#103166]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [SKIP][55] ([fdo#109441]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

  
#### Warnings ####

  * igt@gem_softpin@noreloc-s3:
    - shard-skl:          [INCOMPLETE][57] ([fdo#104108] / [fdo#107773]) -> [INCOMPLETE][58] ([fdo#104108])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-skl1/igt@gem_softpin@noreloc-s3.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-skl1/igt@gem_softpin@noreloc-s3.html

  * igt@kms_content_protection@atomic:
    - shard-iclb:         [SKIP][59] ([fdo#109300]) -> [SKIP][60] ([fdo#109300] / [fdo#111066])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb7/igt@kms_content_protection@atomic.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb7/igt@kms_content_protection@atomic.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [SKIP][61] ([fdo#109642]) -> [SKIP][62] ([fdo#109642] / [fdo#111068])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6404/shard-iclb3/igt@kms_psr2_su@page_flip.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/shard-iclb7/igt@kms_psr2_su@page_flip.html

  
  [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110877]: https://bugs.freedesktop.org/show_bug.cgi?id=110877
  [fdo#110933]: https://bugs.freedesktop.org/show_bug.cgi?id=110933
  [fdo#111063]: https://bugs.freedesktop.org/show_bug.cgi?id=111063
  [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6404 -> Patchwork_13506

  CI_DRM_6404: 1b853e6e181c6015faca908b57956ea836e1f440 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5079: 873df2fa9e8f5fd02d4532b30ef2579f4fe4f27f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13506: db9522feaa837af2c91d64996719462f00ffd78d @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13506/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Michal Wajdeczko (2019-07-03 14:02:51)
> On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson  
> <chris@chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2019-07-03 12:36:40)
> >> GuC firmware is now mature, so let it run by default.
> >> Note that today GuC is only used for HuC authentication.
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?
> 
> Above bug was found on suspicious kernel with old GuC 9.39:
> 
> [    2.381803] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    2.386316] [drm] GuC: Loaded firmware i915/kbl_guc_ver9_39.bin  
> (version 9.39)
> [    2.438318] [drm:intel_huc_auth] *ERROR* HuC: Firmware not verified  
> 0x6000
> [    2.445235] [drm:intel_huc_auth] *ERROR* HuC: Authentication failed -110
> [    2.451975] i915 0000:00:02.0: GuC initialization failed -110
> 
> while results from try-bot [1] with 33.0.0 on KBL are looking fine:
> 
> [    3.854084] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    3.865419] [drm] GuC: Loaded firmware i915/kbl_guc_33.0.0.bin (version  
> 33.0)
> [    3.876243] i915 0000:00:02.0: GuC submission disabled
> [    3.876245] i915 0000:00:02.0: HuC enabled
> 
> Note that newer GuC fixes other known issue [2] that has similar signature:
> 
> [160.168623] [drm:intel_huc_auth [i915]] *ERROR* HuC: Firmware not  
> verified -110
> [160.168839] [drm:intel_huc_auth [i915]] *ERROR* HuC: Authentication  
> failed -110
> [160.169159] [drm:i915_gem_init_hw [i915]] *ERROR* Enabling uc failed  
> (-110)

Pushed the switch to the new GuC version, but I am deferring the
decision to enable-by-default to someone in MAINTAINERS. Probably Joonas
if he survives his swim with the fishes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Joonas Lahtinen]

Better subject would be: "Enable HuC (through GuC) on supported platforms"

Quoting Michal Wajdeczko (2019-07-03 14:36:40)
> GuC firmware is now mature, so let it run by default.

That's bit of a misleading statement (in more than one way).

"Enable loading HuC firmware (through GuC) to unlock
advanced video codecs on supported platforms.

GuC firmware is required to authenticate the HuC firmware,
which is a requirement for it to operate."

Has the most recent firmware been merged to linux-firmware and
is it present in our CI systems?

It would also be good to list what kind of tests have been run
to ensure that there are no regressions, and which platforms
this change affects.

Regards, Joonas

> Note that today GuC is only used for HuC authentication.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>         param(int, disable_power_well, -1) \
>         param(int, enable_ips, 1) \
>         param(int, invert_brightness, 0) \
> -       param(int, enable_guc, 0) \
> +       param(int, enable_guc, -1) \
>         param(int, guc_log_level, -1) \
>         param(char *, guc_firmware_path, NULL) \
>         param(char *, huc_firmware_path, NULL) \
> -- 
> 2.19.2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Michal Wajdeczko]

On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
<joonas.lahtinen@linux.intel.com> wrote:

> Better subject would be: "Enable HuC (through GuC) on supported  
> platforms"

Such subject sounds better, but on one hand it does not reflect real
code change (since we are not explicitly enabling HuC, but instead we
are just letting the driver enable GuC/HuC to whatever mode it decides),
but on other hand this is what actual outcome of the change is (as i915
currently enables GuC loading with HuC authentication on every platform
where corresponding firmwares are defined/available, and nothing more).

Please confirm if you still opt-in to use your subject.

>
> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>> GuC firmware is now mature, so let it run by default.
>
> That's bit of a misleading statement (in more than one way).

It's mature enough to perform HuC authentication, and we
don't expect more from it ;)

>
> "Enable loading HuC firmware (through GuC) to unlock
> advanced video codecs on supported platforms.
>
> GuC firmware is required to authenticate the HuC firmware,
> which is a requirement for it to operate."

To some extend this duplicates existing "DOC: HuC Firmware"
Do we need to repeat that again here?

>
> Has the most recent firmware been merged to linux-firmware and
> is it present in our CI systems?

My understanding is: No and Yes.
Maybe Anusha can provide more details here.

>
> It would also be good to list what kind of tests have been run
> to ensure that there are no regressions,

I'm afraid on IGT level we don't have HuC tests.
But media team was using modparam override to force GuC/HuC for
a while, Tony do you have such test list/results handy?

> and which platforms
> this change affects.

This change affects all platforms where we have GuC/HuC firmwares
defined, so: SKL, BXT, KBL, CFL, ICL.

Note that we'll still have possibility to tweak that inside
driver, as auto mode is just moving responsibility what can
be enabled from the user to the i915.

>
> Regards, Joonas
>
>> Note that today GuC is only used for HuC authentication.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h  
>> b/drivers/gpu/drm/i915/i915_params.h
>> index d29ade3b7de6..5736c55694fe 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -54,7 +54,7 @@ struct drm_printer;
>>         param(int, disable_power_well, -1) \
>>         param(int, enable_ips, 1) \
>>         param(int, invert_brightness, 0) \
>> -       param(int, enable_guc, 0) \
>> +       param(int, enable_guc, -1) \
>>         param(int, guc_log_level, -1) \
>>         param(char *, guc_firmware_path, NULL) \
>>         param(char *, huc_firmware_path, NULL) \
>> --
>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Srivatsa, Anusha]

>-----Original Message-----
>From: Wajdeczko, Michal
>Sent: Wednesday, July 10, 2019 7:27 AM
>To: intel-gfx@lists.freedesktop.org; Joonas Lahtinen
><joonas.lahtinen@linux.intel.com>; Srivatsa, Anusha
><anusha.srivatsa@intel.com>; Ye, Tony <tony.ye@intel.com>
>Cc: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>; Chris Wilson
><chris@chris-wilson.co.uk>
>Subject: Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode
>
>On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
><joonas.lahtinen@linux.intel.com> wrote:
>
>> Better subject would be: "Enable HuC (through GuC) on supported
>> platforms"
>
>Such subject sounds better, but on one hand it does not reflect real code change
>(since we are not explicitly enabling HuC, but instead we are just letting the driver
>enable GuC/HuC to whatever mode it decides), but on other hand this is what
>actual outcome of the change is (as i915 currently enables GuC loading with HuC
>authentication on every platform where corresponding firmwares are
>defined/available, and nothing more).
>
>Please confirm if you still opt-in to use your subject.
>
>>
>> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>>> GuC firmware is now mature, so let it run by default.
>>
>> That's bit of a misleading statement (in more than one way).
>
>It's mature enough to perform HuC authentication, and we don't expect more
>from it ;)
>
>>
>> "Enable loading HuC firmware (through GuC) to unlock advanced video
>> codecs on supported platforms.
>>
>> GuC firmware is required to authenticate the HuC firmware, which is a
>> requirement for it to operate."
>
>To some extend this duplicates existing "DOC: HuC Firmware"
>Do we need to repeat that again here?
>
>>
>> Has the most recent firmware been merged to linux-firmware and is it
>> present in our CI systems?
>
>My understanding is: No and Yes.
>Maybe Anusha can provide more details here.

Waiting on the firmware to get merged to linux-firmware. Sent the PR.
The latest firmware is however available on our CI.

Anusha 
>>
>> It would also be good to list what kind of tests have been run to
>> ensure that there are no regressions,
>
>I'm afraid on IGT level we don't have HuC tests.
>But media team was using modparam override to force GuC/HuC for a while,
>Tony do you have such test list/results handy?
>
>> and which platforms
>> this change affects.
>
>This change affects all platforms where we have GuC/HuC firmwares defined, so:
>SKL, BXT, KBL, CFL, ICL.
>
>Note that we'll still have possibility to tweak that inside driver, as auto mode is
>just moving responsibility what can be enabled from the user to the i915.
>
>>
>> Regards, Joonas
>>
>>> Note that today GuC is only used for HuC authentication.
>>>
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_params.h
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index d29ade3b7de6..5736c55694fe 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -54,7 +54,7 @@ struct drm_printer;
>>>         param(int, disable_power_well, -1) \
>>>         param(int, enable_ips, 1) \
>>>         param(int, invert_brightness, 0) \
>>> -       param(int, enable_guc, 0) \
>>> +       param(int, enable_guc, -1) \
>>>         param(int, guc_log_level, -1) \
>>>         param(char *, guc_firmware_path, NULL) \
>>>         param(char *, huc_firmware_path, NULL) \
>>> --
>>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Ye, Tony]

On 7/10/2019 10:27 PM, Michal Wajdeczko wrote:
> On Tue, 09 Jul 2019 16:17:02 +0200, Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com> wrote:
>
>> Better subject would be: "Enable HuC (through GuC) on supported 
>> platforms"
>
> Such subject sounds better, but on one hand it does not reflect real
> code change (since we are not explicitly enabling HuC, but instead we
> are just letting the driver enable GuC/HuC to whatever mode it decides),
> but on other hand this is what actual outcome of the change is (as i915
> currently enables GuC loading with HuC authentication on every platform
> where corresponding firmwares are defined/available, and nothing more).
>
> Please confirm if you still opt-in to use your subject.
>
>>
>> Quoting Michal Wajdeczko (2019-07-03 14:36:40)
>>> GuC firmware is now mature, so let it run by default.
>>
>> That's bit of a misleading statement (in more than one way).
>
> It's mature enough to perform HuC authentication, and we
> don't expect more from it ;)
>
>>
>> "Enable loading HuC firmware (through GuC) to unlock
>> advanced video codecs on supported platforms.
>>
>> GuC firmware is required to authenticate the HuC firmware,
>> which is a requirement for it to operate."
>
> To some extend this duplicates existing "DOC: HuC Firmware"
> Do we need to repeat that again here?
>
>>
>> Has the most recent firmware been merged to linux-firmware and
>> is it present in our CI systems?
>
> My understanding is: No and Yes.
> Maybe Anusha can provide more details here.
>
>>
>> It would also be good to list what kind of tests have been run
>> to ensure that there are no regressions,
>
> I'm afraid on IGT level we don't have HuC tests.
> But media team was using modparam override to force GuC/HuC for
> a while, Tony do you have such test list/results handy?

HuC functionality has been tested with AVC VDENC/HEVC VDENC/VP9VDENC 
encoding test cases in regular CI.

Thanks, -Tony

>
>> and which platforms
>> this change affects.
>
> This change affects all platforms where we have GuC/HuC firmwares
> defined, so: SKL, BXT, KBL, CFL, ICL.
>
> Note that we'll still have possibility to tweak that inside
> driver, as auto mode is just moving responsibility what can
> be enabled from the user to the i915.
>
>>
>> Regards, Joonas
>>
>>> Note that today GuC is only used for HuC authentication.
>>>
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_params.h 
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index d29ade3b7de6..5736c55694fe 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -54,7 +54,7 @@ struct drm_printer;
>>>         param(int, disable_power_well, -1) \
>>>         param(int, enable_ips, 1) \
>>>         param(int, invert_brightness, 0) \
>>> -       param(int, enable_guc, 0) \
>>> +       param(int, enable_guc, -1) \
>>>         param(int, guc_log_level, -1) \
>>>         param(char *, guc_firmware_path, NULL) \
>>>         param(char *, huc_firmware_path, NULL) \
>>> -- 
>>> 2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx