All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 2/2] ci: disable Homebrew's auto cleanup
Date: Wed, 3 Jul 2019 15:04:34 +0200	[thread overview]
Message-ID: <20190703130434.GR21574@szeder.dev> (raw)
In-Reply-To: <1d10ed33-5c33-8028-c375-d859ef6826dc@virtuell-zuhause.de>

On Wed, Jul 03, 2019 at 02:26:21PM +0200, Thomas Braun wrote:
> Am 03.07.2019 um 12:47 schrieb SZEDER Gábor:
> > Lately Homebrew learned to automagically clean up information about
> > outdated packages during other 'brew' commands, which might be useful
> > for the avarage user, but is a waste of time in CI build jobs, because
> > the next build jobs will start from the exact same image containing
> > the same outdated packages anyway.
> > 
> > Export HOMEBREW_NO_AUTO_UPDATE=1 to disable this auto cleanup feature,
> 
> The patch below adds HOMEBREW_NO_INSTALL_CLEANUP so maybe you meant
> HOMEBREW_NO_INSTALL_CLEANUP here as well?

Thanks, good catch.  Apparently copy-pasted the wrong env var from the
patch to the commit message...

> > shaving off about 20-30s from the time needed to install dependencies
> > in our macOS build jobs on Travis CI.
> > 
> > Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> > ---
> >  ci/install-dependencies.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> > index 7f546c8552..8cc72503cb 100755
> > --- a/ci/install-dependencies.sh
> > +++ b/ci/install-dependencies.sh
> > @@ -34,7 +34,7 @@ linux-clang|linux-gcc)
> >  	popd
> >  	;;
> >  osx-clang|osx-gcc)
> > -	export HOMEBREW_NO_AUTO_UPDATE=1
> > +	export HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1
> >  	# Uncomment this if you want to run perf tests:
> >  	# brew install gnu-time
> >  	test -z "$BREW_INSTALL_PACKAGES" ||
> > 
> 

  reply	other threads:[~2019-07-03 13:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 19:32 Travis not looking so good Johannes Schindelin
2019-06-01  0:41 ` brian m. carlson
2019-06-02 11:22   ` SZEDER Gábor
2019-06-26 20:35     ` Taylor Blau
2019-06-27 13:23       ` SZEDER Gábor
2019-06-27 16:46         ` Junio C Hamano
2019-06-29 17:01           ` SZEDER Gábor
2019-07-03 10:47             ` [PATCH 1/2] ci: don't update Homebrew SZEDER Gábor
2019-07-03 10:47               ` [PATCH 2/2] ci: disable Homebrew's auto cleanup SZEDER Gábor
2019-07-03 11:49                 ` Johannes Schindelin
2019-07-03 12:26                 ` Thomas Braun
2019-07-03 13:04                   ` SZEDER Gábor [this message]
2019-07-03 16:58                     ` Junio C Hamano
2019-07-06 16:16               ` [PATCH] ci/lib.sh: update a comment about installed P4 and Git-LFS versions SZEDER Gábor
2019-07-06 16:21                 ` [PATCH v1.1] " SZEDER Gábor
2019-07-08 10:00                   ` Johannes Schindelin
2019-07-09 16:32               ` [PATCH 1/2] ci: don't update Homebrew Taylor Blau
2019-07-10 22:33                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703130434.GR21574@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=me@ttaylorr.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=thomas.braun@virtuell-zuhause.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.