* [PATCH] rtc: pcf2123: Fix build error
@ 2019-07-04 8:55 YueHaibing
2019-07-13 19:31 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-04 8:55 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, Dylan.Howey, ravi23ganiga
Cc: linux-kernel, linux-rtc, YueHaibing
If REGMAP_SPI is m and RTC_DRV_PCF2123 is y,
drivers/rtc/rtc-pcf2123.o: In function `pcf2123_probe':
rtc-pcf2123.c:(.text+0xb2b): undefined reference to `__devm_regmap_init_spi'
Select REGMAP_SPI as RTC_DRV_DS1347 driver does.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 790d033933b8 ("rtc: pcf2123: port to regmap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 3bfc04a..e72f65b 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -820,6 +820,7 @@ config RTC_DRV_MAX6902
config RTC_DRV_PCF2123
tristate "NXP PCF2123"
+ select REGMAP_SPI
help
If you say yes here you get support for the NXP PCF2123
RTC chip.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: pcf2123: Fix build error
2019-07-04 8:55 [PATCH] rtc: pcf2123: Fix build error YueHaibing
@ 2019-07-13 19:31 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-07-13 19:31 UTC (permalink / raw)
To: YueHaibing; +Cc: a.zummo, Dylan.Howey, ravi23ganiga, linux-kernel, linux-rtc
On 04/07/2019 16:55:42+0800, YueHaibing wrote:
> If REGMAP_SPI is m and RTC_DRV_PCF2123 is y,
>
> drivers/rtc/rtc-pcf2123.o: In function `pcf2123_probe':
> rtc-pcf2123.c:(.text+0xb2b): undefined reference to `__devm_regmap_init_spi'
>
> Select REGMAP_SPI as RTC_DRV_DS1347 driver does.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 790d033933b8 ("rtc: pcf2123: port to regmap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-13 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 8:55 [PATCH] rtc: pcf2123: Fix build error YueHaibing
2019-07-13 19:31 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.