From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 1/5] drm/i915/gen11: Start distinguishing 'phy' from 'port' Date: Thu, 4 Jul 2019 12:18:11 +0300 Message-ID: <20190704091811.GE5942@intel.com> References: <20190703233736.5816-1-matthew.d.roper@intel.com> <20190703233736.5816-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60FAD6E31A for ; Thu, 4 Jul 2019 09:18:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190703233736.5816-2-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMDMsIDIwMTkgYXQgMDQ6Mzc6MzJQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPdXIgcGFzdCBEREktYmFzZWQgSW50ZWwgcGxhdGZvcm1zIGhhdmUgaGFkIGEgZml4ZWQg RERJPC0+UEhZIG1hcHBpbmcuCj4gQmVjYXVzZSBvZiB0aGlzLCBib3RoIHRoZSBic3BlYyBkb2N1 bWVudGF0aW9uIGFuZCBvdXIgaTkxNSBjb2RlIGhhcyB1c2VkCj4gdGhlIHRlcm0gInBvcnQiIHdo ZW4gdGFsa2luZyBhYm91dCBlaXRoZXIgRERJJ3Mgb3IgUEhZJ3M7IGl0IHdhcyBhbHdheXMKPiBl YXN5IHRvIHRlbGwgd2hhdCB0ZXJtcyBsaWtlICJQb3J0IEEiIHdlcmUgcmVmZXJyaW5nIHRvIGZy b20gdGhlCj4gY29udGV4dC4KPiAKPiBVbmZvcnR1bmF0ZWx5IHRoaXMgaXMgc3RhcnRpbmcgdG8g YnJlYWsgZG93biBub3cgdGhhdCBFSEwgYWxsb3dzIFBIWS1BCj4gdG8gYmUgZHJpdmVuIGJ5IGVp dGhlciBEREktQSBvciBEREktRC4gIElzIGEgc2V0dXAgd2l0aCBEREktRCBkcml2aW5nCj4gUEhZ LUEgY29uc2lkZXJlZCAiUG9ydCBBIiBvciAiUG9ydCBEPyIgIFRoZSBhbnN3ZXIgZGVwZW5kcyBv biB3aGljaAo+IHJlZ2lzdGVyIHdlJ3JlIHdvcmtpbmcgd2l0aCwgYW5kIGV2ZW4gdGhlIGJzcGVj IGRvZXNuJ3QgZG8gYSBncmVhdCBqb2IKPiBvZiBjbGFyaWZ5aW5nIHRoaXMuCj4gCj4gTGV0J3Mg dHJ5IHRvIGJlIG1vcmUgZXhwbGljaXQgYWJvdXQgd2hldGhlciB3ZSdyZSB0YWxraW5nIGFib3V0 IHRoZSBEREkKPiBvciB0aGUgUEhZIG9uIGdlbjExKyBieSB1c2luZyAncG9ydCcgdG8gcmVmZXIg dG8gdGhlIERESSBhbmQgY3JlYXRpbmcgYQo+IG5ldyAnZW51bSBwaHknIG5hbWVzcGFjZSB0byBy ZWZlciB0byB0aGUgUEhZIGluIHVzZS4KPiAKPiBUaGlzIHBhdGNoIGp1c3QgYWRkcyB0aGUgbmV3 IFBIWSBuYW1lc3BhY2UsIG5ldyBwaHktYmFzZWQgdmVyc2lvbnMgb2YKPiBpbnRlbF9wb3J0X2lz XyooKSwgYW5kIGEgaGVscGVyIHRvIGNvbnZlcnQgYSBwb3J0IHRvIGEgUEhZLgo+IFRyYW5zaXRp b25pbmcgdmFyaW91cyBhcmVhcyBvZiB0aGUgY29kZSBvdmVyIHRvIHVzaW5nIHRoZSBQSFkgbmFt ZXNwYWNlCj4gd2lsbCBiZSBkb25lIGluIHN1YnNlcXVlbnQgcGF0Y2hlcyB0byBtYWtlIHJldmll dyBlYXNpZXIuICBXZSdsbCByZW1vdmUKPiB0aGUgaW50ZWxfcG9ydF9pc18qKCkgZnVuY3Rpb25z IGF0IHRoZSBlbmQgb2YgdGhlIHNlcmllcyB3aGVuIHdlCj4gdHJhbnNpdGlvbiBhbGwgY2FsbGVy cyBvdmVyIHRvIHVzaW5nIHRoZSBQSFktYmFzZWQgdmVyc2lvbnMuCj4gCj4gdjI6Cj4gIC0gQ29u dmVydCBhIGZldyBtb3JlICdwb3J0JyB1c2VzIHRvICdwaHkuJyAoU3BhcnNlKQo+IAo+IHYzOgo+ ICAtIFN3aXRjaCBERElfQ0xLX1NFTCgpIGJhY2sgdG8gJ3BvcnQuJyAoSm9zZSkKPiAgLSBBZGQg YSBjb2RlIGNvbW1lbnQgY2xhcmlmeWluZyB3aHkgRFBDTEtBX0NGR0NSMF9JQ0wgbmVlZHMgdG8g dXNlIFBIWQo+ICAgIGZvciBpdHMgYml0IGRlZmluaXRpb25zLCBldmVuIHRob3VnaCB0aGUgcmVn aXN0ZXIgZGVzY3JpcHRpb24gaXMKPiAgICBnaXZlbiBpbiB0ZXJtcyBvZiBEREkuCj4gIC0gVG8g YXZvaWQgY29uZnVzaW9uLCBzd2l0Y2ggQ05MJ3MgRFBDTEtBX0NGR0NSMCBkZWZpbmVzIGJhY2sg dG8gdXNpbmcKPiAgICBwb3J0IGFuZCBjcmVhdGUgc2VwYXJhdGUgSUNMKyBkZWZpbml0aW9ucyB0 aGF0IHdvcmsgaW4gdGVybXMgb2YgUEhZLgo+IAo+IHY0Ogo+ICAtIFJlYmFzZSBhbmQgcmVzb2x2 ZSBjb25mbGljdHMgd2l0aCBJbXJlJ3MgVEMgc2VyaWVzLgo+ICAtIFRoaXMgcGF0Y2ggbm93IGp1 c3QgYWRkcyB0aGUgbmFtZXNwYWNlIGFuZCBhIGZldyBjb252ZW5pZW5jZQo+ICAgIGZ1bmN0aW9u czsgdGhlIGltcG9ydGFudCBjaGFuZ2VzIGFyZSBub3cgc3BsaXQgb3V0IGludG8gc2VwYXJhdGUK PiAgICBwYXRjaGVzIHRvIG1ha2UgcmV2aWV3IGVhc2llci4KPiAKPiBTdWdnZXN0ZWQtYnk6IFZp bGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKb3PDqSBS b2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiBDYzogTHVjYXMgRGUgTWFy Y2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGlu dGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYyB8IDMyICsrKysr KysrKysrKysrKysrKystCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlz cGxheS5oIHwgMTYgKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCAgICAgICAgICAgICB8ICAyICsrCj4gIDMgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9k aXNwbGF5L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheS5jCj4gaW5kZXggOTE5ZjVhYzg0NGM4Li40YTg1YWJlZjkzZTcgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC02NjYz LDYgKzY2NjMsMjAgQEAgYm9vbCBpbnRlbF9wb3J0X2lzX2NvbWJvcGh5KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpCj4gIAlyZXR1cm4gZmFsc2U7Cj4g IH0KPiAgCj4gK2Jvb2wgaW50ZWxfcGh5X2lzX2NvbWJvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwgZW51bSBwaHkgcGh5KQo+ICt7Cj4gKwlpZiAocGh5ID09IFBIWV9OT05FKQo+ ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpKQo+ ICsJCXJldHVybiBwaHkgPD0gUEhZX0M7Cj4gKwo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gMTEpCj4gKwkJcmV0dXJuIHBoeSA8PSBQSFlfQjsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4g K30KPiArCj4gIGJvb2wgaW50ZWxfcG9ydF9pc190YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIGVudW0gcG9ydCBwb3J0KQo+ICB7Cj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+PSAxMSAmJiAhSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpKQo+IEBAIC02NjcxLDkgKzY2ODUs MjUgQEAgYm9vbCBpbnRlbF9wb3J0X2lzX3RjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwgZW51bSBwb3J0IHBvcnQpCj4gIAlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4gK2Jvb2wg aW50ZWxfcGh5X2lzX3RjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBw aHkgcGh5KQo+ICt7Cj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSAmJiAhSVNfRUxL SEFSVExBS0UoZGV2X3ByaXYpKQo+ICsJCXJldHVybiBwaHkgPj0gUEhZX0MgJiYgcGh5IDw9IFBI WV9GOwo+ICsKPiArCXJldHVybiBmYWxzZTsKPiArfQo+ICsKPiArZW51bSBwaHkgaW50ZWxfcG9y dF90b19waHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGVudW0gcG9ydCBwb3J0KQo+ ICt7Cj4gKwlpZiAoSVNfRUxLSEFSVExBS0UoaTkxNSkgJiYgcG9ydCA9PSBQT1JUX0QpCj4gKwkJ cmV0dXJuIFBIWV9BOwo+ICsKPiArCXJldHVybiAoZW51bSBwaHkpcG9ydDsKPiArfQo+ICsKPiAg ZW51bSB0Y19wb3J0IGludGVsX3BvcnRfdG9fdGMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiAgewo+IC0JaWYgKCFpbnRlbF9wb3J0X2lzX3RjKGRl dl9wcml2LCBwb3J0KSkKPiArCWlmICghaW50ZWxfcGh5X2lzX3RjKGRldl9wcml2LCBpbnRlbF9w b3J0X3RvX3BoeShkZXZfcHJpdiwgcG9ydCkpKQo+ICAJCXJldHVybiBQT1JUX1RDX05PTkU7Cj4g IAo+ICAJcmV0dXJuIHBvcnQgLSBQT1JUX0M7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kaXNwbGF5LmgKPiBpbmRleCBkMjk2NTU2ZWQ4MmUuLmQ1MzI4NWZiODgzZiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXku aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5oCj4g QEAgLTIyOCw2ICsyMjgsMjEgQEAgc3RydWN0IGludGVsX2xpbmtfbV9uIHsKPiAgCXUzMiBsaW5r X247Cj4gIH07Cj4gIAo+ICtlbnVtIHBoeSB7Cj4gKwlQSFlfTk9ORSA9IC0xLAo+ICsKPiArCVBI WV9BID0gMCwKPiArCVBIWV9CLAo+ICsJUEhZX0MsCj4gKwlQSFlfRCwKPiArCVBIWV9FLAo+ICsJ UEhZX0YsCj4gKwo+ICsJSTkxNV9NQVhfUEhZUwo+ICt9OwoKSSB3YXMgcG9uZGVyaW5nIGlmIHdl IGNvdWxkIGV2ZW50dWFsbHkgZG8gc29tZXRoaW5nIGxpa2U6CgplbnVtIHBoeSB7CglQSFlfQ09N Qk9fQSA9IDAsCglQSFlfQ09NQk9fQiwKCS4uLgoKCVBIWV9UQ18xLAoJUEhZX1RDXzIsCgkuLi4K fTsKCmFuZCBwcm9iYWJseSBhbHNvIGFkZCBlbmNvZGVyLT5waHkgc28gd2UgY2FuIGNvbnRhaW4K dGhhdCBwb3J0PC0+cGh5IG1hcHBpbmcgbG9naWMgaW4gdGhlIGVuY29kZXIgaW5pdC4KSSB0aGlu ayB0aGF0IHNob3VsZCB3b3JrIG1vcmUgb3IgbGVzcyBmaW5lIHNpbmNlIEkKZG9uJ3QgdGhpbmsg UEhZX1RDXzEgbmVlZHMgdG8gaGF2ZSBhbnkgc3BlY2lmaWMgdmFsdWUuCgpVbmZvcnR1bmFsdGV5 IEkgZG9uJ3QgaGF2ZSBhIGdyZWF0IGlkZWEgaG93IHRvIGRvIHRoZQpzYW1lIGZvciB0aGUgRERJ cyBzaW5jZSB0aGVyZSB0aGUgbnVtYmVyIG9mIGNvbWJvIERESXMKY2hhbmdlcyBidXQgd2Ugc3Rp bGwgbmVlZCB0aGUgUE9SVF9UQzEgKGFzc3VtaW5nIHdlIGhhZApvbmUpIHRvIGJlIERESV88bGFz dCBjb21ibyBEREk+ICsgMS4gT25lIHJhbmRvbSBzaWxseQppZGVhIHdhcyB0byBkZWNvdXBsZSB0 aGUgZW51bSBwb3J0IGZyb20gdGhlIHJlZ2lzdGVyCmRlZmluaXRpb25zIGJ5IGhhdmluZyBqdXN0 IHNvbWUga2luZCBvZgplbmNvZGVyLT5wb3J0X2luZGV4IGZvciB0aG9zZS4gQnV0IHRoYXQgZG9l c24ndCBmZWVsCmVudGlyZWx5IGdyZWF0IGVpdGhlci4KCkFueXdheXMsIHNvbWV0aGluZyB0byB0 aGluayBhYm91dCBpbiB0aGUgZnV0dXJlIHBlcmhhcHMuCgpQYXRjaCBpcwpSZXZpZXdlZC1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwo+ICsj ZGVmaW5lIHBoeV9uYW1lKGEpICgoYSkgKyAnQScpCj4gKwo+ICAjZGVmaW5lIGZvcl9lYWNoX3Bp cGUoX19kZXZfcHJpdiwgX19wKSBcCj4gIAlmb3IgKChfX3ApID0gMDsgKF9fcCkgPCBJTlRFTF9J TkZPKF9fZGV2X3ByaXYpLT5udW1fcGlwZXM7IChfX3ApKyspCj4gIAo+IEBAIC0zNTYsNSArMzcx LDYgQEAgdm9pZCBscHRfZGlzYWJsZV9jbGtvdXRfZHAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KTsKPiAgdTMyIGludGVsX3BsYW5lX2ZiX21heF9zdHJpZGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICAgICB1MzIgcGl4ZWxfZm9ybWF0LCB1NjQg bW9kaWZpZXIpOwo+ICBib29sIGludGVsX3BsYW5lX2Nhbl9yZW1hcChjb25zdCBzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKTsKPiArZW51bSBwaHkgaW50ZWxfcG9ydF90b19w aHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGVudW0gcG9ydCBwb3J0KTsKPiAgCj4g ICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggMjRjNjNlZDQ1YzZmLi44 MTVjMjZjMGI5OGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0xNDkzLDcg KzE0OTMsOSBAQCB2b2lkIGludGVsX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIg KmVuY29kZXIpOwo+ICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqCj4gIGludGVsX2VuY29kZXJf Y3VycmVudF9tb2RlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKTsKPiAgYm9vbCBpbnRl bF9wb3J0X2lzX2NvbWJvcGh5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51 bSBwb3J0IHBvcnQpOwo+ICtib29sIGludGVsX3BoeV9pc19jb21ibyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGh5IHBoeSk7Cj4gIGJvb2wgaW50ZWxfcG9ydF9pc190 YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcG9ydCBwb3J0KTsKPiAr Ym9vbCBpbnRlbF9waHlfaXNfdGMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBl bnVtIHBoeSBwaHkpOwo+ICBlbnVtIHRjX3BvcnQgaW50ZWxfcG9ydF90b190YyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICAgIGVudW0gcG9ydCBwb3J0KTsKPiAg aW50IGludGVsX2dldF9waXBlX2Zyb21fY3J0Y19pZF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCB2b2lkICpkYXRhLAo+IC0tIAo+IDIuMTcuMgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=