All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful
Date: Sat, 6 Jul 2019 19:52:14 +0300	[thread overview]
Message-ID: <20190706165214.GB18182@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190706142738.GA6893@kunai>

On Sat, Jul 06, 2019 at 04:27:38PM +0200, Wolfram Sang wrote:
>
> In the parts of the Kernel I work with, reviews are usually given by a plain
> tag. I think this is not enough to keep a good code quality, so I'll start with
> my theses first:
>
> 1) we need a better distinction between Acked-by: and Reviewed-by: and encourage
>    stricter use of that

Agree

>
> 2) Reviewed-by should have a description of the review done (and the review not
>    done)

IMHO, this path of thinking will lead us to less reviews due to an extra
work and wouldn't bring an extra quality which we want.

Right now, everything is built on trust and it will continue to be after
we will demand to add extra sentence. It means that we don't fully trust
in Reviewed-by of one time contributors now and we won't trust in their
description of their Reviewed-by either.

Thanks

  reply	other threads:[~2019-07-06 16:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-06 14:27 [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful Wolfram Sang
2019-07-06 16:52 ` Leon Romanovsky [this message]
2019-07-06 17:17   ` Wolfram Sang
2019-07-08 10:47     ` Jan Kara
2019-07-08 11:47       ` Wolfram Sang
2019-07-15 16:11     ` Mauro Carvalho Chehab
2019-07-08 11:21 ` Geert Uytterhoeven
2019-07-08 11:59   ` Wolfram Sang
2019-07-15 15:58     ` Mauro Carvalho Chehab
2019-07-15 17:00       ` Theodore Y. Ts'o
2019-07-15 17:11         ` Mauro Carvalho Chehab
2019-07-16 21:26         ` Wolfram Sang
2019-08-17 21:35         ` Paul Walmsley
2019-08-19  6:57           ` Jan Kara
2019-08-19  7:06             ` Jiri Kosina
2019-08-19  7:06             ` Julia Lawall
2019-08-19  8:04               ` Jan Kara
2019-08-19  8:13                 ` Julia Lawall
2019-08-20 10:22                   ` James Bottomley
2019-08-19  8:26             ` Thomas Gleixner
2019-08-19 16:16               ` Christian Brauner
2019-08-19 19:04                 ` Thomas Gleixner
2019-08-19 21:03                   ` Christian Brauner
2019-07-08 14:57   ` Mark Brown
2019-07-14  9:35 ` Jonathan Cameron
2019-07-14 10:13   ` Thomas Gleixner
2019-07-15  9:10     ` Rafael J. Wysocki
2019-07-16 21:16     ` Wolfram Sang
2019-07-16 21:57       ` Olof Johansson
2019-07-16 22:27         ` Thomas Gleixner
2019-07-17  3:59           ` Randy Dunlap
2019-07-17  7:31             ` Wolfram Sang
2019-07-17 16:05               ` Linus Walleij
2019-07-17 16:40                 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190706165214.GB18182@mtr-leonro.mtl.com \
    --to=leon@kernel.org \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.