From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Jacques Hiblot Subject: [PATCH v2 1/4] leds: Add of_led_get() and led_put() Date: Mon, 8 Jul 2019 12:26:57 +0200 Message-ID: <20190708102700.23138-2-jjhiblot@ti.com> References: <20190708102700.23138-1-jjhiblot@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190708102700.23138-1-jjhiblot@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, dmurphy@ti.com, Jean-Jacques Hiblot , linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org RnJvbTogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2VpbmVuQHRpLmNvbT4KClRoaXMgcGF0Y2gg YWRkcyBiYXNpYyBzdXBwb3J0IGZvciBhIGtlcm5lbCBkcml2ZXIgdG8gZ2V0IGEgTEVEIGRldmlj ZS4KVGhpcyB3aWxsIGJlIHVzZWQgYnkgdGhlIGxlZC1iYWNrbGlnaHQgZHJpdmVyLgoKT25seSBP RiB2ZXJzaW9uIGlzIGltcGxlbWVudGVkIGZvciBub3csIGFuZCB0aGUgYmVoYXZpb3IgaXMgc2lt aWxhciB0bwpQV00ncyBvZl9wd21fZ2V0KCkgYW5kIHB3bV9wdXQoKS4KClNpZ25lZC1vZmYtYnk6 IFRvbWkgVmFsa2VpbmVuIDx0b21pLnZhbGtlaW5lbkB0aS5jb20+ClNpZ25lZC1vZmYtYnk6IEpl YW4tSmFjcXVlcyBIaWJsb3QgPGpqaGlibG90QHRpLmNvbT4KLS0tCiBkcml2ZXJzL2xlZHMvbGVk LWNsYXNzLmMgfCA1MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBp bmNsdWRlL2xpbnV4L2xlZHMuaCAgICAgfCAgNCArKysrCiAyIGZpbGVzIGNoYW5nZWQsIDU0IGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvbGVkLWNsYXNzLmMgYi9kcml2 ZXJzL2xlZHMvbGVkLWNsYXNzLmMKaW5kZXggZTAxYjJkOTgyNTY0Li4wZjY3YjEzYjBmMWYgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvbGVkcy9sZWQtY2xhc3MuYworKysgYi9kcml2ZXJzL2xlZHMvbGVk LWNsYXNzLmMKQEAgLTE5LDYgKzE5LDcgQEAKICNpbmNsdWRlIDxsaW51eC90aW1lci5oPgogI2lu Y2x1ZGUgPGxpbnV4L3JlZ3VsYXRvci9jb25zdW1lci5oPgogI2luY2x1ZGUgPHVhcGkvbGludXgv dWxlZHMuaD4KKyNpbmNsdWRlIDxsaW51eC9vZi5oPgogI2luY2x1ZGUgImxlZHMuaCIKIAogc3Rh dGljIHN0cnVjdCBjbGFzcyAqbGVkc19jbGFzczsKQEAgLTIxNCw2ICsyMTUsNTUgQEAgc3RhdGlj IGludCBsZWRfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKIAogc3RhdGljIFNJTVBMRV9ERVZf UE1fT1BTKGxlZHNfY2xhc3NfZGV2X3BtX29wcywgbGVkX3N1c3BlbmQsIGxlZF9yZXN1bWUpOwog CitzdGF0aWMgaW50IGxlZF9tYXRjaF9sZWRfbm9kZShzdHJ1Y3QgZGV2aWNlICpsZWRfZGV2LCBj b25zdCB2b2lkICpkYXRhKQoreworCXJldHVybiBsZWRfZGV2LT5vZl9ub2RlID09IGRhdGEgPyAx IDogMDsKK30KKworLyoqCisgKiBvZl9sZWRfZ2V0KCkgLSByZXF1ZXN0IGEgTEVEIGRldmljZSB2 aWEgdGhlIExFRCBmcmFtZXdvcmsKKyAqIEBucDogZGV2aWNlIG5vZGUgdG8gZ2V0IHRoZSBMRUQg ZGV2aWNlIGZyb20KKyAqIEBpbmRleDogdGhlIGluZGV4IG9mIHRoZSBMRUQKKyAqCisgKiBSZXR1 cm5zIHRoZSBMRUQgZGV2aWNlIHBhcnNlZCBmcm9tIHRoZSBwaGFuZGxlIHNwZWNpZmllZCBpbiB0 aGUgImxlZHMiCisgKiBwcm9wZXJ0eSBvZiBhIGRldmljZSB0cmVlIG5vZGUgb3IgYSBuZWdhdGl2 ZSBlcnJvci1jb2RlIG9uIGZhaWx1cmUuCisgKi8KK3N0cnVjdCBsZWRfY2xhc3NkZXYgKm9mX2xl ZF9nZXQoc3RydWN0IGRldmljZV9ub2RlICpucCwgaW50IGluZGV4KQoreworCXN0cnVjdCBkZXZp Y2UgKmxlZF9kZXY7CisJc3RydWN0IGxlZF9jbGFzc2RldiAqbGVkX2NkZXY7CisJc3RydWN0IGRl dmljZV9ub2RlICpsZWRfbm9kZTsKKworCWxlZF9ub2RlID0gb2ZfcGFyc2VfcGhhbmRsZShucCwg ImxlZHMiLCBpbmRleCk7CisJaWYgKCFsZWRfbm9kZSkKKwkJcmV0dXJuIEVSUl9QVFIoLUVOT0VO VCk7CisKKwlsZWRfZGV2ID0gY2xhc3NfZmluZF9kZXZpY2UobGVkc19jbGFzcywgTlVMTCwgbGVk X25vZGUsCisJCWxlZF9tYXRjaF9sZWRfbm9kZSk7CisJb2Zfbm9kZV9wdXQobGVkX25vZGUpOwor CisJaWYgKCFsZWRfZGV2KQorCQlyZXR1cm4gRVJSX1BUUigtRVBST0JFX0RFRkVSKTsKKworCWxl ZF9jZGV2ID0gZGV2X2dldF9kcnZkYXRhKGxlZF9kZXYpOworCisJaWYgKCF0cnlfbW9kdWxlX2dl dChsZWRfY2Rldi0+ZGV2LT5wYXJlbnQtPmRyaXZlci0+b3duZXIpKQorCQlyZXR1cm4gRVJSX1BU UigtRU5PREVWKTsKKworCXJldHVybiBsZWRfY2RldjsKK30KK0VYUE9SVF9TWU1CT0xfR1BMKG9m X2xlZF9nZXQpOworCisvKioKKyAqIGxlZF9wdXQoKSAtIHJlbGVhc2UgYSBMRUQgZGV2aWNlCisg KiBAbGVkX2NkZXY6IExFRCBkZXZpY2UKKyAqLwordm9pZCBsZWRfcHV0KHN0cnVjdCBsZWRfY2xh c3NkZXYgKmxlZF9jZGV2KQoreworCW1vZHVsZV9wdXQobGVkX2NkZXYtPmRldi0+cGFyZW50LT5k cml2ZXItPm93bmVyKTsKK30KK0VYUE9SVF9TWU1CT0xfR1BMKGxlZF9wdXQpOworCiBzdGF0aWMg aW50IG1hdGNoX25hbWUoc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCB2b2lkICpkYXRhKQogewog CWlmICghZGV2X25hbWUoZGV2KSkKZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbGVkcy5oIGIv aW5jbHVkZS9saW51eC9sZWRzLmgKaW5kZXggYmVlOGUzZjhkZGRkLi4wYTcxYzdjZGQxOTEgMTAw NjQ0Ci0tLSBhL2luY2x1ZGUvbGludXgvbGVkcy5oCisrKyBiL2luY2x1ZGUvbGludXgvbGVkcy5o CkBAIC0xOSw2ICsxOSw3IEBACiAKIHN0cnVjdCBkZXZpY2U7CiBzdHJ1Y3QgbGVkX3BhdHRlcm47 CitzdHJ1Y3QgZGV2aWNlX25vZGU7CiAvKgogICogTEVEIENvcmUKICAqLwpAQCAtMTQ1LDYgKzE0 Niw5IEBAIGV4dGVybiB2b2lkIGRldm1fbGVkX2NsYXNzZGV2X3VucmVnaXN0ZXIoc3RydWN0IGRl dmljZSAqcGFyZW50LAogZXh0ZXJuIHZvaWQgbGVkX2NsYXNzZGV2X3N1c3BlbmQoc3RydWN0IGxl ZF9jbGFzc2RldiAqbGVkX2NkZXYpOwogZXh0ZXJuIHZvaWQgbGVkX2NsYXNzZGV2X3Jlc3VtZShz dHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2Rldik7CiAKK2V4dGVybiBzdHJ1Y3QgbGVkX2NsYXNz ZGV2ICpvZl9sZWRfZ2V0KHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsIGludCBpbmRleCk7CitleHRl cm4gdm9pZCBsZWRfcHV0KHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2KTsKKwogLyoqCiAg KiBsZWRfYmxpbmtfc2V0IC0gc2V0IGJsaW5raW5nIHdpdGggc29mdHdhcmUgZmFsbGJhY2sKICAq IEBsZWRfY2RldjogdGhlIExFRCB0byBzdGFydCBibGlua2luZwotLSAKMi4xNy4xCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4DFC606A7 for ; Mon, 8 Jul 2019 10:27:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25A1F20656 for ; Mon, 8 Jul 2019 10:27:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="IALIVZ21" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730075AbfGHK1S (ORCPT ); Mon, 8 Jul 2019 06:27:18 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:56726 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbfGHK1R (ORCPT ); Mon, 8 Jul 2019 06:27:17 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x68AR8Ek001158; Mon, 8 Jul 2019 05:27:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1562581628; bh=nU97vt4bCNmMA9ZfacNjLitUhnqsxdeLpbW/G535FUs=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=IALIVZ21mIgDrPQI8jb8XaoY+HoEAvL97SpvScqL1dZifhh55mpNjUuNv3uAePeZM Mr15vfe+1wW4KqcfwBDzBwtIXbotJRgrpwxIbvpqIOb8Zb/h9FAfDVcxEhB9veIUdK AOMfvHnuUOqgdUMexlPR8L8CTjNvHIjY1Jqfdj2A= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x68AR88q111993 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 8 Jul 2019 05:27:08 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 8 Jul 2019 05:27:08 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 8 Jul 2019 05:27:08 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x68AR7tK074648; Mon, 8 Jul 2019 05:27:08 -0500 From: Jean-Jacques Hiblot To: , , , , , , CC: , , , , , Jean-Jacques Hiblot Subject: [PATCH v2 1/4] leds: Add of_led_get() and led_put() Date: Mon, 8 Jul 2019 12:26:57 +0200 Message-ID: <20190708102700.23138-2-jjhiblot@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190708102700.23138-1-jjhiblot@ti.com> References: <20190708102700.23138-1-jjhiblot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Message-ID: <20190708102657.7CCrGpgOe9N2VbHrsx18F_Fcf38iUE9c3X_18KPUEy0@z> From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the behavior is similar to PWM's of_pwm_get() and pwm_put(). Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 50 ++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 4 ++++ 2 files changed, 54 insertions(+) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index e01b2d982564..0f67b13b0f1f 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "leds.h" static struct class *leds_class; @@ -214,6 +215,55 @@ static int led_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(leds_class_dev_pm_ops, led_suspend, led_resume); +static int led_match_led_node(struct device *led_dev, const void *data) +{ + return led_dev->of_node == data ? 1 : 0; +} + +/** + * of_led_get() - request a LED device via the LED framework + * @np: device node to get the LED device from + * @index: the index of the LED + * + * Returns the LED device parsed from the phandle specified in the "leds" + * property of a device tree node or a negative error-code on failure. + */ +struct led_classdev *of_led_get(struct device_node *np, int index) +{ + struct device *led_dev; + struct led_classdev *led_cdev; + struct device_node *led_node; + + led_node = of_parse_phandle(np, "leds", index); + if (!led_node) + return ERR_PTR(-ENOENT); + + led_dev = class_find_device(leds_class, NULL, led_node, + led_match_led_node); + of_node_put(led_node); + + if (!led_dev) + return ERR_PTR(-EPROBE_DEFER); + + led_cdev = dev_get_drvdata(led_dev); + + if (!try_module_get(led_cdev->dev->parent->driver->owner)) + return ERR_PTR(-ENODEV); + + return led_cdev; +} +EXPORT_SYMBOL_GPL(of_led_get); + +/** + * led_put() - release a LED device + * @led_cdev: LED device + */ +void led_put(struct led_classdev *led_cdev) +{ + module_put(led_cdev->dev->parent->driver->owner); +} +EXPORT_SYMBOL_GPL(led_put); + static int match_name(struct device *dev, const void *data) { if (!dev_name(dev)) diff --git a/include/linux/leds.h b/include/linux/leds.h index bee8e3f8dddd..0a71c7cdd191 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -19,6 +19,7 @@ struct device; struct led_pattern; +struct device_node; /* * LED Core */ @@ -145,6 +146,9 @@ extern void devm_led_classdev_unregister(struct device *parent, extern void led_classdev_suspend(struct led_classdev *led_cdev); extern void led_classdev_resume(struct led_classdev *led_cdev); +extern struct led_classdev *of_led_get(struct device_node *np, int index); +extern void led_put(struct led_classdev *led_cdev); + /** * led_blink_set - set blinking with software fallback * @led_cdev: the LED to start blinking -- 2.17.1