From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FC5C73C53 for ; Tue, 9 Jul 2019 16:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB5D42080C for ; Tue, 9 Jul 2019 16:14:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726346AbfGIQO6 (ORCPT ); Tue, 9 Jul 2019 12:14:58 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:60940 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfGIQO5 (ORCPT ); Tue, 9 Jul 2019 12:14:57 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hkslc-0004cd-HB; Wed, 10 Jul 2019 00:14:56 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hkslY-0002UP-NI; Wed, 10 Jul 2019 00:14:52 +0800 Date: Wed, 10 Jul 2019 00:14:52 +0800 From: Herbert Xu To: Ondrej Mosnacek Cc: linux-crypto@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Stephan Mueller , Steffen Klassert , Don Zickus Subject: Re: [PATCH] crypto: user - make NETLINK_CRYPTO work inside netns Message-ID: <20190709161452.54gxs7fwif7hs7dx@gondor.apana.org.au> References: <20190709111124.31127-1-omosnace@redhat.com> <20190709143832.hej23rahmb4basy6@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 09, 2019 at 05:28:35PM +0200, Ondrej Mosnacek wrote: > > I admit I'm not an expert on Linux namespaces, but aren't you > confusing network and user namespaces? Unless I'm mistaken, these > changes only affect _network_ namespaces (which only isolate the > network stuff itself) and the semantics of the netlink_capable(skb, > CAP_NET_ADMIN) calls remain unchanged - they check if the opener of > the socket has the CAP_NET_ADMIN capability within the global _user_ > namespace. Good point. I think your patch should be OK then. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt