[PATCH] ASoC: audio-graph-card: add missing const at graph_get_dai_id()

[PATCH] ASoC: audio-graph-card: add missing const at graph_get_dai_id()

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

commit c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in
graph_get_dai_id()") fixups use-after-free issue,
but, it need to use "const" for reg. This patch adds it.

We will have below without this patch

LINUX/sound/soc/generic/audio-graph-card.c: In function 'graph_get_dai_id':
LINUX/sound/soc/generic/audio-graph-card.c:87:7: warning: assignment discards\
 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   reg = of_get_property(node, "reg", NULL);

Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/generic/audio-graph-card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
index 343ede8..ebf2ca3 100644
--- a/sound/soc/generic/audio-graph-card.c
+++ b/sound/soc/generic/audio-graph-card.c
@@ -63,7 +63,7 @@ static int graph_get_dai_id(struct device_node *ep)
 	struct device_node *endpoint;
 	struct of_endpoint info;
 	int i, id;
-	u32 *reg;
+	const u32 *reg;
 	int ret;
 
 	/* use driver specified DAI ID if exist */
-- 
2.7.4

Re: [PATCH] ASoC: audio-graph-card: add missing const at graph_get_dai_id()

[wen.yang99]

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> commit c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in
> graph_get_dai_id()") fixups use-after-free issue,
> but, it need to use "const" for reg. This patch adds it.
> 
> We will have below without this patch
> 
> LINUX/sound/soc/generic/audio-graph-card.c: In function 'graph_get_dai_id':
> LINUX/sound/soc/generic/audio-graph-card.c:87:7: warning: assignment discards\
> 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> reg = of_get_property(node, "reg", NULL);
> 
> Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/generic/audio-graph-card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
> index 343ede8..ebf2ca3 100644
> --- a/sound/soc/generic/audio-graph-card.c
> +++ b/sound/soc/generic/audio-graph-card.c
> @@ -63,7 +63,7 @@ static int graph_get_dai_id(struct device_node *ep)
> struct device_node *endpoint;
> struct of_endpoint info;
> int i, id;
> -    u32 *reg;
> +    const u32 *reg;
> int ret;
> 
> /* use driver specified DAI ID if exist */
> --
> 2.7.4

Thanks.
Acked-by: Wen Yang <wen.yang99@zte.com.cn>

---
Best regards
Wen

Applied "ASoC: audio-graph-card: add missing const at graph_get_dai_id()" to the asoc tree

[Mark Brown]

The patch

   ASoC: audio-graph-card: add missing const at graph_get_dai_id()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Thu, 11 Jul 2019 13:10:45 +0900
Subject: [PATCH] ASoC: audio-graph-card: add missing const at
 graph_get_dai_id()

commit c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in
graph_get_dai_id()") fixups use-after-free issue,
but, it need to use "const" for reg. This patch adds it.

We will have below without this patch

LINUX/sound/soc/generic/audio-graph-card.c: In function 'graph_get_dai_id':
LINUX/sound/soc/generic/audio-graph-card.c:87:7: warning: assignment discards\
 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   reg = of_get_property(node, "reg", NULL);

Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Wen Yang <wen.yang99@zte.com.cn>
Link: https://lore.kernel.org/r/87sgrd43ja.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/generic/audio-graph-card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
index 343ede8042c3..ebf2ca3249cb 100644
--- a/sound/soc/generic/audio-graph-card.c
+++ b/sound/soc/generic/audio-graph-card.c
@@ -63,7 +63,7 @@ static int graph_get_dai_id(struct device_node *ep)
 	struct device_node *endpoint;
 	struct of_endpoint info;
 	int i, id;
-	u32 *reg;
+	const u32 *reg;
 	int ret;
 
 	/* use driver specified DAI ID if exist */
-- 
2.20.1

Re: Applied "ASoC: audio-graph-card: add missing const at graph_get_dai_id()" to the asoc tree

[Kuninori Morimoto]

Hi Mark

> Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Wen Yang <wen.yang99@zte.com.cn>
> Link: https://lore.kernel.org/r/87sgrd43ja.wl-kuninori.morimoto.gx@renesas.com
> Signed-off-by: Mark Brown <broonie@kernel.org>

I noticed that latest commit has "Link" line,
but, it will be "404 Not Found" for me.
Is this bug ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto

Re: Applied "ASoC: audio-graph-card: add missing const at graph_get_dai_id()" to the asoc tree

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]

On Fri, Jul 12, 2019 at 04:45:10PM +0900, Kuninori Morimoto wrote:
> > Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Acked-by: Wen Yang <wen.yang99@zte.com.cn>
> > Link: https://lore.kernel.org/r/87sgrd43ja.wl-kuninori.morimoto.gx@renesas.com
> > Signed-off-by: Mark Brown <broonie@kernel.org>

> I noticed that latest commit has "Link" line,
> but, it will be "404 Not Found" for me.
> Is this bug ?

It's because alsa-devel isn't archived by lore and you didn't CC
to any list that is.  I guess we should look at getting the list
archived on lore.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]