From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA3BC7618F for ; Mon, 15 Jul 2019 13:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7B7F2083D for ; Mon, 15 Jul 2019 13:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198851; bh=mSBn9lkg/YU7uvkSnA6Q231i2Hl8tCfpjefingHG2pI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hmaSZpLata/RjcqzX0Cw3m4Q9g4LUgYGTyJZIdpWEhsWsScyiHbIDbY6KhOV3FMRB 4HNuejqO1g0qDlt2Db1oOZ2R7RKTWYJ1IztbFmD0KUPEo3q311AB3lVQjET+RFJuA2 DuyfCrDgaFrNtF3Mmrz+ehDrlW95v2YbbF5r3UQE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732177AbfGONyK (ORCPT ); Mon, 15 Jul 2019 09:54:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731710AbfGONyI (ORCPT ); Mon, 15 Jul 2019 09:54:08 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 941BE2083D; Mon, 15 Jul 2019 13:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198847; bh=mSBn9lkg/YU7uvkSnA6Q231i2Hl8tCfpjefingHG2pI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=piFbSbnuZ+uGelNn8HhCZhQwRfR9rTsr1z9HMp8gZALeAiN9/1KjRG0MAQoMH7YRv B5TgiAOsl1lTqDOwJfYpPffzgum7v4/B3/upwkj9FMmylssR0c9cvOw6XB4OxF412L WaGdUQf2hh5qFi6vPRme9WOEMAWZMaESDfNurMqU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Leo Yan , Adrian Hunter , Jiri Olsa , Namhyung Kim , Sasha Levin Subject: [PATCH AUTOSEL 5.2 118/249] perf evsel: Make perf_evsel__name() accept a NULL argument Date: Mon, 15 Jul 2019 09:44:43 -0400 Message-Id: <20190715134655.4076-118-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715134655.4076-1-sashal@kernel.org> References: <20190715134655.4076-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo [ Upstream commit fdbdd7e8580eac9bdafa532746c865644d125e34 ] In which case it simply returns "unknown", like when it can't figure out the evsel->name value. This makes this code more robust and fixes a problem in 'perf trace' where a NULL evsel was being passed to a routine that only used the evsel for printing its name when a invalid syscall id was passed. Reported-by: Leo Yan Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-f30ztaasku3z935cn3ak3h53@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/evsel.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 4a5947625c5c..2c46f9aa416c 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -589,6 +589,9 @@ const char *perf_evsel__name(struct perf_evsel *evsel) { char bf[128]; + if (!evsel) + goto out_unknown; + if (evsel->name) return evsel->name; @@ -628,7 +631,10 @@ const char *perf_evsel__name(struct perf_evsel *evsel) evsel->name = strdup(bf); - return evsel->name ?: "unknown"; + if (evsel->name) + return evsel->name; +out_unknown: + return "unknown"; } const char *perf_evsel__group_name(struct perf_evsel *evsel) -- 2.20.1