From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2261C76191 for ; Mon, 15 Jul 2019 14:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F35E212F5 for ; Mon, 15 Jul 2019 14:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202327; bh=moKrtbUY4SL4acuFQ9lGuNURkv6PVQyr7pHxqXZS0iw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zMc1riWE1Pf3lMu55Bfwq2vqDN2Ic2ls7fwJfSn/z0WTsz5iI2qzCmNVCkeNdR3VR sen14AtM4XYspO1Xc/+ytxDnjaBQn+9f22CkCiD0SO03fskFTacgZ+1bLxMwJUVerW zE+iqxp5omYt5GhICNj1dcCWGrqkizF/S5G+aePw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404925AbfGOOwG (ORCPT ); Mon, 15 Jul 2019 10:52:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:45114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391784AbfGOObW (ORCPT ); Mon, 15 Jul 2019 10:31:22 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22D7620C01; Mon, 15 Jul 2019 14:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201082; bh=moKrtbUY4SL4acuFQ9lGuNURkv6PVQyr7pHxqXZS0iw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WgTSIlgG44h+79EipbxN4ANOiawFn9EY/CVs2WTOy4C4yfEh3Es0jL6yGvgQ9iUSR 97ZLIvecTaY+y95zwTWNPvgLslxM+uoPKkYAgzU55bNO7rFL7i50lPVulfuA2mZE5G Jd9EV1AwMlOB60SDYW/MLEdkeOv8BHuX9i6St878= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivas Kandagatla , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.14 046/105] regmap: fix bulk writes on paged registers Date: Mon, 15 Jul 2019 10:27:40 -0400 Message-Id: <20190715142839.9896-46-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715142839.9896-1-sashal@kernel.org> References: <20190715142839.9896-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit db057679de3e9e6a03c1bcd5aee09b0d25fd9f5b ] On buses like SlimBus and SoundWire which does not support gather_writes yet in regmap, A bulk write on paged register would be silently ignored after programming page. This is because local variable 'ret' value in regmap_raw_write_impl() gets reset to 0 once page register is written successfully and the code below checks for 'ret' value to be -ENOTSUPP before linearising the write buffer to send to bus->write(). Fix this by resetting the 'ret' value to -ENOTSUPP in cases where gather_writes() is not supported or single register write is not possible. Signed-off-by: Srinivas Kandagatla Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/base/regmap/regmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 8fd08023c0f5..013d0a2b3ba0 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1509,6 +1509,8 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, map->format.reg_bytes + map->format.pad_bytes, val, val_len); + else + ret = -ENOTSUPP; /* If that didn't work fall back on linearising by hand. */ if (ret == -ENOTSUPP) { -- 2.20.1