From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC8EC7618F for ; Mon, 15 Jul 2019 14:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A492B217D9 for ; Mon, 15 Jul 2019 14:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201394; bh=zBOV75eXuCouknI/+goA12nzOEQULs3BcNP59PJPHV0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oLIUW+0/wjqtnOHpRwiylyHqhwfqPSRHj9CX7XyLClb+zK8oFr56IWb9fMpB39BAR GMnPgeUlxWujb4WANemqcV1NGWiO7bsigGkIM7QBebZSjg3dBWBhAJm5RZgjSSLCZW kTT2+EAJaPCsyNGap9wV787/IYGv9ayu6KuahXa8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391591AbfGOOcR (ORCPT ); Mon, 15 Jul 2019 10:32:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:46908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391819AbfGOOcM (ORCPT ); Mon, 15 Jul 2019 10:32:12 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DCFF2086C; Mon, 15 Jul 2019 14:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201131; bh=zBOV75eXuCouknI/+goA12nzOEQULs3BcNP59PJPHV0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e4AukbRmPUbv3VcRwo1aUiR2UrMcR0DM7BgsSovHESYbuMSBkHo76QN/gdRsyct7J Tf1brYkC85DI6L+EEIfXd0VWtIojBG8d28oHdgpPm3ru/gSiXlB7QapUBpOaqHoiZZ FC9zAqUsolD7j+xGJRsji7S5IaBRf6y49RjgtPPU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Herbert Xu , Steffen Klassert , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 059/105] ipsec: select crypto ciphers for xfrm_algo Date: Mon, 15 Jul 2019 10:27:53 -0400 Message-Id: <20190715142839.9896-59-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715142839.9896-1-sashal@kernel.org> References: <20190715142839.9896-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 597179b0ba550bd83fab1a9d57c42a9343c58514 ] kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER is also required even though it has not popped up in build tests. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann Acked-by: Herbert Xu Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/xfrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 286ed25c1a69..2e747ae7dc89 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -14,6 +14,8 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH + select CRYPTO_BLKCIPHER config XFRM_USER tristate "Transformation user configuration interface" -- 2.20.1