From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732A2C7618F for ; Mon, 15 Jul 2019 14:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40005217F4 for ; Mon, 15 Jul 2019 14:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201415; bh=p/zt7CQEprrne/xmuzstQLRlFAGT5yUOFb/L2hMdoJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=E+RyVJZFs8ngfrC+zk7dd8bdyNT1/P3VXBkJ3B3xgKFdhFym2WeVhEqyEtcr1sl+X 6rUJB989QrXy5wV/jMDX68UEsQppp4OdYXbnXEF3TKGTu1i4roFJR3XKPBs3SL4WO2 AQj+ILr1BBYbyJAWRTV6CA3m3aLWsRURy4RDn8tg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404080AbfGOOgy (ORCPT ); Mon, 15 Jul 2019 10:36:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:57496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404007AbfGOOgt (ORCPT ); Mon, 15 Jul 2019 10:36:49 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B454B217F9; Mon, 15 Jul 2019 14:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201408; bh=p/zt7CQEprrne/xmuzstQLRlFAGT5yUOFb/L2hMdoJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wHMZ/ZtspIIR/gJ19LihSdFQSIQkqrX2tnD4wciea7WZ7Yfu1lXUfrOHJ61n/DK9s w2E1NNIuUcWz0hSkv/ud8lcjb1OZrxoC6b1v6hJQ/h+U9c1n1U1AFECsDLPEw6IyVS OmBk/u8C/EbWcgrZC2RfeQLkqHHOZu8X8OxuzLx4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeremy Sowden , syzbot+d454a826e670502484b8@syzkaller.appspotmail.com, Simon Wunderlich , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 05/73] batman-adv: fix for leaked TVLV handler. Date: Mon, 15 Jul 2019 10:35:21 -0400 Message-Id: <20190715143629.10893-5-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715143629.10893-1-sashal@kernel.org> References: <20190715143629.10893-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeremy Sowden [ Upstream commit 17f78dd1bd624a4dd78ed5db3284a63ee807fcc3 ] A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index af4a02ad8503..1fab9bcf535d 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3700,6 +3700,8 @@ static void batadv_tt_purge(struct work_struct *work) void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1); -- 2.20.1