From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70117C7618F for ; Mon, 15 Jul 2019 14:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45EA221530 for ; Mon, 15 Jul 2019 14:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202112; bh=xDIQ42ChWf87NqLYQmiqW9h30yxZvey0pdV86at6Hx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BGgkL6kNXWm4V/9w6kd6stXu1ad3qta8go31NVILECDOa7aYPglsnxLT5AxrQAM33 oqP5J/laSdgK7jlrIOyDW8/rLqlSMf3WGg8+63mYo77+Rm7ub78l6vFkSKI/SxyoEI 0glVwl1Sw3in26U7T/xpoKiVRjGgFEVe8PgMwjZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404568AbfGOOsa (ORCPT ); Mon, 15 Jul 2019 10:48:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:45742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732499AbfGOOsZ (ORCPT ); Mon, 15 Jul 2019 10:48:25 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4887B2086C; Mon, 15 Jul 2019 14:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202104; bh=xDIQ42ChWf87NqLYQmiqW9h30yxZvey0pdV86at6Hx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TTilYgkbb1WcXgh6QpNAmWsuIaQE0TFX2wlIZZmKI7HkwLsJhkYcOjnRW1FGCv7/a uEEjWVWXW9YDaqcJwJ5mqWuNznILn4okTS+mk35SYvGhV9skhMyWnAPbmJIRMABGE8 mDmM4kS0PArZ77lj34TB1oLODZkh0Un5DLWgDZ04= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ferdinand Blomqvist , Thomas Gleixner , Sasha Levin Subject: [PATCH AUTOSEL 4.4 46/53] rslib: Fix handling of of caller provided syndrome Date: Mon, 15 Jul 2019 10:45:28 -0400 Message-Id: <20190715144535.11636-46-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715144535.11636-1-sashal@kernel.org> References: <20190715144535.11636-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ferdinand Blomqvist [ Upstream commit ef4d6a8556b637ad27c8c2a2cff1dda3da38e9a9 ] Check if the syndrome provided by the caller is zero, and act accordingly. Signed-off-by: Ferdinand Blomqvist Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/20190620141039.9874-6-ferdinand.blomqvist@gmail.com Signed-off-by: Sasha Levin --- lib/reed_solomon/decode_rs.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/reed_solomon/decode_rs.c b/lib/reed_solomon/decode_rs.c index 8eed0f9ac495..a5d313381539 100644 --- a/lib/reed_solomon/decode_rs.c +++ b/lib/reed_solomon/decode_rs.c @@ -42,8 +42,18 @@ BUG_ON(pad < 0 || pad >= nn); /* Does the caller provide the syndrome ? */ - if (s != NULL) - goto decode; + if (s != NULL) { + for (i = 0; i < nroots; i++) { + /* The syndrome is in index form, + * so nn represents zero + */ + if (s[i] != nn) + goto decode; + } + + /* syndrome is zero, no errors to correct */ + return 0; + } /* form the syndromes; i.e., evaluate data(x) at roots of * g(x) */ -- 2.20.1