From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CC4C7618F for ; Tue, 16 Jul 2019 19:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AC6B2145D for ; Tue, 16 Jul 2019 19:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388665AbfGPTlt (ORCPT ); Tue, 16 Jul 2019 15:41:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728137AbfGPTlt (ORCPT ); Tue, 16 Jul 2019 15:41:49 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 54EC01522472D; Tue, 16 Jul 2019 12:41:48 -0700 (PDT) Date: Tue, 16 Jul 2019 12:41:47 -0700 (PDT) Message-Id: <20190716.124147.446749376298800402.davem@davemloft.net> To: bpoirier@suse.com Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, fyang@suse.com, saeedm@mellanox.com, netdev@vger.kernel.org Subject: Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration From: David Miller In-Reply-To: <20190716081655.7676-1-bpoirier@suse.com> References: <20190716081655.7676-1-bpoirier@suse.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 16 Jul 2019 12:41:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Benjamin Poirier Date: Tue, 16 Jul 2019 17:16:55 +0900 > While changing the number of interrupt channels, be2net stops adapter > operation (including netif_tx_disable()) but it doesn't signal that it > cannot transmit. This may lead dev_watchdog() to falsely trigger during > that time. > > Add the missing call to netif_carrier_off(), following the pattern used in > many other drivers. netif_carrier_on() is already taken care of in > be_open(). > > Signed-off-by: Benjamin Poirier Applied.