All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
	IGT development <igt-dev@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib: Ditch "DRIVER_* for kms tests" cargo cult
Date: Tue, 16 Jul 2019 10:12:34 +0200	[thread overview]
Message-ID: <20190716081234.GS15868@phenom.ffwll.local> (raw)
In-Reply-To: <20190715081019.h36iphyiwlq72mh3@ahiler-desk1.fi.intel.com>

On Mon, Jul 15, 2019 at 11:10:19AM +0300, Arkadiusz Hiler wrote:
> On Thu, Jul 11, 2019 at 07:21:35PM +0200, Daniel Vetter wrote:
> > KMS is meant to be a (at least somewhat) generic userspace API. We do
> > not want nor need to add a special match function for every driver
> > ever written, that doesn't make sense, defeats the point of having
> > generic tests for a generic testsuite, and really doesn't scale.
> > 
> > Also add a comment so people don't try to add ever more of these.
> > 
> > Also, this means no autoloading for you, but really igt should
> > reinvent udev, and mostly this was needed for 2 reasons:
> > - CI configuration falling to pieces because tests unloaded a driver,
> >   and then died before cleaning up.
> > - vgem, which is fake, and needs to be requested explictily.
> > 
> > We might want to throw that all out again, except for vgem.
> > 
> > Cc: Liviu Dudau <liviu.dudau@arm.com>
> > Cc: Deepak Rawat <drawat@vmware.com>
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> > Cc: Leo Li <sunpeng.li@amd.com>
> > Cc: Michał Winiarski <michal.winiarski@intel.com>
> > Cc: "Ser, Simon" <simon.ser@intel.com>
> > Cc: Oleg Vasilev <oleg.vasilev@intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

And pushing, thanks for taking a look.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      reply	other threads:[~2019-07-16  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 17:21 [igt-dev] [PATCH i-g-t] lib: Ditch "DRIVER_* for kms tests" cargo cult Daniel Vetter
2019-07-11 17:40 ` Kazlauskas, Nicholas
2019-07-11 19:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-12 10:00 ` [igt-dev] [PATCH i-g-t] " Ser, Simon
2019-07-13  0:41 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2019-07-15  8:10 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2019-07-16  8:12   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716081234.GS15868@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=arkadiusz.hiler@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=liviu.dudau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.