From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F189C76188 for ; Tue, 16 Jul 2019 11:32:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D3D3620651 for ; Tue, 16 Jul 2019 11:32:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3D3620651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=6wind.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 238863423; Tue, 16 Jul 2019 13:32:06 +0200 (CEST) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id E4FAF3195; Tue, 16 Jul 2019 13:32:04 +0200 (CEST) Received: from lfbn-lil-1-176-160.w90-45.abo.wanadoo.fr ([90.45.26.160] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnLjh-0002UW-9z; Tue, 16 Jul 2019 13:35:10 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Tue, 16 Jul 2019 13:31:56 +0200 Date: Tue, 16 Jul 2019 13:31:56 +0200 From: Olivier Matz To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, thomas@monjalon.net, jerinj@marvell.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, Honnappa.Nagarahalli@arm.com, i.maximets@samsung.com, stable@dpdk.org Message-ID: <20190716113156.nhnirohjmzdbb4wl@platinum> References: <20181212062404.30243-1-gavin.hu@arm.com> <1562946877-50963-2-git-send-email-gavin.hu@arm.com> <20190716090121.6c4aa6u6vp3mhb2q@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190716090121.6c4aa6u6vp3mhb2q@platinum> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote: > On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote: > > Currently, the flush is done by dequeuing the ring in a while loop. It is > > much simpler to flush the queue by resetting the head and tail indices. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org Actually it's not a fix, it adds a new API. Is the patch in hash library intended to be backported? If yes, as it seems to be a performance optimization, you'll need to describe what scenario you're fixing and what is the performance gain. If no, the Cc stable can be removed. Thanks > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Honnappa Nagarahalli > > Acked-by: Olivier Matz