From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06CA2C7618F for ; Wed, 17 Jul 2019 16:38:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA23E21743 for ; Wed, 17 Jul 2019 16:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725873AbfGQQit (ORCPT ); Wed, 17 Jul 2019 12:38:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:59288 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726892AbfGQQit (ORCPT ); Wed, 17 Jul 2019 12:38:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 44AB4AF92; Wed, 17 Jul 2019 16:38:47 +0000 (UTC) Date: Wed, 17 Jul 2019 18:38:51 +0200 From: Petr Vorel To: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org, Roberto Sassu , Thiago Jung Bauermann , Prakhar Srivastava Subject: Re: [PATCH v1 0/5] ima-evm-utils: Assorted fixes and improvements Message-ID: <20190717163851.GA22235@dell5510> Reply-To: Petr Vorel References: <20190707234837.4866-1-vt@altlinux.org> <1562599850.11461.43.camel@linux.ibm.com> <20190709154333.33345iepccstscpv@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190709154333.33345iepccstscpv@altlinux.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Mimi, Vitaly, > Mimi, > On Mon, Jul 08, 2019 at 11:30:50AM -0400, Mimi Zohar wrote: > > [Cc'ing Roberto, Petr, Thiago, Prakhar] > > Now that we're including ALL the kernel exported hash_info algorithms, > > a colleague suggested defining a list of deprecated hash algorithms. > >  Instead of preventing the usage of these deprecated hash algorithms, > > initially I would start out with a warning.  It would be helpful to > > indicate which standard deprecated the hash algorithm and year.  At > > some point, we might want to prevent their usage in signing files, but > > not verifying file signatures. Looks useful to me. > I think this is not a problem, because user explicitly states which hash > algorithm he wants to use. Except for SHA1, which is also silent > fallback algorithm. I think this fallback mechanism should be removed. Agree with removing fallback mechanism. > Also, return values of sign_hash/ima_calc_hash/etc are not defined > clearly and callers have weird checks such as `if (len <= 1)`. I think > this should be conceptually simplified and made them `return -1` on any > error. > > evmctl "ima_measurement" doesn't support custom template definitions. > > Also missing is support for verifying the "ima-buf" kexec command boot > > command line and the "ima-modsig" template appended signature. > > David Jacobson started writing a regression framework and posted a v2 > > version.  I'd really appreciate help with cleaning up that code.  > Maybe tests should be integrated into ima-evm-utils too. https://patchwork.kernel.org/project/linux-integrity/list/?series=95303 > Thanks, Kind regards, Petr