From: Wei Yang <richardw.yang@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap is always 0
Date: Thu, 18 Jul 2019 09:07:51 +0800 [thread overview]
Message-ID: <20190718010751.GA15881@richard> (raw)
In-Reply-To: <4b3016cd-de7b-3ab7-76b8-8608cb1239b6@redhat.com>
On Wed, Jul 17, 2019 at 11:16:19AM +0200, Paolo Bonzini wrote:
>On 17/07/19 03:13, Wei Yang wrote:
>> On Tue, May 14, 2019 at 03:21:08PM +0100, Dr. David Alan Gilbert wrote:
>>> * Wei Yang (richardw.yang@linux.intel.com) wrote:
>>>> Since start of cpu_physical_memory_sync_dirty_bitmap is always 0, we can
>>>> remove this parameter and simplify the calculation a bit.
>>>>
>>>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>>
>>> So I think you're right it's currently unused; however, lets ask
>>> Paolo: Do we need to keep this parameter for flexiblity?
>>>
>>
>> Hey, Paolo
>>
>> Do you have some spare time to give some insight?
>
>I think it's cleaner to leave the start argument in place. However,
>I'll note that in migration_bitmap_sync_range the length argument is
>always block->used_length so that's also unnecessary (you already have
>block).
>
That's reasonable.
>Paolo
>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-07-18 1:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:44 [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0 Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:15 ` Dr. David Alan Gilbert
2019-05-14 14:27 ` Dr. David Alan Gilbert
2019-05-15 6:41 ` Wei Yang
2019-05-15 8:04 ` Dr. David Alan Gilbert
2019-05-15 8:54 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap " Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:21 ` Dr. David Alan Gilbert
2019-05-31 0:54 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
2019-07-17 1:13 ` Wei Yang
2019-07-17 9:16 ` Paolo Bonzini
2019-07-18 1:07 ` Wei Yang [this message]
2019-04-30 3:44 ` [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-07-17 9:17 ` Paolo Bonzini
2019-07-18 1:11 ` Wei Yang
2019-05-01 22:53 ` [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c no-reply
2019-05-01 22:53 ` no-reply
2019-05-02 0:10 ` Wei Yang
2019-05-02 0:10 ` Wei Yang
2019-05-02 4:24 ` no-reply
2019-05-02 4:24 ` no-reply
2019-05-02 5:32 ` Wei Yang
2019-05-02 5:32 ` Wei Yang
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 22:34 ` Wei Yang
2019-05-02 22:34 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718010751.GA15881@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.