From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "Laszlo Ersek" <lersek@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"John Snow" <jsnow@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH-for-4.1 v7 0/1] hw/block/pflash_cfi01: Add DeviceReset() handler
Date: Thu, 18 Jul 2019 12:48:36 +0200 [thread overview]
Message-ID: <20190718104837.13905-1-philmd@redhat.com> (raw)
The pflash device lacks a reset() function.
When a machine is resetted, the flash might be in an
inconsistent state, leading to unexpected behavior.
Resolve this issue by adding a DeviceReset() handler.
v7: Surgical bugfix, do not attempt to improve the model in any
way, thus ignoring all comments from previous versions.
No migration impact.
Usual regression testing is welcomed, but probably pointless,
except done in the way describes in the following bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=1678713
https://bugzilla.redhat.com/show_bug.cgi?id=1704584
That is, resetting the machine when it is accessing the flash
device. IMO testing after the guest is done accessing the flash
device is totally pointless.
If no objection on this series after a day, I plan to send a
pull request to get this bugfix into 4.1.0-rc2.
Regards,
Phil.
Philippe Mathieu-Daudé (1):
hw/block/pflash_cfi01: Add missing DeviceReset() handler
hw/block/pflash_cfi01.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
--
2.20.1
next reply other threads:[~2019-07-18 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 10:48 Philippe Mathieu-Daudé [this message]
2019-07-18 10:48 ` [Qemu-devel] [PATCH-for-4.1 v7 1/1] hw/block/pflash_cfi01: Add missing DeviceReset() handler Philippe Mathieu-Daudé
2019-07-18 15:03 ` Laszlo Ersek
2019-07-18 18:38 ` Laszlo Ersek
2019-07-18 19:35 ` Philippe Mathieu-Daudé
2019-07-19 16:19 ` Philippe Mathieu-Daudé
2019-07-22 16:51 ` Laszlo Ersek
2019-07-22 16:55 ` Philippe Mathieu-Daudé
2019-07-22 17:12 ` Peter Maydell
2019-07-23 7:38 ` Laszlo Ersek
2019-07-22 16:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718104837.13905-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.