From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2AAC76191 for ; Thu, 18 Jul 2019 13:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4D0320880 for ; Thu, 18 Jul 2019 13:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727687AbfGRNgk (ORCPT ); Thu, 18 Jul 2019 09:36:40 -0400 Received: from foss.arm.com ([217.140.110.172]:58504 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726715AbfGRNgk (ORCPT ); Thu, 18 Jul 2019 09:36:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C67D344; Thu, 18 Jul 2019 06:36:39 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 754163F71F; Thu, 18 Jul 2019 06:36:36 -0700 (PDT) Date: Thu, 18 Jul 2019 14:36:30 +0100 From: Lorenzo Pieralisi To: Ulf Hansson Cc: Sudeep Holla , Mark Rutland , Linux ARM , "Rafael J . Wysocki" , Daniel Lezcano , "Raju P . L . S . S . S . N" , Amit Kucheria , Bjorn Andersson , Stephen Boyd , Niklas Cassel , Tony Lindgren , Kevin Hilman , Lina Iyer , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , Souvik Chakravarty , Linux PM , linux-arm-msm , Linux Kernel Mailing List Subject: Re: [PATCH 10/18] drivers: firmware: psci: Add hierarchical domain idle states converter Message-ID: <20190718133630.GB27222@e121166-lin.cambridge.arm.com> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-11-ulf.hansson@linaro.org> <20190709153138.GA22871@e121166-lin.cambridge.arm.com> <20190716145121.GA32490@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jul 18, 2019 at 01:43:44PM +0200, Ulf Hansson wrote: [...] > > > Anyway, as a suggestion to address your concern, how about this: > > > > > > 1. Move some things out to a PSCI cpuidle driver. We need to decide > > > more exactly on what to move and find the right level for the > > > interfaces. > > > > I will do it and post patches asap. > > Okay, so I will wait for you to converting the cpuidle-arm driver into > a cpuidle-psci driver (and all the changes that comes with it) and > then base my re-base my series on top. > > Then, would you mind sharing (even in an early phase) a > branch/git-tree so I can start re-basing my series on top? Sure, I should be able to post at -rc1 and will publish a branch here [1]. > > > 2. Don't attach the CPU to the PM domain topology in case the PSCI PC > > > mode is used. I think this makes it easier, at least as a first step, > > > to understand when runtime PM needs to be used/enabled. > > > > In the PSCI CPUidle driver we can have two distinct struct > > cpuidle_state->enter functions for PC and OSI, no overhead > > for PC, runtime PM for OSI, decoupling done. > > Good idea! > > > > > We can choose one or the other depending on whether: > > > > OSI iff: > > - OSI is available > > - hierarchical idle states are present in DT > > > > otherwise PC. > > > > That's what this patch does but we will do it in a unified file. > > Sure, it makes sense. > > > > > > 3. Would it help if I volunteer to help you guys as a maintainer for > > > PSCI. At least for the part of the new code that becomes introduced? > > > > We will do as described above if that makes sense. > > Yep, I am okay with your suggestions, assuming I have understood them correctly. > > BTW, have you considered to host a git tree for PSCI so we can have > changes pre-integrated and tested in Stephen Rothwell's linux-next > tree? I will ask Stephen to pull when needed a branch in the tree below[1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198C8C76191 for ; Thu, 18 Jul 2019 13:37:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E262221019 for ; Thu, 18 Jul 2019 13:37:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p2XuPcar" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E262221019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xaGVt+9RlTTiAopCDENkjE0Yvx8SQ0jMZaAHzXqRdGM=; b=p2XuPcar7h4T9J nhSWiarhNe5967ivNwovjdx0Tzrisu0vJIvSQs0RDVbUsQOLN/8TFoKHNDvExa6KQFOMoreT98axd g/wZ2mn9k5EhBuP491Ckaud4nCoFDGf8cBcJkaGJu/b8sZe+n1cSdcW/7t8sRVZ99wbNniuQn1OBp fR4dPAlek8dVVktXHie/R7ynJxZxX4EQW1XzkECBjSE4GvOJpOMzuGUVuzNHKq/vyXg6EAd1ZeR2G 8/GZLnolEXZbQiRxJWgu/v0eL9VQYmAWTN70S9DOhv7KQYhZgwlS0Q4huTNDETze8WVuS0wxn2m2o L1VI9igRcCQKIh1dmXwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho6ad-0000ea-7X; Thu, 18 Jul 2019 13:36:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho6aN-0000cw-VL for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 13:36:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C67D344; Thu, 18 Jul 2019 06:36:39 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 754163F71F; Thu, 18 Jul 2019 06:36:36 -0700 (PDT) Date: Thu, 18 Jul 2019 14:36:30 +0100 From: Lorenzo Pieralisi To: Ulf Hansson Subject: Re: [PATCH 10/18] drivers: firmware: psci: Add hierarchical domain idle states converter Message-ID: <20190718133630.GB27222@e121166-lin.cambridge.arm.com> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-11-ulf.hansson@linaro.org> <20190709153138.GA22871@e121166-lin.cambridge.arm.com> <20190716145121.GA32490@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_063643_202190_E2C83D63 X-CRM114-Status: GOOD ( 23.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Geert Uytterhoeven , Kevin Hilman , Stephen Boyd , Viresh Kumar , Linux PM , Daniel Lezcano , "Rafael J . Wysocki" , Linux Kernel Mailing List , Amit Kucheria , Bjorn Andersson , Tony Lindgren , linux-arm-msm , Lina Iyer , Sudeep Holla , Niklas Cassel , Souvik Chakravarty , "Raju P . L . S . S . S . N" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 01:43:44PM +0200, Ulf Hansson wrote: [...] > > > Anyway, as a suggestion to address your concern, how about this: > > > > > > 1. Move some things out to a PSCI cpuidle driver. We need to decide > > > more exactly on what to move and find the right level for the > > > interfaces. > > > > I will do it and post patches asap. > > Okay, so I will wait for you to converting the cpuidle-arm driver into > a cpuidle-psci driver (and all the changes that comes with it) and > then base my re-base my series on top. > > Then, would you mind sharing (even in an early phase) a > branch/git-tree so I can start re-basing my series on top? Sure, I should be able to post at -rc1 and will publish a branch here [1]. > > > 2. Don't attach the CPU to the PM domain topology in case the PSCI PC > > > mode is used. I think this makes it easier, at least as a first step, > > > to understand when runtime PM needs to be used/enabled. > > > > In the PSCI CPUidle driver we can have two distinct struct > > cpuidle_state->enter functions for PC and OSI, no overhead > > for PC, runtime PM for OSI, decoupling done. > > Good idea! > > > > > We can choose one or the other depending on whether: > > > > OSI iff: > > - OSI is available > > - hierarchical idle states are present in DT > > > > otherwise PC. > > > > That's what this patch does but we will do it in a unified file. > > Sure, it makes sense. > > > > > > 3. Would it help if I volunteer to help you guys as a maintainer for > > > PSCI. At least for the part of the new code that becomes introduced? > > > > We will do as described above if that makes sense. > > Yep, I am okay with your suggestions, assuming I have understood them correctly. > > BTW, have you considered to host a git tree for PSCI so we can have > changes pre-integrated and tested in Stephen Rothwell's linux-next > tree? I will ask Stephen to pull when needed a branch in the tree below[1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel