From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DATE_IN_FUTURE_06_12, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFF9C76191 for ; Thu, 18 Jul 2019 07:23:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 83D832173B for ; Thu, 18 Jul 2019 07:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83D832173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2761C276C; Thu, 18 Jul 2019 09:23:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B71A31D9E for ; Thu, 18 Jul 2019 09:23:34 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 00:23:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="161995448" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.185]) by orsmga008.jf.intel.com with ESMTP; 18 Jul 2019 00:23:32 -0700 Date: Thu, 18 Jul 2019 22:05:06 +0800 From: Ye Xiaolong To: "Zhu, TaoX" Cc: "Xing, Beilei" , "Zhang, Qi Z" , "dev@dpdk.org" Message-ID: <20190718140506.GC88943@intel.com> References: <20190718145351.13987-1-taox.zhu@intel.com> <20190718130907.GB88943@intel.com> <60652C6914E08D41B9AA1580751B3CA9BC5D42@SHSMSX106.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60652C6914E08D41B9AA1580751B3CA9BC5D42@SHSMSX106.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix request queue fail in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/18, Zhu, TaoX wrote: >Hi, Xiaolong > I'm sorry, this is my first time submitting a patch. > Attachment picture is my patch content and I try to generate fixes with git fixline. But I modified the code location to 'Not Committed Yet'. Should I use nearby id cebe3d7b3d? > Nope, the commit in the fixline should be the one that introduced the issue this patch tries to solve. Thanks, Xiaolong >Thanks, >Zhutao > > > >-----Original Message----- >From: Ye, Xiaolong >Sent: Thursday, July 18, 2019 9:09 PM >To: Zhu, TaoX >Cc: Xing, Beilei ; Zhang, Qi Z ; dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix request queue fail in VF > >On 07/18, taox.zhu@intel.com wrote: >>From: Zhu Tao >> >>When the VF configuration is larger than the number of queues reserved >>by PF, VF sends the request queue command through admin queue. When PF >>received this command, it may reset the VF and send a notification >>before resetting. If this notification is read by the timed task alarm, >>Task request queue will lost notification. This patch Mark vf_reset, >>pend_msg flag just as task request queue has received notification in >>task alarm. > >Please add fixes tag and cc stable. > > >Thanks, >Xiaolong > >> >>Signed-off-by: Zhu Tao >>--- >> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >>diff --git a/drivers/net/i40e/i40e_ethdev_vf.c >>b/drivers/net/i40e/i40e_ethdev_vf.c >>index 5be32b069..86dfda1c0 100644 >>--- a/drivers/net/i40e/i40e_ethdev_vf.c >>+++ b/drivers/net/i40e/i40e_ethdev_vf.c >>@@ -1332,6 +1332,10 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg, >> PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event"); >> _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, >> NULL); >>+ if (vf->vf_reset == false) { >>+ vf->vf_reset = true; >>+ vf->pend_msg |= PFMSG_RESET_IMPENDING; >>+ } >> break; >> case VIRTCHNL_EVENT_LINK_CHANGE: >> PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event"); >>-- >>2.17.1 >>