From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE81C7618F for ; Thu, 18 Jul 2019 18:53:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0627D2082F for ; Thu, 18 Jul 2019 18:53:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FzwOGtjl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="X1xbwNx/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0627D2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jBrBHXMUcSr7Rc0slN1ewqnR4ttjx3t/xVv6OR24UwI=; b=FzwOGtjl95U4bTVttPtDJ4aX4 2OBdIv0mvqrlgnYGQFnravgjb21TunRCdUlrCrDAWAiVQB8LuMI82hdF9D3p48HWgb2x0ErZnYOKy e9ODNM1Tp8PiJl8OalT2n6Pkt4KHjDeD/XEvL31Xj9mEtaeqK0vpDsqidHiPJI/QsvcbOcycpWx9S M7y1qq+87ByKeplV5Qdn5jJIejZeKjhV8KnY2+XfYqNt34Tjlbri9Cc/quXQMoMlDpc8h/fJMCAdD ugRkwVDC0P2gAmdcVOZ7h6RpqWRjjrurpId9mT6ErGdep3bUKRMAPUmuFGtzjt29hI57rhvre+V+Q L4VrGHthA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoBWW-0006Wn-2q; Thu, 18 Jul 2019 18:53:00 +0000 Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoBWT-0006WB-4I; Thu, 18 Jul 2019 18:52:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v4vCvGRGvUHn6CC4va2L0tFZHJtNopsWhOoDhb3bUuc=; b=X1xbwNx/BKxxT35ppmYKyYzmb NmvAYVpOXJyGz0LSRB0UtyjQM8dtFuAeUuM0s9z4BOH3KlJWcdnR7WedF5lxLoi2xh7Z880ez0ofg FsZdxphCtQZfbKYP4WrUHbFCebdMoSxd/i+bcK4aklJkZQwKVKbCaKlgFlk9c/iz40vtg=; Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hoBWB-0005od-Vq; Thu, 18 Jul 2019 18:52:40 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 20FE22741738; Thu, 18 Jul 2019 19:52:39 +0100 (BST) Date: Thu, 18 Jul 2019 19:52:38 +0100 From: Mark Brown To: Stefan Wahren Subject: Re: [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support Message-ID: <20190718185238.GH5761@sirena.org.uk> References: <1563398164-2679-1-git-send-email-wahrenst@gmx.net> <1563398164-2679-2-git-send-email-wahrenst@gmx.net> <20190718124205.GC5761@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Oh, wow! Look at the moon! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_115257_182511_555AB1CA X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Florian Fainelli , Scott Branden , Stephen Boyd , Ray Jui , Linus Walleij , Adrian Hunter , Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Martin Sperl , Michael Turquette , Nicolas Saenz Julienne , linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7804270549648038227==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7804270549648038227== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KR/qxknboQ7+Tpez" Content-Disposition: inline --KR/qxknboQ7+Tpez Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 18, 2019 at 07:53:43PM +0200, Stefan Wahren wrote: > Am 18.07.19 um 14:42 schrieb Mark Brown: > > On Wed, Jul 17, 2019 at 11:16:01PM +0200, Stefan Wahren wrote: > >> + /* check if we got interrupt enabled */ > >> + if (!(bcm2835_rd(bs, BCM2835_SPI_CS) & BCM2835_SPI_CS_INTR)) > >> + return IRQ_NONE; > > Is that checking if the interrupt is enabled or if it is asserted? > the BCM2835 doesn't provide a SPI register, which shows that the > interrupt has been asserted. > So i think, Martin tried to adapt the workaround from spi-bcm2835-aux > which has the same problem. OK, I don't know what that workaround was or exactly what this is checking but if it's just checking if the interrupt was enabled then there's going to be cases where this gets called while interrupts are enabled but due to another device asserting the interrupt. If the driver can cope with that and this is just an optimization then fine but if it's relying on this there's an issue. --KR/qxknboQ7+Tpez Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0wv/YACgkQJNaLcl1U h9D8ugf/Yqa+EMN+dWqnAv+bqeF9ydPnXTxlwHr0IBS4W6gCC6WlCL4eq0oQ/h2S oOWRu8bSy6KZqh+MuL0dmI6CywFhc8498IDv8GnUsgJc1C7yzMn6paJu2yShluzk bY39YeACqjyrRmGq5gPynzzvvk46YWSapkdg0yjSUb+u6oO4PHTsz5H2xpCzU56S rY2fMljx7AUhfKWe0olLV/uwHeXIut40kh1WKrOw/e3Hij3ltXeHryQD1Rg96j4+ jKV9t+MqtL5rG22Qz5sGwGAeq1gmJhZrHmmV9fgGZaIItFmxxf7MuMI7lkuoyZx3 zKE4Dj7fj6mKKpb5jJxG0s6vDS0Q1w== =dhAE -----END PGP SIGNATURE----- --KR/qxknboQ7+Tpez-- --===============7804270549648038227== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7804270549648038227==--