From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBC1C76195 for ; Fri, 19 Jul 2019 18:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9511821849 for ; Fri, 19 Jul 2019 18:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LtGE7qyz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732140AbfGSSqO (ORCPT ); Fri, 19 Jul 2019 14:46:14 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42278 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727618AbfGSSqO (ORCPT ); Fri, 19 Jul 2019 14:46:14 -0400 Received: by mail-pf1-f196.google.com with SMTP id q10so14541847pff.9 for ; Fri, 19 Jul 2019 11:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=LgCwfeb0qUeGvteEDqnpqo5FEOvlxmkPiJSvQEyBpA4=; b=LtGE7qyzqvqQis+0QWaAc6EydmIRM2jL00m9b+Go8yQAU7Lt9OzQe2emBMW8bIJ5D6 YHIGHKqaOCDJ36TRTari/GqdWkzG0KYvhYZ6PntA3qeQ5EIVPqsACyM1fcQPL8TcrUCR Y+r7tmV91mI67L1Is2NyEazqRwqS2xr+0GGD8+3PC/OzLtth1DC9mwH4R3oiGKj2k8HP 4AMyHclQbhR2qTQYqNVAYYBJu+aiOq+rUzmMuGOSESv+55R94I6VbBbZqbkXW4CuaeVR b5pIhP6P58n83e/wWatxPwFjXc2PiFBBYFsPBccsetuOybLQETZMdtYJPwOXAoBIYXky KxeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=LgCwfeb0qUeGvteEDqnpqo5FEOvlxmkPiJSvQEyBpA4=; b=cMrklkrA5+FRYFR/+LMu6JGlimW8Gq/wlkxGqLFaz1Jy3qBTLaSSlHz/lAPTV6vDDI oH3ou99qfi0LMZbn9kL1AyaFjASHe2Hm9Q2EHRFGrdiZ6CVMzbOKrNFyX0RRRpF7gp22 Pap8chabzuSyK4oaOw7HEZ8gVNx9+SWQsBgsEuGpLEqyo0l6aTU1vno+FFZ46GVOAZOO AATv9L4OUymFU9DBJ+x5+UcLi5eBMccO8MWCTKG3O3tDnQazxOdiP7S1Y9Kybbr7dJeJ 72/NAbe9/fB3C87slGxHMcZXUjwSscEvel9u3oaRtdHHxEQWS1iWpw7cJfhCj4LKM6JB 6q0w== X-Gm-Message-State: APjAAAW2N/dshWOSC1IPJfFK0TFA9R8fGtsKN7PP+PRGZBki+wRnuOa6 QIvNaibRwHl30jF7dsjKmJU= X-Google-Smtp-Source: APXvYqxkdYNpO/9sbTcC3Gwdlyw8Fp+lp6d3baaiN8Qy+GZcZufOZdcjl3SXt9qBB2rqD7nWprPrHQ== X-Received: by 2002:a63:188:: with SMTP id 130mr54815202pgb.231.1563561973341; Fri, 19 Jul 2019 11:46:13 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.86.126]) by smtp.gmail.com with ESMTPSA id g18sm55976033pgm.9.2019.07.19.11.46.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 11:46:12 -0700 (PDT) Date: Sat, 20 Jul 2019 00:16:06 +0530 From: Hariprasad Kelam To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Alexandre Torgue , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] rqchip/stm32: Remove unneeded call to kfree Message-ID: <20190719184606.GA4701@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Memory allocated by devm_ alloc will be freed upon device detachment. So we may not require free memory. Signed-off-by: Hariprasad Kelam --- drivers/irqchip/irq-stm32-exti.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index e00f2fa..46ec0af 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -779,8 +779,6 @@ static int __init stm32_exti_init(const struct stm32_exti_drv_data *drv_data, irq_domain_remove(domain); out_unmap: iounmap(host_data->base); - kfree(host_data->chips_data); - kfree(host_data); return ret; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2C3C7618F for ; Fri, 19 Jul 2019 18:46:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07A0221849 for ; Fri, 19 Jul 2019 18:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IFFTyQhF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LtGE7qyz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07A0221849 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=JKrVYEOkRr38X+qQHlfRjXGmrusXHxZXTFAgWORAnpY=; b=IFFTyQhFtoBkTb DNigOsC1Bom0vJUShgcwNsokn5dQsLV1nvrnIQ+/TBjsLnNlWRTQVN0TRb6ll2zUEVuE9LUWtBI+i 39TJeiuviSWyL2Y8ixKxKXFEPLnCLCWKWfKW2ATvsZka8dDEZAdWS6wMVOxZqlPe68nyCkEvItkx2 QjkS3z9m2cTobTaxdOvPtslFCK8ZpLIAEG6rtgFSIWI5f0fRw1Ubts7e2g7ed3ZaxEc8+QNNWZuDb FM/S+z3DkY/hctDBnLePL1C1WLBQdi7ZyXTe10YAdZguHz2grZnkHnfuOn+/qGxoYPeu1MIcGf2t5 ndFcPhq6RuD4D2aTSJ9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoXtc-0005It-3n; Fri, 19 Jul 2019 18:46:20 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoXtY-0005I1-TI for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2019 18:46:18 +0000 Received: by mail-pf1-x441.google.com with SMTP id i189so14551493pfg.10 for ; Fri, 19 Jul 2019 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=LgCwfeb0qUeGvteEDqnpqo5FEOvlxmkPiJSvQEyBpA4=; b=LtGE7qyzqvqQis+0QWaAc6EydmIRM2jL00m9b+Go8yQAU7Lt9OzQe2emBMW8bIJ5D6 YHIGHKqaOCDJ36TRTari/GqdWkzG0KYvhYZ6PntA3qeQ5EIVPqsACyM1fcQPL8TcrUCR Y+r7tmV91mI67L1Is2NyEazqRwqS2xr+0GGD8+3PC/OzLtth1DC9mwH4R3oiGKj2k8HP 4AMyHclQbhR2qTQYqNVAYYBJu+aiOq+rUzmMuGOSESv+55R94I6VbBbZqbkXW4CuaeVR b5pIhP6P58n83e/wWatxPwFjXc2PiFBBYFsPBccsetuOybLQETZMdtYJPwOXAoBIYXky KxeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=LgCwfeb0qUeGvteEDqnpqo5FEOvlxmkPiJSvQEyBpA4=; b=PRSwjdEfyURBoBF4GjKWs/WzRGw0hIB6knP7DUaZkUthNfvQ/j0OjyfRVY4SQVNK4T uAJCewHiZOpoq+v6/N5ITI/g91gybqp9hVONCHt8lz86Io3WgIwR56y/kkB7aswW3oPM VDhxAqcHf/xSFJO1SFiu8tdTUB9eOEl3/ySMSoSzf/f0Gs30dgt1Mvz7xOjKHj2/yyxB VggX5ZMRwZR5/AEEf8hYPYPYtHTnZ0p3CXN6LlojyDiksEWhJ59lmDWR++qKvYgjPaC+ C0Ip1kufQncl8crXKRgs0F7CZfkN8ZADSq0Ryy3uo7f8jNLsWf87H8aBGQUJRtl48vw4 MPSg== X-Gm-Message-State: APjAAAUbl61ye71Ov/IIgpJ/hIJj6zerUn9IaCX2d1Y+sdbV1ryx9mgZ hyaWkkfXWeR0vpZDfDoGjUA= X-Google-Smtp-Source: APXvYqxkdYNpO/9sbTcC3Gwdlyw8Fp+lp6d3baaiN8Qy+GZcZufOZdcjl3SXt9qBB2rqD7nWprPrHQ== X-Received: by 2002:a63:188:: with SMTP id 130mr54815202pgb.231.1563561973341; Fri, 19 Jul 2019 11:46:13 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.86.126]) by smtp.gmail.com with ESMTPSA id g18sm55976033pgm.9.2019.07.19.11.46.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 11:46:12 -0700 (PDT) Date: Sat, 20 Jul 2019 00:16:06 +0530 From: Hariprasad Kelam To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Alexandre Torgue , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] rqchip/stm32: Remove unneeded call to kfree Message-ID: <20190719184606.GA4701@hari-Inspiron-1545> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190719_114616_971538_6D48223E X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Memory allocated by devm_ alloc will be freed upon device detachment. So we may not require free memory. Signed-off-by: Hariprasad Kelam --- drivers/irqchip/irq-stm32-exti.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index e00f2fa..46ec0af 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -779,8 +779,6 @@ static int __init stm32_exti_init(const struct stm32_exti_drv_data *drv_data, irq_domain_remove(domain); out_unmap: iounmap(host_data->base); - kfree(host_data->chips_data); - kfree(host_data); return ret; } -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel