From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EF2C7618F for ; Fri, 19 Jul 2019 21:05:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0121D2184E for ; Fri, 19 Jul 2019 21:05:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E1RFVPs9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0121D2184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoa3u-0000bK-Dp for qemu-devel@archiver.kernel.org; Fri, 19 Jul 2019 17:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54953) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoa2u-0005GU-KX for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoa2l-0005Di-T3 for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:03:58 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:37903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hoa2d-000570-7p for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:03:49 -0400 Received: by mail-pg1-x541.google.com with SMTP id f5so6143443pgu.5 for ; Fri, 19 Jul 2019 14:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NUSM1qmbu6kHaDmLHqWVtWdOZoHscxZfBv6st8fQLVo=; b=E1RFVPs9zYEk8fml6OCh0EpMr5IVFaInRJ9uIH6agfw4gErIuOFQcubkxH8J3VAUiL b1zaB+bZZuJS+Zo1U0YjxWlg5AK6VfK5N3TdrRBItCdL46nYw3g5OjK8NQ0PBXJywEB2 NOnjz+5QVYuFxOsE9BsUW5sYfIEdxA2sxn9BAsd9MIem6IU+6uDLNwOfqjjGV3j6bYIe NtpIsjPsX7l5puqdh2PcwoaL42yOAvJxp72ke4maBie31yvPW6qNFaNN+zjfFLPrwbrB DnwASec56bnyTYs1CmcAdvavhAyepcFti0m8UCisRiiBo8TmX4ekZAuKM8QA744M1I7F DdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NUSM1qmbu6kHaDmLHqWVtWdOZoHscxZfBv6st8fQLVo=; b=tI98G1r3x14HbKZ90aFjMEHJ+N0Ht6pNtAkUUT46CmQVOhqAeXjB/pS3p0WsIYYQ0+ v8ZAoLg0ZMyZnFMtSe06PjeL1rNgrqDNgILtqvOVh60+8HDMChVMjTPUyRdIRXBcVuAd hSOOT3TtUh+rvlaSS64EiAXbclz8oCAk1+pZ2iQ3U0FvBCa49TweyFtmQCt2dKcrBV7k eFMzAxKkmyC+knUZD5B4+tzGYBLU9uapBxve3bAbuJ4F4Q7qzFmVD3UW21QRe7v9xTVD G1VqgtpBqbkIrZqN3qDoLaF1ryBKBFbCxa54qUfH61SEDtHYxBr6Uas9p9Xko+R7Ffni NvGw== X-Gm-Message-State: APjAAAXwQDbsAHPzYL2Pc6bWppW52wQ5l031YVxbmcXhcBmPMK/hmd7Y 3VmxPdnzx/Y3US/lWKRZsVApuRv7gdY= X-Google-Smtp-Source: APXvYqzjHhk482RJwTVnA4FsUxDJ+JWbzdUdwj8hk2ALZsakhakW4j0h3KU8U66zoYe9xzvTpFLxtg== X-Received: by 2002:a63:5945:: with SMTP id j5mr55943450pgm.452.1563570214508; Fri, 19 Jul 2019 14:03:34 -0700 (PDT) Received: from localhost.localdomain (97-126-117-207.tukw.qwest.net. [97.126.117.207]) by smtp.gmail.com with ESMTPSA id i6sm32724751pgi.40.2019.07.19.14.03.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 14:03:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 19 Jul 2019 14:03:07 -0700 Message-Id: <20190719210326.15466-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190719210326.15466-1-richard.henderson@linaro.org> References: <20190719210326.15466-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH for-4.2 05/24] target/arm: Install ASIDs for EL2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, beata.michalska@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The VMID is the ASID for the 2nd stage page lookup. Signed-off-by: Richard Henderson --- target/arm/helper.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 1ed7c06313..3a9f35bf4b 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -3452,17 +3452,23 @@ static void vmsa_ttbr_el1_write(CPUARMState *env, const ARMCPRegInfo *ri, static void vttbr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { - ARMCPU *cpu = env_archcpu(env); - CPUState *cs = CPU(cpu); + CPUState *cs = env_cpu(env); + int vmid; - /* Accesses to VTTBR may change the VMID so we must flush the TLB. */ - if (raw_read(env, ri) != value) { - tlb_flush_by_mmuidx(cs, - ARMMMUIdxBit_S12NSE1 | - ARMMMUIdxBit_S12NSE0 | - ARMMMUIdxBit_S2NS); - raw_write(env, ri, value); - } + raw_write(env, ri, value); + + /* + * TODO: with ARMv8.1-VMID16, aarch64 must examine VTCR.VS + * (re-evaluating with changes to VTCR) then use bits [63:48]. + */ + vmid = extract64(value, 48, 8); + + /* + * A change in VMID to the stage2 page table (S2NS) invalidates + * the combined stage 1&2 tlbs (S12NSE1 and S12NSE0). + */ + tlb_set_asid_for_mmuidx(cs, vmid, ARMMMUIdxBit_S2NS, + ARMMMUIdxBit_S12NSE1 | ARMMMUIdxBit_S12NSE0); } static const ARMCPRegInfo vmsa_pmsa_cp_reginfo[] = { -- 2.17.1