All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbabic at denx.de <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] IMX: serial: dm: Set DM_FLAG_PRE_RELOC in the IMX uart driver
Date: Sat, 20 Jul 2019 08:45:29 +0000 (UTC)	[thread overview]
Message-ID: <20190720084531.14728C21CB1@lists.denx.de> (raw)
In-Reply-To: <20190604134204.30266-1-lukma@denx.de>

> The DM_FLAG_PRE_RELOC shall be set unconditionally as this driver is going
> to be re-used in both early SPL and U-Boot proper's pre-reloc.
> For i.MX based devices it is crucial to have available the serial console
> before relocation (otherwise the board may hand).
> The device definition may be provided either via device tree description or
> with U_BOOT_DEVICE(mxc_serial) definition. In the latter case the device
> will not bind in U-Boot proper when DM_FLAG_PRE_RELOC is not set.
> The !CONFIG_IS_ENABLED(OF_CONTROL) #if check was set as a "workaround" for
> DM problem described in following commit 4687919684e0
> ("serial: Remove DM_FLAG_PRE_RELOC flag in various drivers").
> Let's look on this check more thoroughly - we add this flag if the board
> doesn't support OF_CONTROL. This is a bit strange as the serial_mxc.c can
> be used with CONFIG_DM_SERIAL but without corresponding device tree
> description (OF_CONTROL). In such case the aforementioned
> U_BOOT_DEVICE(mxc_serial) definition is used.
> Other boards/SoCs have this flag set unconditionally for serial driver.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2019-07-20  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 13:42 [U-Boot] [PATCH] IMX: serial: dm: Set DM_FLAG_PRE_RELOC in the IMX uart driver Lukasz Majewski
2019-07-20  8:45 ` sbabic at denx.de [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190720084531.14728C21CB1@lists.denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.