From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Improve SPDX license checking
Date: Sat, 20 Jul 2019 12:22:03 +1000 [thread overview]
Message-ID: <20190720122203.7baf841a@canb.auug.org.au> (raw)
In-Reply-To: <f08eb62458407a145cfedf959d1091af151cd665.1563575364.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
Hi Joe,
On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches <joe@perches.com> wrote:
>
> Use perl's m@<match>@ match and not /<match>/ comparisons to avoid
> an error using c90's // comment style.
>
> Miscellanea:
>
> o Use normal tab indentation and alignment
>
> Link: http://lkml.kernel.org/r/5e4a8fa7901148fbcd77ab391e6dd0e6bf95777f.camel@perches.com
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Again, don't include other's (non author's) SOB lines.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-20 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 22:31 [PATCH 1/2] checkpatch: Don't interpret stack dumps as commit IDs Joe Perches
2019-07-19 22:31 ` [PATCH 2/2] checkpatch: Improve SPDX license checking Joe Perches
2019-07-20 2:22 ` Stephen Rothwell [this message]
2019-07-20 3:09 ` Joe Perches
2019-07-20 3:17 ` Stephen Rothwell
2019-07-20 2:20 ` [PATCH 1/2] checkpatch: Don't interpret stack dumps as commit IDs Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720122203.7baf841a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.