Hi Joe, On Fri, 19 Jul 2019 20:09:19 -0700 Joe Perches wrote: > > On Sat, 2019-07-20 at 12:22 +1000, Stephen Rothwell wrote: > > Hi Joe, > > > > On Fri, 19 Jul 2019 15:31:33 -0700 Joe Perches wrote: > > > Use perl's m@@ match and not // comparisons to avoid > > > an error using c90's // comment style. > > > > > > Miscellanea: > > > > > > o Use normal tab indentation and alignment > > > > > > Link: http://lkml.kernel.org/r/5e4a8fa7901148fbcd77ab391e6dd0e6bf95777f.camel@perches.com > > > > > > Signed-off-by: Joe Perches > > > Signed-off-by: Andrew Morton > > > Signed-off-by: Stephen Rothwell > > > > Again, don't include other's (non author's) SOB lines. > > Nope. > You _already_ signed-off this patch. > I'm simply reproducing it. My SOB line is *only* there because I am publishing that patch in linux-next. When Andrew sends that patch to Linus, my SOB should not be there (since I will no longer be in the handling path). My SOB does not say anything about the correctness or otherwise of the patch. Equally, if you sent that patch to Linus, Andrew's SOB should (probably) not be there. -- Cheers, Stephen Rothwell