From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F8EC76195 for ; Sun, 21 Jul 2019 19:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D90322083B for ; Sun, 21 Jul 2019 19:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M2T/jKit" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727252AbfGUTLq (ORCPT ); Sun, 21 Jul 2019 15:11:46 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43840 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727209AbfGUTLq (ORCPT ); Sun, 21 Jul 2019 15:11:46 -0400 Received: by mail-pg1-f196.google.com with SMTP id f25so16553234pgv.10 for ; Sun, 21 Jul 2019 12:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mmeWQsmDiPaK9d82z6VLfilyAyZg9OaXDMwYxakvAF4=; b=M2T/jKitt/ndj61hrkrzKLpQVRLZCq5yD+LHcZuZd/cHePE+rJBRBABvEx0q5PUQa8 MTj0a/Gj5PvPl+yccsBxzayr6uHV6cTmshksC35R9/mPRnr5ASTlaSTpNWOQFtm24pkL mIXgtGMCNFmdMRVMBgJZlSHN9Hv1NKUX5YLNSjRHPZriU9dvLwB8wzJLzHo8mluATQJm 1obxsTTAu3J8mMMFx7Iww7xA6HScxVxFNDw9KY1xNC07QtSS/TJT8ubWGHcgM+aFbJJM wKLLGIiBS63wD10eXycVG1jfFT5sw8HqvTtOSRLmWfQ+l+dBTYpcryy8Z80yDBLYCNJz KrcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mmeWQsmDiPaK9d82z6VLfilyAyZg9OaXDMwYxakvAF4=; b=KXuYUjpxl4oTiCa/1/+vAyIrIcxVi/7nFSR5UrpvYE4wdc/sUxQ7weKjA2/HLecBio RSzvRbrbONz9TJk3kJl4NFfrJ4u/9vgGDLuymNUJbVCPcl17S5eHmP3E7GnvX8QzfSmt DUd9tevdXhHhFSjYR9wUq2/Da6bJDEjVCcamjqGUJkkjt9ROkVhK/4TZ6C8vkGRbL/7h oVuDL9A6OAi0h1WNZ4T1k35MRDw6WcbVonTnfbfITkNTLIUqsvm+h9XOtto7p8mCgEf8 /auUMUrobTd+TK0Am/Qdj886CI9PdJr17fWzF0s/dKQk1Ed+pZJy4PQe2l6+ho+2mg4X pTxQ== X-Gm-Message-State: APjAAAUDxVEju6OXXnbSnMCFfBTKzyn53/Dim6BGidErud5RfQUUi2Ry 0EUJlRHGHtthbET9YG7BMwVDAw== X-Google-Smtp-Source: APXvYqym+3nEqETS5wgsiUH/zTRbb9cNoEiTS+4Gh807QNShl0JCzM7CgRP8w5qWgHfscQ4yIxc+dw== X-Received: by 2002:a17:90a:8688:: with SMTP id p8mr73835132pjn.57.1563736305446; Sun, 21 Jul 2019 12:11:45 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id c69sm45113398pje.6.2019.07.21.12.11.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 21 Jul 2019 12:11:44 -0700 (PDT) Date: Sun, 21 Jul 2019 12:13:05 -0700 From: Bjorn Andersson To: David Dai Cc: georgi.djakov@linaro.org, robh+dt@kernel.org, evgreen@google.com, ilina@codeaurora.org, seansw@qti.qualcomm.com, elder@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes Message-ID: <20190721191305.GI7234@tuxbook-pro> References: <1563568344-1274-1-git-send-email-daidavid1@codeaurora.org> <1563568344-1274-3-git-send-email-daidavid1@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563568344-1274-3-git-send-email-daidavid1@codeaurora.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 19 Jul 13:32 PDT 2019, David Dai wrote: > Add the DT nodes for each of the Network-On-Chip interconnect > buses found on SDM845 based platform and redefine the rsc_hlos > child node as a bcm-voter device to better represent the hardware. > > Signed-off-by: David Dai > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 58 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index e7d78bc..204222e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -610,6 +610,62 @@ > #power-domain-cells = <1>; > }; > > + aggre1_noc: interconnect@16e0000 { > + compatible = "qcom,sdm845-aggre1_noc"; > + reg = <0 0x16e0000 0 0xd080>; Please pad the address to 8 digits and keep nodes sorted by address. > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; > + > + aggre2_noc: interconnect@1700000 { > + compatible = "qcom,sdm845-aggre2_noc"; > + reg = <0 0x1700000 0 0x3b100>; > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; > + > + config_noc: interconnect@1500000 { > + compatible = "qcom,sdm845-config_noc"; > + reg = <0 0x1500000 0 0x5080>; > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; [..] > qfprom@784000 { > compatible = "qcom,qfprom"; > reg = <0 0x00784000 0 0x8ff>; > @@ -2801,9 +2857,8 @@ > }; > }; > > - rsc_hlos: interconnect { > - compatible = "qcom,sdm845-rsc-hlos"; > - #interconnect-cells = <1>; > + apps_bcm_voter: bcm_voter { No '_' in node names, so bcm-voter. Apart from this nits this looks good. Regards, Bjorn > + compatible = "qcom,sdm845-bcm-voter"; > }; > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >