All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minwoo Im <minwoo.im@samsung.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Minwoo Im <minwoo.im.dev@gmail.com>,
	Matias Bjorling <mb@lightnvm.io>,
	"javier@javigon.com" <javier@javigon.com>,
	"birkelund@gmail.com" <birkelund@gmail.com>
Subject: Re: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
Date: Mon, 22 Jul 2019 13:31:01 +0900	[thread overview]
Message-ID: <20190722043101epcms2p2645d83b2c4aca7fc446f8d9109342327@epcms2p2> (raw)
In-Reply-To: <BYAPR04MB5749126EF9E68D94125BACB486CA0@BYAPR04MB5749.namprd04.prod.outlook.com>

> > @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
> >   	int ret = -EINVAL;
> >
> >   	if (dev->ops->identity(dev)) {
> > -		pr_err("nvm: device could not be identified\n");
> > +		pr_err("device could not be identified\n");
> >   		goto err;
> >   	}
> >
> > -	pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
> > +	pr_debug("ver:%u.%u nvm_vendor:%x\n",
> >   				geo->major_ver_id, geo->minor_ver_id,
> >   				geo->vmnt);
> The above last 2 lines can be squashed and pr_debug call can be made in
> 2 lines since you have removed the "nvm:" which shortens the first line.

Yeah Okay.  Will prepare V2 with this and also s/previx/prefix in the
title.

Thanks for the review.

Minwoo Im

  parent reply	other threads:[~2019-07-22  4:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20  8:30 [PATCH] lightnvm: introduce pr_fmt for the previx nvm Minwoo Im
2019-07-20 21:27 ` Chaitanya Kulkarni
     [not found] ` <CGME20190720212747epcas1p4d3e17fefd1cbd2007a1a1a452dde9c55@epcms2p2>
2019-07-22  4:31   ` Minwoo Im [this message]
2019-07-23  5:47     ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722043101epcms2p2645d83b2c4aca7fc446f8d9109342327@epcms2p2 \
    --to=minwoo.im@samsung.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=birkelund@gmail.com \
    --cc=javier@javigon.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    --cc=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.