* [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-22 7:11 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-22 7:11 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Chunyan Zhang, Lvqiang Huang
From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
- .word 0xe92d0000 >> 10 @ stmfd sp!, {}
+ .word 0xe92d0000 >> 11 @ stmfd sp!, {}
then the shift need to change to 11.
Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
---
arch/arm/lib/backtrace.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
index 7d7952e..926851b 100644
--- a/arch/arm/lib/backtrace.S
+++ b/arch/arm/lib/backtrace.S
@@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
- teq r3, r2, lsr #10 @ instruction
+ teq r3, r2, lsr #11 @ instruction
subne r0, sv_pc, #4 @ allow for mov
subeq r0, sv_pc, #8 @ allow for mov + stmia
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-22 7:11 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-22 7:11 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Chunyan Zhang, Lvqiang Huang
From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
- .word 0xe92d0000 >> 10 @ stmfd sp!, {}
+ .word 0xe92d0000 >> 11 @ stmfd sp!, {}
then the shift need to change to 11.
Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
---
arch/arm/lib/backtrace.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
index 7d7952e..926851b 100644
--- a/arch/arm/lib/backtrace.S
+++ b/arch/arm/lib/backtrace.S
@@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
- teq r3, r2, lsr #10 @ instruction
+ teq r3, r2, lsr #11 @ instruction
subne r0, sv_pc, #4 @ allow for mov
subeq r0, sv_pc, #8 @ allow for mov + stmia
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: check stmfd instruction using right shift
2019-07-22 7:11 ` Chunyan Zhang
@ 2019-07-22 7:14 ` Chunyan Zhang
-1 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-22 7:14 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Chunyan Zhang, Lvqiang Huang
From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
- .word 0xe92d0000 >> 10 @ stmfd sp!, {}
+ .word 0xe92d0000 >> 11 @ stmfd sp!, {}
then the shift need to change to 11.
Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
---
arch/arm/lib/backtrace.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
index 7d7952e..926851b 100644
--- a/arch/arm/lib/backtrace.S
+++ b/arch/arm/lib/backtrace.S
@@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
- teq r3, r2, lsr #10 @ instruction
+ teq r3, r2, lsr #11 @ instruction
subne r0, sv_pc, #4 @ allow for mov
subeq r0, sv_pc, #8 @ allow for mov + stmia
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-22 7:14 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-22 7:14 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel; +Cc: Chunyan Zhang, Lvqiang Huang
From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
- .word 0xe92d0000 >> 10 @ stmfd sp!, {}
+ .word 0xe92d0000 >> 11 @ stmfd sp!, {}
then the shift need to change to 11.
Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
---
arch/arm/lib/backtrace.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
index 7d7952e..926851b 100644
--- a/arch/arm/lib/backtrace.S
+++ b/arch/arm/lib/backtrace.S
@@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
- teq r3, r2, lsr #10 @ instruction
+ teq r3, r2, lsr #11 @ instruction
subne r0, sv_pc, #4 @ allow for mov
subeq r0, sv_pc, #8 @ allow for mov + stmia
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
2019-07-22 7:14 ` Chunyan Zhang
@ 2019-07-30 7:18 ` Chunyan Zhang
-1 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-30 7:18 UTC (permalink / raw)
To: Russell King, Linux ARM, Linux Kernel Mailing List; +Cc: Lvqiang Huang
Gentle ping
probably this patch was missed or entered into spam?
On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
>
> In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> then the shift need to change to 11.
>
> Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> ---
> arch/arm/lib/backtrace.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> index 7d7952e..926851b 100644
> --- a/arch/arm/lib/backtrace.S
> +++ b/arch/arm/lib/backtrace.S
> @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
>
> 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> - teq r3, r2, lsr #10 @ instruction
> + teq r3, r2, lsr #11 @ instruction
> subne r0, sv_pc, #4 @ allow for mov
> subeq r0, sv_pc, #8 @ allow for mov + stmia
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-30 7:18 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-30 7:18 UTC (permalink / raw)
To: Russell King, Linux ARM, Linux Kernel Mailing List; +Cc: Lvqiang Huang
Gentle ping
probably this patch was missed or entered into spam?
On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
>
> In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> then the shift need to change to 11.
>
> Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> ---
> arch/arm/lib/backtrace.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> index 7d7952e..926851b 100644
> --- a/arch/arm/lib/backtrace.S
> +++ b/arch/arm/lib/backtrace.S
> @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
>
> 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> - teq r3, r2, lsr #10 @ instruction
> + teq r3, r2, lsr #11 @ instruction
> subne r0, sv_pc, #4 @ allow for mov
> subeq r0, sv_pc, #8 @ allow for mov + stmia
>
> --
> 1.7.9.5
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
2019-07-30 7:18 ` Chunyan Zhang
@ 2019-07-30 11:02 ` Russell King - ARM Linux admin
-1 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux admin @ 2019-07-30 11:02 UTC (permalink / raw)
To: Chunyan Zhang; +Cc: Linux ARM, Linux Kernel Mailing List, Lvqiang Huang
On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote:
> Gentle ping
>
> probably this patch was missed or entered into spam?
Please submit it to the patch system, thanks.
>
> On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> >
> > From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> >
> > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> > - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> > + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> > then the shift need to change to 11.
> >
> > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> > Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> > ---
> > arch/arm/lib/backtrace.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> > index 7d7952e..926851b 100644
> > --- a/arch/arm/lib/backtrace.S
> > +++ b/arch/arm/lib/backtrace.S
> > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
> >
> > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> > - teq r3, r2, lsr #10 @ instruction
> > + teq r3, r2, lsr #11 @ instruction
> > subne r0, sv_pc, #4 @ allow for mov
> > subeq r0, sv_pc, #8 @ allow for mov + stmia
> >
> > --
> > 1.7.9.5
> >
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-30 11:02 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 10+ messages in thread
From: Russell King - ARM Linux admin @ 2019-07-30 11:02 UTC (permalink / raw)
To: Chunyan Zhang; +Cc: Linux Kernel Mailing List, Linux ARM, Lvqiang Huang
On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote:
> Gentle ping
>
> probably this patch was missed or entered into spam?
Please submit it to the patch system, thanks.
>
> On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> >
> > From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> >
> > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> > - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> > + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> > then the shift need to change to 11.
> >
> > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> > Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> > ---
> > arch/arm/lib/backtrace.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> > index 7d7952e..926851b 100644
> > --- a/arch/arm/lib/backtrace.S
> > +++ b/arch/arm/lib/backtrace.S
> > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
> >
> > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> > - teq r3, r2, lsr #10 @ instruction
> > + teq r3, r2, lsr #11 @ instruction
> > subne r0, sv_pc, #4 @ allow for mov
> > subeq r0, sv_pc, #8 @ allow for mov + stmia
> >
> > --
> > 1.7.9.5
> >
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
2019-07-30 11:02 ` Russell King - ARM Linux admin
@ 2019-07-31 3:30 ` Chunyan Zhang
-1 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-31 3:30 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: Linux ARM, Linux Kernel Mailing List, Lvqiang Huang
On Tue, 30 Jul 2019 at 19:02, Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote:
> > Gentle ping
> >
> > probably this patch was missed or entered into spam?
>
> Please submit it to the patch system, thanks.
Ok, thanks.
>
> >
> > On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> > >
> > > From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > >
> > > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> > > - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> > > + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> > > then the shift need to change to 11.
> > >
> > > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> > > Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> > > ---
> > > arch/arm/lib/backtrace.S | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> > > index 7d7952e..926851b 100644
> > > --- a/arch/arm/lib/backtrace.S
> > > +++ b/arch/arm/lib/backtrace.S
> > > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
> > >
> > > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> > > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> > > - teq r3, r2, lsr #10 @ instruction
> > > + teq r3, r2, lsr #11 @ instruction
> > > subne r0, sv_pc, #4 @ allow for mov
> > > subeq r0, sv_pc, #8 @ allow for mov + stmia
> > >
> > > --
> > > 1.7.9.5
> > >
> >
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: check stmfd instruction using right shift
@ 2019-07-31 3:30 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2019-07-31 3:30 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: Linux Kernel Mailing List, Linux ARM, Lvqiang Huang
On Tue, 30 Jul 2019 at 19:02, Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote:
> > Gentle ping
> >
> > probably this patch was missed or entered into spam?
>
> Please submit it to the patch system, thanks.
Ok, thanks.
>
> >
> > On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> > >
> > > From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > >
> > > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> > > - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> > > + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> > > then the shift need to change to 11.
> > >
> > > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> > > Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> > > ---
> > > arch/arm/lib/backtrace.S | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> > > index 7d7952e..926851b 100644
> > > --- a/arch/arm/lib/backtrace.S
> > > +++ b/arch/arm/lib/backtrace.S
> > > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
> > >
> > > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> > > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> > > - teq r3, r2, lsr #10 @ instruction
> > > + teq r3, r2, lsr #11 @ instruction
> > > subne r0, sv_pc, #4 @ allow for mov
> > > subeq r0, sv_pc, #8 @ allow for mov + stmia
> > >
> > > --
> > > 1.7.9.5
> > >
> >
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-07-31 3:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 7:11 [PATCH] ARM: check stmfd instruction using right shift Chunyan Zhang
2019-07-22 7:11 ` Chunyan Zhang
2019-07-22 7:14 ` Chunyan Zhang
2019-07-22 7:14 ` Chunyan Zhang
2019-07-30 7:18 ` Chunyan Zhang
2019-07-30 7:18 ` Chunyan Zhang
2019-07-30 11:02 ` Russell King - ARM Linux admin
2019-07-30 11:02 ` Russell King - ARM Linux admin
2019-07-31 3:30 ` Chunyan Zhang
2019-07-31 3:30 ` Chunyan Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.