From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F090CC76188 for ; Mon, 22 Jul 2019 13:40:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3962216C8 for ; Mon, 22 Jul 2019 13:40:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="YTqDgeSQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbfGVNk2 (ORCPT ); Mon, 22 Jul 2019 09:40:28 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55898 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727510AbfGVNk2 (ORCPT ); Mon, 22 Jul 2019 09:40:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m+J1fo9vC+WNoRkwu0Z8WI8RZOnFX+pR10avPTXahe0=; b=YTqDgeSQ3BEPwTEjGIIxaQJjEs 6faT7OpX0YBbbl5MGRow7+NXfIducm9Bqgo0fGJ/tEajMGReX3iorXyIVXnAsQjKfY6MgEUttxK7+ X/oka7lwuQcnYVYfVqVduUS7yDVpne3tuBHviPNhd7RPHiXXyioYLebkrGCM9MAa2yj0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hpYYB-0002x6-Uc; Mon, 22 Jul 2019 15:40:23 +0200 Date: Mon, 22 Jul 2019 15:40:23 +0200 From: Andrew Lunn To: Jose Abreu Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink Message-ID: <20190722134023.GD8972@lunn.ch> References: <20190722124240.464e73losonwb356@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 01:28:51PM +0000, Jose Abreu wrote: > From: Ondřej Jirman > Date: Jul/22/2019, 13:42:40 (UTC+00:00) > > > Hello Jose, > > > > On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > > > [ Hope this diff looks better (generated with --minimal) ] > > > > > > This converts stmmac to use phylink. Besides the code redution this will > > > allow to gain more flexibility. > > > > I'm testing 5.3-rc1 and on Orange Pi 3 (uses stmmac-sun8i.c glue) compared to > > 5.2 it fails to detect 1000Mbps link and the driver negotiates just a 10Mbps speed. > > > > After going through stmmac patches since 5.2, I think it may be realted to this > > series, but I'm not completely sure. You'll probably have a better understanding > > of the changes. Do you have an idea what might be wrong? Please, see some logs > > below. > > Probably due to: > 5b0d7d7da64b ("net: stmmac: Add the missing speeds that XGMAC supports") > > Can you try attached patch ? > Hi Jose Does this mean that all stmmac variants support 1G? There are none which just support Fast Ethernet? I'm also not sure the change fits the problem. Why did it not negotiate 100FULL rather than 10Half? You are only moving the 1G speeds around, so 100 speeds should of been advertised and selected. Thanks Andrew