From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D314EC76190 for ; Mon, 22 Jul 2019 13:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62FCB217D6 for ; Mon, 22 Jul 2019 13:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="D87o/8mH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730647AbfGVNtf (ORCPT ); Mon, 22 Jul 2019 09:49:35 -0400 Received: from vps.xff.cz ([195.181.215.36]:34076 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729765AbfGVNtf (ORCPT ); Mon, 22 Jul 2019 09:49:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1563803371; bh=PWmszP0mXNU9tgaWjpzjbQtOQTIiBeMp0AoXGjlt9+c=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=D87o/8mHMW+AuDejEYTVbLgBBvD0KoT0Q++ZbJYidBmEAOZmwZ5CNyKgXehiU5AgP FCA9jvcLOwareSdFsXo94Av3bx5Z55KN0Qo9Vsg58qpKtPMSshfeU/GeGWabkT9xY9 OK5e+5+CmtzoFt4ahF7E1/p5pTPLyrvYnyI/7ZAY= Date: Mon, 22 Jul 2019 15:49:31 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Jose Abreu Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink Message-ID: <20190722134931.nsxi7qcxgmi5mcfb@core.my.home> Mail-Followup-To: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit References: <20190722124240.464e73losonwb356@core.my.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x3qfmvlquhnlcpdh" Content-Disposition: inline In-Reply-To: X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x3qfmvlquhnlcpdh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2019 at 01:28:51PM +0000, Jose Abreu wrote: > From: Ond=C5=99ej Jirman > Date: Jul/22/2019, 13:42:40 (UTC+00:00) >=20 > > Hello Jose, > >=20 > > On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > > > [ Hope this diff looks better (generated with --minimal) ] > > >=20 > > > This converts stmmac to use phylink. Besides the code redution this w= ill > > > allow to gain more flexibility. > >=20 > > I'm testing 5.3-rc1 and on Orange Pi 3 (uses stmmac-sun8i.c glue) compa= red to > > 5.2 it fails to detect 1000Mbps link and the driver negotiates just a 1= 0Mbps speed. > >=20 > > After going through stmmac patches since 5.2, I think it may be realted= to this > > series, but I'm not completely sure. You'll probably have a better unde= rstanding > > of the changes. Do you have an idea what might be wrong? Please, see so= me logs > > below. >=20 > Probably due to: > 5b0d7d7da64b ("net: stmmac: Add the missing speeds that XGMAC supports") >=20 > Can you try attached patch ? Tried, and it works! dwmac-sun8i 5020000.ethernet eth0: PHY [stmmac-0:01] driver [RTL8211E Gigab= it Ethernet] dwmac-sun8i 5020000.ethernet eth0: phy: setting supported 00,00000000,00006= 2ff advertising 00,00000000,000062ff dwmac-sun8i 5020000.ethernet eth0: No Safety Features support found dwmac-sun8i 5020000.ethernet eth0: No MAC Management Counters available dwmac-sun8i 5020000.ethernet eth0: PTP not supported by HW dwmac-sun8i 5020000.ethernet eth0: configuring for phy/rgmii link mode dwmac-sun8i 5020000.ethernet eth0: phylink_mac_config: mode=3Dphy/rgmii/Unk= nown/Unknown adv=3D00,00000000,000062ff pause=3D10 link=3D0 an=3D1 dwmac-sun8i 5020000.ethernet eth0: phy link down rgmii/Unknown/Unknown dwmac-sun8i 5020000.ethernet eth0: phy link up rgmii/1Gbps/Full dwmac-sun8i 5020000.ethernet eth0: phylink_mac_config: mode=3Dphy/rgmii/1Gb= ps/Full adv=3D00,00000000,00000000 pause=3D0f link=3D1 an=3D0 dwmac-sun8i 5020000.ethernet eth0: Link is Up - 1Gbps/Full - flow control r= x/tx IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready Tested-by: Ondrej Jirman thank you, Ondrej >=20 > >=20 > > thank you and regards, > > Ondrej > >=20 > > On 5.3-rc1 I see: > >=20 > > [ 6.116512] dwmac-sun8i 5020000.ethernet eth0: PHY [stmmac-0:01] dri= ver [RTL8211E Gigabit Ethernet] > > [ 6.116522] dwmac-sun8i 5020000.ethernet eth0: phy: setting supporte= d 00,00000000,000062cf advertising 00,00000000,000062cf > > [ 6.118714] dwmac-sun8i 5020000.ethernet eth0: No Safety Features su= pport found > > [ 6.118725] dwmac-sun8i 5020000.ethernet eth0: No MAC Management Cou= nters available > > [ 6.118730] dwmac-sun8i 5020000.ethernet eth0: PTP not supported by = HW > > [ 6.118738] dwmac-sun8i 5020000.ethernet eth0: configuring for phy/r= gmii link mode > > [ 6.118747] dwmac-sun8i 5020000.ethernet eth0: phylink_mac_config: m= ode=3Dphy/rgmii/Unknown/Unknown adv=3D00,00000000,000062cf pause=3D10 link= =3D0 an=3D1 > > [ 6.126099] dwmac-sun8i 5020000.ethernet eth0: phy link down rgmii/U= nknown/Unknown > > [ 6.276325] random: crng init done > > [ 6.276338] random: 7 urandom warning(s) missed due to ratelimiting > > [ 7.543987] zram0: detected capacity change from 0 to 402653184 > > [ 7.667702] Adding 393212k swap on /dev/zram0. Priority:10 extents:= 1 across:393212k SS > >=20 > > ... delay due to other causes ... > >=20 > > [ 28.640234] dwmac-sun8i 5020000.ethernet eth0: phy link up rgmii/10M= bps/Full > > [ 28.640295] dwmac-sun8i 5020000.ethernet eth0: phylink_mac_config: m= ode=3Dphy/rgmii/10Mbps/Full adv=3D00,00000000,00000000 pause=3D0f link=3D1 = an=3D0 > > [ 28.640324] dwmac-sun8i 5020000.ethernet eth0: Link is Up - 10Mbps/F= ull - flow control rx/tx > >=20 > > Settings for eth0: > > Supported ports: [ TP MII ] > > Supported link modes: 10baseT/Half 10baseT/Full=20 > > 100baseT/Half 100baseT/Full=20 > > Supported pause frame use: Symmetric Receive-only > > Supports auto-negotiation: Yes > > Supported FEC modes: Not reported > > Advertised link modes: 10baseT/Half 10baseT/Full=20 > > 100baseT/Half 100baseT/Full=20 > > Advertised pause frame use: Symmetric Receive-only > > Advertised auto-negotiation: Yes > > Advertised FEC modes: Not reported > > Link partner advertised link modes: 10baseT/Half 10baseT/Full=20 > > Link partner advertised pause frame use: Symmetric Receive-only > > Link partner advertised auto-negotiation: Yes > > Link partner advertised FEC modes: Not reported > > Speed: 10Mb/s > > Duplex: Full > > Port: MII > > PHYAD: 1 > > Transceiver: internal > > Auto-negotiation: on > > Supports Wake-on: d > > Wake-on: d > > Current message level: 0x0000003f (63) > > drv probe link timer ifdown ifup > > Link detected: yes > >=20 > > On 5.2 it looks like this: > >=20 > > [ 1.153596] dwmac-sun8i 5020000.ethernet: PTP uses main clock > > [ 1.416221] dwmac-sun8i 5020000.ethernet: PTP uses main clock > > [ 1.522735] dwmac-sun8i 5020000.ethernet: Current syscon value is no= t the default 58000 (expect 50000) > > [ 1.522750] dwmac-sun8i 5020000.ethernet: No HW DMA feature register= supported > > [ 1.522753] dwmac-sun8i 5020000.ethernet: RX Checksum Offload Engine= supported > > [ 1.522755] dwmac-sun8i 5020000.ethernet: COE Type 2 > > [ 1.522758] dwmac-sun8i 5020000.ethernet: TX Checksum insertion supp= orted > > [ 1.522761] dwmac-sun8i 5020000.ethernet: Normal descriptors > > [ 1.522763] dwmac-sun8i 5020000.ethernet: Chain mode enabled > > [ 5.352833] dwmac-sun8i 5020000.ethernet eth0: No Safety Features su= pport found > > [ 5.352842] dwmac-sun8i 5020000.ethernet eth0: No MAC Management Cou= nters available > > [ 5.352846] dwmac-sun8i 5020000.ethernet eth0: PTP not supported by = HW > > [ 10.463072] dwmac-sun8i 5020000.ethernet eth0: Link is Up - 1Gbps/Fu= ll - flow control off > >=20 > > Settings for eth0: > > Supported ports: [ TP MII ] > > Supported link modes: 10baseT/Half 10baseT/Full > > 100baseT/Half 100baseT/Full > > 1000baseT/Half 1000baseT/Full > > Supported pause frame use: Symmetric Receive-only > > Supports auto-negotiation: Yes > > Supported FEC modes: Not reported > > Advertised link modes: 10baseT/Half 10baseT/Full > > 100baseT/Half 100baseT/Full > > 1000baseT/Half 1000baseT/Full > > Advertised pause frame use: No > > Advertised auto-negotiation: Yes > > Advertised FEC modes: Not reported > > Link partner advertised link modes: 10baseT/Half 10baseT/Full > > 100baseT/Half 100baseT/Full > > 1000baseT/Full > > Link partner advertised pause frame use: Symmetric Receive-only > > Link partner advertised auto-negotiation: Yes > > Link partner advertised FEC modes: Not reported > > Speed: 1000Mb/s > > Duplex: Full > > Port: MII > > PHYAD: 1 > > Transceiver: internal > > Auto-negotiation: on > > Supports Wake-on: d > > Wake-on: d > > Current message level: 0x0000003f (63) > > drv probe link timer ifdown ifup > > Link detected: yes > >=20 > >=20 > > > Cc: Joao Pinto > > > Cc: David S. Miller > > > Cc: Giuseppe Cavallaro > > > Cc: Alexandre Torgue > > > Cc: Russell King > > > Cc: Andrew Lunn > > > Cc: Florian Fainelli > > > Cc: Heiner Kallweit > > >=20 > > > Jose Abreu (3): > > > net: stmmac: Prepare to convert to phylink > > > net: stmmac: Start adding phylink support > > > net: stmmac: Convert to phylink and remove phylib logic > > >=20 > > > drivers/net/ethernet/stmicro/stmmac/Kconfig | 3 +- > > > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- > > > .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 81 +--- > > > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 391 ++++++++--------= -- > > > .../ethernet/stmicro/stmmac/stmmac_platform.c | 21 +- > > > 5 files changed, 190 insertions(+), 313 deletions(-) > > >=20 > > > --=20 > > > 2.21.0 > > >=20 >=20 >=20 > --- > Thanks, > Jose Miguel Abreu --x3qfmvlquhnlcpdh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTr+93hH7kY1E0fVsH58Khzvpd37QUCXTW+6AAKCRD58Khzvpd3 7QkKAP0f0kyseTrfqIdkpawP8zXwrwhLbaxhxqp4jJ69dcEKXAD8CTOzvbXAwEsa ot9X/StEXNDK6xVmeG9gW1l322ij9QI= =XTTm -----END PGP SIGNATURE----- --x3qfmvlquhnlcpdh--