From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC189C76188 for ; Mon, 22 Jul 2019 15:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DB96214C6 for ; Mon, 22 Jul 2019 15:29:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="PKEx1YJP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729061AbfGVP3u (ORCPT ); Mon, 22 Jul 2019 11:29:50 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:39400 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728385AbfGVP3t (ORCPT ); Mon, 22 Jul 2019 11:29:49 -0400 Received: by mail-vs1-f67.google.com with SMTP id u3so26355617vsh.6 for ; Mon, 22 Jul 2019 08:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u1HHQwKS52S4EmuUPfeZPTFm+/hCi45AhWYKrSPj4Ik=; b=PKEx1YJP9uBCjqrN8BTLCJ8yorJ1CWA8nCOsypDBggKEVh6cZW2dDj9M5qoBDcK03o 2dgoX6+CmZpTwev504V0IKArMx0poQZxpHmid3PiIDy5julUSwmV9ogKGjQHP5v30MD5 0HZrz4L154NL2rDqEPdMi9fve68QaP/4lUrsZKC7+0N21OT1ERT5FxCmktDkPj5y8f6+ 4fYEqHdDiu1H8rKuSLGcN0DIJwWh0Y+r75sru7bFyTe+30i7Zu6SK7VYbnP0vi97Sd2o YxUb3srfhRym5Q26NpDq+OAlp9dAm6RCAU3HIippeC51SyjXrnMb3ivMD3Y6zdP1z90N 46JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u1HHQwKS52S4EmuUPfeZPTFm+/hCi45AhWYKrSPj4Ik=; b=p2gFXWp1hXo5vfC0siHYN5qse+mcQcCJ2W/lnjvXT/r36OJVr8jLFZRzv3vYFk6TnO PAh3EWP3hTJQa2cronWcE7+SLwti804nX34+b1myC11hjVQ0EBwW5lLmo7nPSRftmUUO YgeXX3LwuW2AHJ1wyFGWHawzG85L4Q7J6JiaLG2Wx+3q5DPsxPPwk/DlXzYS+OumWMLw j7u3PCDqbDp968ropOLp/mCtmsh0TLZZoui21qBDf2hSMjASBTAPTiJaUU5LHR0pOcb9 t9FP8Zu9yKYPRHYr6VNy5h40nBUiXG0WSdMoDUNbjSaH91C8r0e9A3dax+4jC4j3LwGC BkGA== X-Gm-Message-State: APjAAAUGTWvu8mUXOQHimmgVDGNL2RYMDqKay20xBfhYAECZS14ISoeu MgjRZRco6ZuprBTHg93I0E+oeg== X-Google-Smtp-Source: APXvYqyXO5C/K9eycLxYIaN49TgoiszJjgK7Uyy5dAXmdHDosJ2JGqbxsPHDn/jrOxi5PtTDpwLJ7A== X-Received: by 2002:a67:f713:: with SMTP id m19mr601509vso.183.1563809388836; Mon, 22 Jul 2019 08:29:48 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id t200sm15801789vke.5.2019.07.22.08.29.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 08:29:48 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hpaG3-0004rf-Qk; Mon, 22 Jul 2019 12:29:47 -0300 Date: Mon, 22 Jul 2019 12:29:47 -0300 From: Jason Gunthorpe To: Maksym Planeta Cc: Moni Shoua , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] Pass the return value of kref_put further Message-ID: <20190722152947.GF7607@ziepe.ca> References: <20190722151426.5266-1-mplaneta@os.inf.tu-dresden.de> <20190722151426.5266-8-mplaneta@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190722151426.5266-8-mplaneta@os.inf.tu-dresden.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jul 22, 2019 at 05:14:23PM +0200, Maksym Planeta wrote: > Used in a later patch. > > Signed-off-by: Maksym Planeta > drivers/infiniband/sw/rxe/rxe_pool.c | 3 ++- > drivers/infiniband/sw/rxe/rxe_pool.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c > index 30a887cf9200..711d7d7f3692 100644 > +++ b/drivers/infiniband/sw/rxe/rxe_pool.c > @@ -541,7 +541,7 @@ static void rxe_dummy_release(struct kref *kref) > { > } > > -void rxe_drop_ref(struct rxe_pool_entry *pelem) > +int rxe_drop_ref(struct rxe_pool_entry *pelem) > { > int res; > struct rxe_pool *pool = pelem->pool; > @@ -553,4 +553,5 @@ void rxe_drop_ref(struct rxe_pool_entry *pelem) > if (res) { > rxe_elem_release(&pelem->ref_cnt); > } > + return res; > } Using the return value of kref_put at all is super sketchy. Are you sure this is actually a kref usage pattern? Why would this be needed? Jason