All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ruxandra.radulescu@nxp.com
Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for TCP frames
Date: Tue, 23 Jul 2019 14:02:55 -0700 (PDT)	[thread overview]
Message-ID: <20190723.140255.1785812525450069326.davem@davemloft.net> (raw)
In-Reply-To: <1563902923-26178-1-git-send-email-ruxandra.radulescu@nxp.com>

From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Date: Tue, 23 Jul 2019 20:28:43 +0300

> Using Rx skb bulking for all frames may negatively impact the
> performance in some TCP termination scenarios, as it effectively
> bypasses GRO.

"may"?

Please provide numbers so that we know exactly whether it actually
hurts performance one way or another.

Thank you.

  parent reply	other threads:[~2019-07-23 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 17:28 [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for TCP frames Ioana Radulescu
2019-07-23 17:54 ` Saeed Mahameed
2019-07-23 21:02 ` David Miller [this message]
2019-07-24  8:15   ` Ioana Ciocoi Radulescu
2019-07-24  7:10 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723.140255.1785812525450069326.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ioana.ciornei@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.