From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yafang Shao <laoar.shao@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Yafang Shao <shaoyafang@didiglobal.com>
Subject: Re: [PATCH] mm/compaction: clear total_{migrate,free}_scanned before scanning a new zone
Date: Tue, 23 Jul 2019 07:59:56 +0100 [thread overview]
Message-ID: <20190723065956.GI24383@techsingularity.net> (raw)
In-Reply-To: <20190722171700.399bf6353fb06ee1a82ffaa5@linux-foundation.org>
On Mon, Jul 22, 2019 at 05:17:00PM -0700, Andrew Morton wrote:
> On Mon, 22 Jul 2019 05:54:35 -0400 Yafang Shao <laoar.shao@gmail.com> wrote:
>
> > total_{migrate,free}_scanned will be added to COMPACTMIGRATE_SCANNED and
> > COMPACTFREE_SCANNED in compact_zone(). We should clear them before scanning
> > a new zone.
> > In the proc triggered compaction, we forgot clearing them.
>
> It isn't the worst bug we've ever had, but I'm thinking we should
> backport the fix into -stable kernels?
>
There is no harm in having it in -stable. It may matter for those trying
to debug excessive compaction activity and getting misleading stats.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-07-23 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:54 [PATCH] mm/compaction: clear total_{migrate,free}_scanned before scanning a new zone Yafang Shao
2019-07-23 0:17 ` Andrew Morton
2019-07-23 6:59 ` Mel Gorman [this message]
2019-07-23 5:36 ` Michal Hocko
2019-07-23 5:55 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723065956.GI24383@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shaoyafang@didiglobal.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.