From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
patches@opensource.cirrus.com,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mark Brown <broonie@kernel.org>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Subject: Re: [PATCH 1/2] ASoC: wm8904: rework FLL handling
Date: Tue, 23 Jul 2019 09:27:16 +0100 [thread overview]
Message-ID: <20190723082716.GM54126@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <3e104cf18cb4e26096f0fe065a2c0e80373f861c.1563817201.git.mirq-linux@rere.qmqm.pl>
On Mon, Jul 22, 2019 at 07:57:21PM +0200, Michał Mirosław wrote:
> Extract and rework FLL handling. This makes it possible to reuse
> the code for other Wolfson codecs and makes codec adapt SYSCLK to
> exactly match frequency required for used sampling rate.
>
Do you have thoughts on which CODECs you would be including in
this? These older parts often have small differences between the
configuration that might make this challenging so if you have
plans here would be good to have a look from this end.
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> .../devicetree/bindings/sound/wm8904.txt | 4 +
> sound/soc/atmel/atmel_wm8904.c | 11 +-
> sound/soc/codecs/Kconfig | 4 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/wm8904.c | 454 +++++-------------
> sound/soc/codecs/wm8904.h | 5 -
> sound/soc/codecs/wm_fll.c | 339 +++++++++++++
> sound/soc/codecs/wm_fll.h | 26 +
> 8 files changed, 492 insertions(+), 353 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/wm8904.txt b/Documentation/devicetree/bindings/sound/wm8904.txt
> index 66bf261423b9..6b51d87f5987 100644
> --- a/Documentation/devicetree/bindings/sound/wm8904.txt
> +++ b/Documentation/devicetree/bindings/sound/wm8904.txt
> @@ -9,6 +9,10 @@ Required properties:
> - clocks: reference to
> <Documentation/devicetree/bindings/clock/clock-bindings.txt>
>
> +Optional properties:
> + - wlf,fll-input: FLL input signal: "mclk", "bclk", "lrclk" or "osc"
> + ("mclk" by default)
> +
Would be keen to see some other peoples thoughts on this one, but
this feels a little off to me. Selecting the FLL input is
generally something that would be done on a use-case by use-case
basis rather than being a property of the hardware that would
belong in device tree.
Thanks,
Charles
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-07-23 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:57 [PATCH 0/2] wm8904: adapt driver for use with audio-graph-card Michał Mirosław
2019-07-22 17:57 ` [PATCH 1/2] ASoC: wm8904: rework FLL handling Michał Mirosław
2019-07-23 8:27 ` Charles Keepax [this message]
2019-07-23 10:52 ` Mark Brown
2019-07-23 11:54 ` Michał Mirosław
2019-07-23 14:38 ` Mark Brown
2019-07-23 14:53 ` Charles Keepax
2019-07-22 17:57 ` [PATCH 2/2] ASoC: wm8904: automatically choose clock source Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723082716.GM54126@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=lgirdwood@gmail.com \
--cc=ludovic.desroches@microchip.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nicolas.ferre@microchip.com \
--cc=patches@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.