From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C7E5C7618E for ; Tue, 23 Jul 2019 12:47:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24C0921903 for ; Tue, 23 Jul 2019 12:47:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C0921903 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpuCJ-0000X2-8O for qemu-devel@archiver.kernel.org; Tue, 23 Jul 2019 08:47:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45601) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpuC6-0008TL-59 for qemu-devel@nongnu.org; Tue, 23 Jul 2019 08:47:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpuC4-0004qP-PJ for qemu-devel@nongnu.org; Tue, 23 Jul 2019 08:47:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpuC1-0004o7-Jr; Tue, 23 Jul 2019 08:46:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2B48B4E93D; Tue, 23 Jul 2019 12:46:55 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 919E160BEC; Tue, 23 Jul 2019 12:46:52 +0000 (UTC) Date: Tue, 23 Jul 2019 14:46:50 +0200 From: Igor Mammedov To: Shameerali Kolothum Thodi Message-ID: <20190723144650.4644ffb5@redhat.com> In-Reply-To: <5FC3163CFD30C246ABAA99954A238FA83F310A72@lhreml524-mbs.china.huawei.com> References: <20190716153816.17676-1-shameerali.kolothum.thodi@huawei.com> <20190716153816.17676-10-shameerali.kolothum.thodi@huawei.com> <20190718150301.45b3fb57@redhat.com> <5FC3163CFD30C246ABAA99954A238FA83F310A72@lhreml524-mbs.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 23 Jul 2019 12:46:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH-for-4.2 v7 09/10] hw/arm: Use GED for system_powerdown event X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "peter.maydell@linaro.org" , "sameo@linux.intel.com" , "ard.biesheuvel@linaro.org" , "qemu-devel@nongnu.org" , Linuxarm , "shannon.zhaosl@gmail.com" , "qemu-arm@nongnu.org" , "xuwei \(O\)" , "sebastien.boeuf@intel.com" , "lersek@redhat.com" , "eric.auger@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Jul 2019 14:15:17 +0000 Shameerali Kolothum Thodi wrote: > > -----Original Message----- > > From: Qemu-devel > > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nongn > > u.org] On Behalf Of Igor Mammedov > > Sent: 18 July 2019 14:03 > > To: Shameerali Kolothum Thodi > > Cc: peter.maydell@linaro.org; sameo@linux.intel.com; > > shannon.zhaosl@gmail.com; ard.biesheuvel@linaro.org; > > qemu-devel@nongnu.org; xuwei (O) ; Linuxarm > > ; eric.auger@redhat.com; qemu-arm@nongnu.org; > > sebastien.boeuf@intel.com; lersek@redhat.com > > Subject: Re: [Qemu-devel] [PATCH-for-4.2 v7 09/10] hw/arm: Use GED for > > system_powerdown event > > > > On Tue, 16 Jul 2019 16:38:15 +0100 > > Shameer Kolothum wrote: > > > > > Use GED for system_powerdown event instead of GPIO for ACPI. > > > Guest boot with DT still uses GPIO. > > > > > > I'd hate to keep ACPI GPIO around but taking in account migration > > wouldn't this patch break ACPI GPIO based button on 4.0 and older where > > GED is not available and guest was booted as ACPI one and then rebooted on > > new QEMU? > > Hmm..That looks like a valid case unfortunately :(. I will keep the GPIO then. yep, keep it for old machine types. New ones should use GED. > > Thanks, > Shameer > > > > > > Signed-off-by: Shameer Kolothum > > > Reviewed-by: Eric Auger > > > --- > > > hw/arm/virt-acpi-build.c | 37 +------------------------------------ > > > hw/arm/virt.c | 6 +++--- > > > 2 files changed, 4 insertions(+), 39 deletions(-) > > > > > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > > > index 75657caa36..9178ca8e40 100644 > > > --- a/hw/arm/virt-acpi-build.c > > > +++ b/hw/arm/virt-acpi-build.c > > > @@ -49,7 +49,6 @@ > > > #include "kvm_arm.h" > > > > > > #define ARM_SPI_BASE 32 > > > -#define ACPI_POWER_BUTTON_DEVICE "PWRB" > > > > > > static void acpi_dsdt_add_cpus(Aml *scope, int smp_cpus) > > > { > > > @@ -328,37 +327,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const > > MemMapEntry *memmap, > > > aml_append(scope, dev); > > > } > > > > > > -static void acpi_dsdt_add_gpio(Aml *scope, const MemMapEntry > > *gpio_memmap, > > > - uint32_t gpio_irq) > > > -{ > > > - Aml *dev = aml_device("GPO0"); > > > - aml_append(dev, aml_name_decl("_HID", aml_string("ARMH0061"))); > > > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > > > - aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > > - > > > - Aml *crs = aml_resource_template(); > > > - aml_append(crs, aml_memory32_fixed(gpio_memmap->base, > > gpio_memmap->size, > > > - AML_READ_WRITE)); > > > - aml_append(crs, aml_interrupt(AML_CONSUMER, AML_LEVEL, > > AML_ACTIVE_HIGH, > > > - AML_EXCLUSIVE, &gpio_irq, 1)); > > > - aml_append(dev, aml_name_decl("_CRS", crs)); > > > - > > > - Aml *aei = aml_resource_template(); > > > - /* Pin 3 for power button */ > > > - const uint32_t pin_list[1] = {3}; > > > - aml_append(aei, aml_gpio_int(AML_CONSUMER, AML_EDGE, > > AML_ACTIVE_HIGH, > > > - AML_EXCLUSIVE, AML_PULL_UP, 0, > > pin_list, 1, > > > - "GPO0", NULL, 0)); > > > - aml_append(dev, aml_name_decl("_AEI", aei)); > > > - > > > - /* _E03 is handle for power button */ > > > - Aml *method = aml_method("_E03", 0, AML_NOTSERIALIZED); > > > - aml_append(method, > > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), > > > - aml_int(0x80))); > > > - aml_append(dev, method); > > > - aml_append(scope, dev); > > > -} > > > - > > > static void acpi_dsdt_add_power_button(Aml *scope) > > > { > > > Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > > @@ -739,9 +707,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > > VirtMachineState *vms) > > > (irqmap[VIRT_MMIO] + ARM_SPI_BASE), > > NUM_VIRTIO_TRANSPORTS); > > > acpi_dsdt_add_pci(scope, memmap, (irqmap[VIRT_PCIE] + > > ARM_SPI_BASE), > > > vms->highmem, vms->highmem_ecam); > > > - acpi_dsdt_add_gpio(scope, &memmap[VIRT_GPIO], > > > - (irqmap[VIRT_GPIO] + ARM_SPI_BASE)); > > > if (vms->acpi_dev) { > > > + acpi_dsdt_add_power_button(scope); > > > build_ged_aml(scope, "\\_SB."GED_DEVICE, > > > HOTPLUG_HANDLER(vms->acpi_dev), > > > irqmap[VIRT_ACPI_GED] + ARM_SPI_BASE, > > AML_SYSTEM_MEMORY); > > > @@ -752,8 +719,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > > VirtMachineState *vms) > > > AML_SYSTEM_MEMORY); > > > } > > > > > > - acpi_dsdt_add_power_button(scope); > > > - > > > aml_append(dsdt, scope); > > > > > > /* copy AML table into ACPI tables blob and patch header there */ > > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > > index ffcccc05ad..6e55c25c5f 100644 > > > --- a/hw/arm/virt.c > > > +++ b/hw/arm/virt.c > > > @@ -528,7 +528,7 @@ static inline DeviceState > > *create_acpi_ged(VirtMachineState *vms, qemu_irq *pic) > > > { > > > DeviceState *dev; > > > int irq = vms->irqmap[VIRT_ACPI_GED]; > > > - uint32_t event = ACPI_GED_MEM_HOTPLUG_EVT; > > > + uint32_t event = ACPI_GED_MEM_HOTPLUG_EVT | > > ACPI_GED_PWR_DOWN_EVT; > > > > > > dev = DEVICE(object_new(TYPE_ACPI_GED)); > > > qdev_prop_set_uint64(dev, "memhp-base", > > > @@ -1718,10 +1718,10 @@ static void machvirt_init(MachineState > > *machine) > > > > > > create_pcie(vms, pic); > > > > > > - create_gpio(vms, pic); > > > - > > > if (!vmc->no_acpi_dev && aarch64 && firmware_loaded && > > acpi_enabled) { > > > vms->acpi_dev = create_acpi_ged(vms, pic); > > > + } else { > > > + create_gpio(vms, pic); > > > } > > > > > > /* Create mmio transports, so the user can create virtio backends