* [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
@ 2019-07-23 9:25 Chris Wilson
2019-07-23 9:25 ` [PATCH 2/4] drm/i915/gt: Provde a local intel_context.vm Chris Wilson
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 9:25 UTC (permalink / raw)
To: intel-gfx
The aliasing_ppgtt provides a PIN_USER alias for the global gtt, so move
it under the i915_ggtt to simplify later transformations to enable
intel_context.vm.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +-
.../drm/i915/gem/selftests/i915_gem_context.c | 2 +-
drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 69 ++++++++++++-------
drivers/gpu/drm/i915/i915_drv.h | 3 -
drivers/gpu/drm/i915/i915_gem_gtt.c | 36 +++++-----
drivers/gpu/drm/i915/i915_gem_gtt.h | 3 +
drivers/gpu/drm/i915/i915_vma.c | 2 +-
7 files changed, 71 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index ffb59d96d4d8..0f6b0678f548 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -459,8 +459,7 @@ __create_context(struct drm_i915_private *i915)
i915_gem_context_set_recoverable(ctx);
ctx->ring_size = 4 * PAGE_SIZE;
- ctx->desc_template =
- default_desc_template(i915, &i915->mm.aliasing_ppgtt->vm);
+ ctx->desc_template = default_desc_template(i915, NULL);
for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp); i++)
ctx->hang_timestamp[i] = jiffies - CONTEXT_FAST_HANG_JIFFIES;
@@ -2258,8 +2257,8 @@ int i915_gem_context_getparam_ioctl(struct drm_device *dev, void *data,
args->size = 0;
if (ctx->vm)
args->value = ctx->vm->total;
- else if (to_i915(dev)->mm.aliasing_ppgtt)
- args->value = to_i915(dev)->mm.aliasing_ppgtt->vm.total;
+ else if (to_i915(dev)->ggtt.alias)
+ args->value = to_i915(dev)->ggtt.alias->vm.total;
else
args->value = to_i915(dev)->ggtt.vm.total;
break;
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index db7856f0f31e..bbd17d4b8ffd 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -1190,7 +1190,7 @@ static int igt_ctx_readonly(void *arg)
goto out_unlock;
}
- vm = ctx->vm ?: &i915->mm.aliasing_ppgtt->vm;
+ vm = ctx->vm ?: &i915->ggtt.alias->vm;
if (!vm || !vm->has_read_only) {
err = 0;
goto out_unlock;
diff --git a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
index 1de19dac4a14..b056f25c66f2 100644
--- a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
@@ -1392,30 +1392,41 @@ static void ring_context_destroy(struct kref *ref)
intel_context_free(ce);
}
-static int __context_pin_ppgtt(struct i915_gem_context *ctx)
+static struct i915_address_space *vm_alias(struct intel_context *ce)
+{
+ struct i915_address_space *vm;
+
+ vm = ce->gem_context->vm;
+ if (!vm)
+ vm = &ce->engine->gt->ggtt->alias->vm;
+
+ return vm;
+}
+
+static int __context_pin_ppgtt(struct intel_context *ce)
{
struct i915_address_space *vm;
int err = 0;
- vm = ctx->vm ?: &ctx->i915->mm.aliasing_ppgtt->vm;
+ vm = vm_alias(ce);
if (vm)
err = gen6_ppgtt_pin(i915_vm_to_ppgtt((vm)));
return err;
}
-static void __context_unpin_ppgtt(struct i915_gem_context *ctx)
+static void __context_unpin_ppgtt(struct intel_context *ce)
{
struct i915_address_space *vm;
- vm = ctx->vm ?: &ctx->i915->mm.aliasing_ppgtt->vm;
+ vm = vm_alias(ce);
if (vm)
gen6_ppgtt_unpin(i915_vm_to_ppgtt(vm));
}
static void ring_context_unpin(struct intel_context *ce)
{
- __context_unpin_ppgtt(ce->gem_context);
+ __context_unpin_ppgtt(ce);
}
static struct i915_vma *
@@ -1509,7 +1520,7 @@ static int ring_context_pin(struct intel_context *ce)
if (err)
return err;
- err = __context_pin_ppgtt(ce->gem_context);
+ err = __context_pin_ppgtt(ce);
if (err)
goto err_active;
@@ -1701,7 +1712,7 @@ static inline int mi_set_context(struct i915_request *rq, u32 flags)
return 0;
}
-static int remap_l3(struct i915_request *rq, int slice)
+static int remap_l3_slice(struct i915_request *rq, int slice)
{
u32 *cs, *remap_info = rq->i915->l3_parity.remap_info[slice];
int i;
@@ -1729,15 +1740,34 @@ static int remap_l3(struct i915_request *rq, int slice)
return 0;
}
+static int remap_l3(struct i915_request *rq)
+{
+ struct i915_gem_context *ctx = rq->gem_context;
+ int i, err;
+
+ if (!ctx->remap_slice)
+ return 0;
+
+ for (i = 0; i < MAX_L3_SLICES; i++) {
+ if (!(ctx->remap_slice & BIT(i)))
+ continue;
+
+ err = remap_l3_slice(rq, i);
+ if (err)
+ return err;
+ }
+
+ ctx->remap_slice = 0;
+ return 0;
+}
+
static int switch_context(struct i915_request *rq)
{
struct intel_engine_cs *engine = rq->engine;
- struct i915_gem_context *ctx = rq->gem_context;
- struct i915_address_space *vm =
- ctx->vm ?: &rq->i915->mm.aliasing_ppgtt->vm;
+ struct i915_address_space *vm = vm_alias(rq->hw_context);
unsigned int unwind_mm = 0;
u32 hw_flags = 0;
- int ret, i;
+ int ret;
GEM_BUG_ON(HAS_EXECLISTS(rq->i915));
@@ -1781,7 +1811,7 @@ static int switch_context(struct i915_request *rq)
* as nothing actually executes using the kernel context; it
* is purely used for flushing user contexts.
*/
- if (i915_gem_context_is_kernel(ctx))
+ if (i915_gem_context_is_kernel(rq->gem_context))
hw_flags = MI_RESTORE_INHIBIT;
ret = mi_set_context(rq, hw_flags);
@@ -1815,18 +1845,9 @@ static int switch_context(struct i915_request *rq)
goto err_mm;
}
- if (ctx->remap_slice) {
- for (i = 0; i < MAX_L3_SLICES; i++) {
- if (!(ctx->remap_slice & BIT(i)))
- continue;
-
- ret = remap_l3(rq, i);
- if (ret)
- goto err_mm;
- }
-
- ctx->remap_slice = 0;
- }
+ ret = remap_l3(rq);
+ if (ret)
+ goto err_mm;
return 0;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 0e44cc4b2ca1..269a1b32b48b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -784,9 +784,6 @@ struct i915_gem_mm {
*/
struct vfsmount *gemfs;
- /** PPGTT used for aliasing the PPGTT with the GTT */
- struct i915_ppgtt *aliasing_ppgtt;
-
struct notifier_block oom_notifier;
struct notifier_block vmap_notifier;
struct shrinker shrinker;
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4dd1fa956143..8304b98b0bf8 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2446,18 +2446,18 @@ static int aliasing_gtt_bind_vma(struct i915_vma *vma,
pte_flags |= PTE_READ_ONLY;
if (flags & I915_VMA_LOCAL_BIND) {
- struct i915_ppgtt *appgtt = i915->mm.aliasing_ppgtt;
+ struct i915_ppgtt *alias = i915_vm_to_ggtt(vma->vm)->alias;
if (!(vma->flags & I915_VMA_LOCAL_BIND)) {
- ret = appgtt->vm.allocate_va_range(&appgtt->vm,
- vma->node.start,
- vma->size);
+ ret = alias->vm.allocate_va_range(&alias->vm,
+ vma->node.start,
+ vma->size);
if (ret)
return ret;
}
- appgtt->vm.insert_entries(&appgtt->vm, vma, cache_level,
- pte_flags);
+ alias->vm.insert_entries(&alias->vm, vma,
+ cache_level, pte_flags);
}
if (flags & I915_VMA_GLOBAL_BIND) {
@@ -2485,7 +2485,8 @@ static void aliasing_gtt_unbind_vma(struct i915_vma *vma)
}
if (vma->flags & I915_VMA_LOCAL_BIND) {
- struct i915_address_space *vm = &i915->mm.aliasing_ppgtt->vm;
+ struct i915_address_space *vm =
+ &i915_vm_to_ggtt(vma->vm)->alias->vm;
vm->clear_range(vm, vma->node.start, vma->size);
}
@@ -2542,13 +2543,12 @@ static void i915_gtt_color_adjust(const struct drm_mm_node *node,
*end -= I915_GTT_PAGE_SIZE;
}
-static int init_aliasing_ppgtt(struct drm_i915_private *i915)
+static int init_aliasing_ppgtt(struct i915_ggtt *ggtt)
{
- struct i915_ggtt *ggtt = &i915->ggtt;
struct i915_ppgtt *ppgtt;
int err;
- ppgtt = i915_ppgtt_create(i915);
+ ppgtt = i915_ppgtt_create(ggtt->vm.i915);
if (IS_ERR(ppgtt))
return PTR_ERR(ppgtt);
@@ -2567,7 +2567,7 @@ static int init_aliasing_ppgtt(struct drm_i915_private *i915)
if (err)
goto err_ppgtt;
- i915->mm.aliasing_ppgtt = ppgtt;
+ ggtt->alias = ppgtt;
GEM_BUG_ON(ggtt->vm.vma_ops.bind_vma != ggtt_bind_vma);
ggtt->vm.vma_ops.bind_vma = aliasing_gtt_bind_vma;
@@ -2582,14 +2582,14 @@ static int init_aliasing_ppgtt(struct drm_i915_private *i915)
return err;
}
-static void fini_aliasing_ppgtt(struct drm_i915_private *i915)
+static void fini_aliasing_ppgtt(struct i915_ggtt *ggtt)
{
- struct i915_ggtt *ggtt = &i915->ggtt;
+ struct drm_i915_private *i915 = ggtt->vm.i915;
struct i915_ppgtt *ppgtt;
mutex_lock(&i915->drm.struct_mutex);
- ppgtt = fetch_and_zero(&i915->mm.aliasing_ppgtt);
+ ppgtt = fetch_and_zero(&ggtt->alias);
if (!ppgtt)
goto out;
@@ -2706,7 +2706,7 @@ int i915_init_ggtt(struct drm_i915_private *i915)
return ret;
if (INTEL_PPGTT(i915) == INTEL_PPGTT_ALIASING) {
- ret = init_aliasing_ppgtt(i915);
+ ret = init_aliasing_ppgtt(&i915->ggtt);
if (ret)
cleanup_init_ggtt(&i915->ggtt);
}
@@ -2752,7 +2752,7 @@ void i915_ggtt_driver_release(struct drm_i915_private *i915)
{
struct pagevec *pvec;
- fini_aliasing_ppgtt(i915);
+ fini_aliasing_ppgtt(&i915->ggtt);
ggtt_cleanup_hw(&i915->ggtt);
@@ -3585,7 +3585,7 @@ int i915_gem_gtt_reserve(struct i915_address_space *vm,
GEM_BUG_ON(!IS_ALIGNED(size, I915_GTT_PAGE_SIZE));
GEM_BUG_ON(!IS_ALIGNED(offset, I915_GTT_MIN_ALIGNMENT));
GEM_BUG_ON(range_overflows(offset, size, vm->total));
- GEM_BUG_ON(vm == &vm->i915->mm.aliasing_ppgtt->vm);
+ GEM_BUG_ON(vm == &vm->i915->ggtt.alias->vm);
GEM_BUG_ON(drm_mm_node_allocated(node));
node->size = size;
@@ -3682,7 +3682,7 @@ int i915_gem_gtt_insert(struct i915_address_space *vm,
GEM_BUG_ON(start >= end);
GEM_BUG_ON(start > 0 && !IS_ALIGNED(start, I915_GTT_PAGE_SIZE));
GEM_BUG_ON(end < U64_MAX && !IS_ALIGNED(end, I915_GTT_PAGE_SIZE));
- GEM_BUG_ON(vm == &vm->i915->mm.aliasing_ppgtt->vm);
+ GEM_BUG_ON(vm == &vm->i915->ggtt.alias->vm);
GEM_BUG_ON(drm_mm_node_allocated(node));
if (unlikely(range_overflows(start, size, end)))
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
index cea59ef1a365..51274483502e 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.h
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
@@ -394,6 +394,9 @@ struct i915_ggtt {
void __iomem *gsm;
void (*invalidate)(struct i915_ggtt *ggtt);
+ /** PPGTT used for aliasing the PPGTT with the GTT */
+ struct i915_ppgtt *alias;
+
bool do_idle_maps;
int mtrr;
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index ee73baf29415..eb16a1a93bbc 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -104,7 +104,7 @@ vma_create(struct drm_i915_gem_object *obj,
struct rb_node *rb, **p;
/* The aliasing_ppgtt should never be used directly! */
- GEM_BUG_ON(vm == &vm->i915->mm.aliasing_ppgtt->vm);
+ GEM_BUG_ON(vm == &vm->i915->ggtt.alias->vm);
vma = i915_vma_alloc();
if (vma == NULL)
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/4] drm/i915/gt: Provde a local intel_context.vm
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
@ 2019-07-23 9:25 ` Chris Wilson
2019-07-23 9:25 ` [PATCH 3/4] drm/i915: Remove lrc default desc from GEM context Chris Wilson
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 9:25 UTC (permalink / raw)
To: intel-gfx
Track the currently bound address space used by the HW context. Minor
conversions to use the local intel_context.vm are made, leaving behind
some more surgery required to make intel_context the primary through the
selftests.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_client_blt.c | 4 +---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +++++++++++----
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 11 +++--------
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 6 +-----
.../gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
drivers/gpu/drm/i915/gt/intel_context.c | 4 ++++
drivers/gpu/drm/i915/gt/intel_context_types.h | 4 +++-
drivers/gpu/drm/i915/gt/intel_lrc.c | 9 +++------
drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 6 +++---
drivers/gpu/drm/i915/gvt/scheduler.c | 2 +-
10 files changed, 31 insertions(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c
index 6f537e8e4dea..2312a0c6af89 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_client_blt.c
@@ -250,13 +250,11 @@ int i915_gem_schedule_fill_pages_blt(struct drm_i915_gem_object *obj,
u32 value)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
- struct i915_gem_context *ctx = ce->gem_context;
- struct i915_address_space *vm = ctx->vm ?: &i915->ggtt.vm;
struct clear_pages_work *work;
struct i915_sleeve *sleeve;
int err;
- sleeve = create_sleeve(vm, obj, pages, page_sizes);
+ sleeve = create_sleeve(ce->vm, obj, pages, page_sizes);
if (IS_ERR(sleeve))
return PTR_ERR(sleeve);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 0f6b0678f548..b28c7ca681a8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -475,10 +475,18 @@ static struct i915_address_space *
__set_ppgtt(struct i915_gem_context *ctx, struct i915_address_space *vm)
{
struct i915_address_space *old = ctx->vm;
+ struct i915_gem_engines_iter it;
+ struct intel_context *ce;
ctx->vm = i915_vm_get(vm);
ctx->desc_template = default_desc_template(ctx->i915, vm);
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it) {
+ i915_vm_put(ce->vm);
+ ce->vm = i915_vm_get(vm);
+ }
+ i915_gem_context_unlock_engines(ctx);
+
return old;
}
@@ -1004,7 +1012,7 @@ static void set_ppgtt_barrier(void *data)
static int emit_ppgtt_update(struct i915_request *rq, void *data)
{
- struct i915_address_space *vm = rq->gem_context->vm;
+ struct i915_address_space *vm = rq->hw_context->vm;
struct intel_engine_cs *engine = rq->engine;
u32 base = engine->mmio_base;
u32 *cs;
@@ -1113,9 +1121,8 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
set_ppgtt_barrier,
old);
if (err) {
- ctx->vm = old;
- ctx->desc_template = default_desc_template(ctx->i915, old);
- i915_vm_put(vm);
+ i915_vm_put(__set_ppgtt(ctx, old));
+ i915_vm_put(old);
}
unlock:
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 8a2047c4e7c3..cbd7c6e3a1f8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -223,7 +223,6 @@ struct i915_execbuffer {
struct intel_engine_cs *engine; /** engine to queue the request to */
struct intel_context *context; /* logical state for the request */
struct i915_gem_context *gem_context; /** caller's context */
- struct i915_address_space *vm; /** GTT and vma for the request */
struct i915_request *request; /** our request to build */
struct i915_vma *batch; /** identity of the batch obj/vma */
@@ -697,7 +696,7 @@ static int eb_reserve(struct i915_execbuffer *eb)
case 1:
/* Too fragmented, unbind everything and retry */
- err = i915_gem_evict_vm(eb->vm);
+ err = i915_gem_evict_vm(eb->context->vm);
if (err)
return err;
break;
@@ -725,12 +724,8 @@ static int eb_select_context(struct i915_execbuffer *eb)
return -ENOENT;
eb->gem_context = ctx;
- if (ctx->vm) {
- eb->vm = ctx->vm;
+ if (ctx->vm)
eb->invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
- } else {
- eb->vm = &eb->i915->ggtt.vm;
- }
eb->context_flags = 0;
if (test_bit(UCONTEXT_NO_ZEROMAP, &ctx->user_flags))
@@ -832,7 +827,7 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
goto err_vma;
}
- vma = i915_vma_instance(obj, eb->vm, NULL);
+ vma = i915_vma_instance(obj, eb->context->vm, NULL);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
goto err_obj;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
index cb42e3a312e2..685064af32d1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
@@ -47,15 +47,11 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,
struct intel_context *ce,
u32 value)
{
- struct drm_i915_private *i915 = to_i915(obj->base.dev);
- struct i915_gem_context *ctx = ce->gem_context;
- struct i915_address_space *vm = ctx->vm ?: &i915->ggtt.vm;
struct i915_request *rq;
struct i915_vma *vma;
int err;
- /* XXX: ce->vm please */
- vma = i915_vma_instance(obj, vm, NULL);
+ vma = i915_vma_instance(obj, ce->vm, NULL);
if (IS_ERR(vma))
return PTR_ERR(vma);
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index bbd17d4b8ffd..7f9f6701b32c 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -747,7 +747,7 @@ emit_rpcs_query(struct drm_i915_gem_object *obj,
GEM_BUG_ON(!intel_engine_can_store_dword(ce->engine));
- vma = i915_vma_instance(obj, ce->gem_context->vm, NULL);
+ vma = i915_vma_instance(obj, ce->vm, NULL);
if (IS_ERR(vma))
return PTR_ERR(vma);
diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c
index 9292b6ca5e9c..9e4f51ce52ff 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.c
+++ b/drivers/gpu/drm/i915/gt/intel_context.c
@@ -191,6 +191,8 @@ intel_context_init(struct intel_context *ce,
kref_init(&ce->ref);
ce->gem_context = ctx;
+ ce->vm = i915_vm_get(ctx->vm ?: &engine->gt->ggtt->vm);
+
ce->engine = engine;
ce->ops = engine->cops;
ce->sseu = engine->sseu;
@@ -206,6 +208,8 @@ intel_context_init(struct intel_context *ce,
void intel_context_fini(struct intel_context *ce)
{
+ i915_vm_put(ce->vm);
+
mutex_destroy(&ce->pin_mutex);
i915_active_fini(&ce->active);
}
diff --git a/drivers/gpu/drm/i915/gt/intel_context_types.h b/drivers/gpu/drm/i915/gt/intel_context_types.h
index 4c0e211c715d..68a7e979b1a9 100644
--- a/drivers/gpu/drm/i915/gt/intel_context_types.h
+++ b/drivers/gpu/drm/i915/gt/intel_context_types.h
@@ -36,7 +36,6 @@ struct intel_context_ops {
struct intel_context {
struct kref ref;
- struct i915_gem_context *gem_context;
struct intel_engine_cs *engine;
struct intel_engine_cs *inflight;
#define intel_context_inflight(ce) ptr_mask_bits((ce)->inflight, 2)
@@ -44,6 +43,9 @@ struct intel_context {
#define intel_context_inflight_inc(ce) ptr_count_inc(&(ce)->inflight)
#define intel_context_inflight_dec(ce) ptr_count_dec(&(ce)->inflight)
+ struct i915_address_space *vm;
+ struct i915_gem_context *gem_context;
+
struct list_head signal_link;
struct list_head signals;
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 884dfc1cb033..632344c163a8 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -1606,8 +1606,6 @@ __execlists_context_pin(struct intel_context *ce,
void *vaddr;
int ret;
- GEM_BUG_ON(!ce->gem_context->vm);
-
ret = execlists_context_deferred_alloc(ce, engine);
if (ret)
goto err;
@@ -1717,8 +1715,7 @@ static int gen8_emit_init_breadcrumb(struct i915_request *rq)
static int emit_pdps(struct i915_request *rq)
{
const struct intel_engine_cs * const engine = rq->engine;
- struct i915_ppgtt * const ppgtt =
- i915_vm_to_ppgtt(rq->gem_context->vm);
+ struct i915_ppgtt * const ppgtt = i915_vm_to_ppgtt(rq->hw_context->vm);
int err, i;
u32 *cs;
@@ -1791,7 +1788,7 @@ static int execlists_request_alloc(struct i915_request *request)
*/
/* Unconditionally invalidate GPU caches and TLBs. */
- if (i915_vm_is_4lvl(request->gem_context->vm))
+ if (i915_vm_is_4lvl(request->hw_context->vm))
ret = request->engine->emit_flush(request, EMIT_INVALIDATE);
else
ret = emit_pdps(request);
@@ -2941,7 +2938,7 @@ static void execlists_init_reg_state(u32 *regs,
struct intel_engine_cs *engine,
struct intel_ring *ring)
{
- struct i915_ppgtt *ppgtt = i915_vm_to_ppgtt(ce->gem_context->vm);
+ struct i915_ppgtt *ppgtt = i915_vm_to_ppgtt(ce->vm);
bool rcs = engine->class == RENDER_CLASS;
u32 base = engine->mmio_base;
diff --git a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
index b056f25c66f2..38ec11ae6ed7 100644
--- a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
@@ -1396,9 +1396,9 @@ static struct i915_address_space *vm_alias(struct intel_context *ce)
{
struct i915_address_space *vm;
- vm = ce->gem_context->vm;
- if (!vm)
- vm = &ce->engine->gt->ggtt->alias->vm;
+ vm = ce->vm;
+ if (i915_is_ggtt(vm))
+ vm = &i915_vm_to_ggtt(vm)->alias->vm;
return vm;
}
diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 2144fb46d0e1..f68798ab1e7c 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -1156,7 +1156,7 @@ void intel_vgpu_clean_submission(struct intel_vgpu *vgpu)
intel_vgpu_select_submission_ops(vgpu, ALL_ENGINES, 0);
- i915_context_ppgtt_root_restore(s, i915_vm_to_ppgtt(s->shadow[0]->gem_context->vm));
+ i915_context_ppgtt_root_restore(s, i915_vm_to_ppgtt(s->shadow[0]->vm));
for_each_engine(engine, vgpu->gvt->dev_priv, id)
intel_context_unpin(s->shadow[id]);
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] drm/i915: Remove lrc default desc from GEM context
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
2019-07-23 9:25 ` [PATCH 2/4] drm/i915/gt: Provde a local intel_context.vm Chris Wilson
@ 2019-07-23 9:25 ` Chris Wilson
2019-07-23 9:25 ` [PATCH 4/4] drm/i915: Push the ring creation flags to the backend Chris Wilson
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 9:25 UTC (permalink / raw)
To: intel-gfx
We only compute the lrc_descriptor() on pinning the context, i.e.
infrequently, so we do not benefit from storing the template as the
addressing mode is also fixed for the lifetime of the intel_context.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 28 ++-----------------
.../gpu/drm/i915/gem/i915_gem_context_types.h | 2 --
drivers/gpu/drm/i915/gt/intel_lrc.c | 12 +++++---
drivers/gpu/drm/i915/gvt/scheduler.c | 3 --
4 files changed, 10 insertions(+), 35 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index b28c7ca681a8..1b3dc7258ef2 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -397,30 +397,6 @@ static void context_close(struct i915_gem_context *ctx)
i915_gem_context_put(ctx);
}
-static u32 default_desc_template(const struct drm_i915_private *i915,
- const struct i915_address_space *vm)
-{
- u32 address_mode;
- u32 desc;
-
- desc = GEN8_CTX_VALID | GEN8_CTX_PRIVILEGE;
-
- address_mode = INTEL_LEGACY_32B_CONTEXT;
- if (vm && i915_vm_is_4lvl(vm))
- address_mode = INTEL_LEGACY_64B_CONTEXT;
- desc |= address_mode << GEN8_CTX_ADDRESSING_MODE_SHIFT;
-
- if (IS_GEN(i915, 8))
- desc |= GEN8_CTX_L3LLC_COHERENT;
-
- /* TODO: WaDisableLiteRestore when we start using semaphore
- * signalling between Command Streamers
- * ring->ctx_desc_template |= GEN8_CTX_FORCE_RESTORE;
- */
-
- return desc;
-}
-
static struct i915_gem_context *
__create_context(struct drm_i915_private *i915)
{
@@ -459,7 +435,6 @@ __create_context(struct drm_i915_private *i915)
i915_gem_context_set_recoverable(ctx);
ctx->ring_size = 4 * PAGE_SIZE;
- ctx->desc_template = default_desc_template(i915, NULL);
for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp); i++)
ctx->hang_timestamp[i] = jiffies - CONTEXT_FAST_HANG_JIFFIES;
@@ -478,8 +453,9 @@ __set_ppgtt(struct i915_gem_context *ctx, struct i915_address_space *vm)
struct i915_gem_engines_iter it;
struct intel_context *ce;
+ GEM_BUG_ON(old && i915_vm_is_4lvl(vm) != i915_vm_is_4lvl(old));
+
ctx->vm = i915_vm_get(vm);
- ctx->desc_template = default_desc_template(ctx->i915, vm);
for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it) {
i915_vm_put(ce->vm);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index 0ee61482ef94..a02d98494078 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -171,8 +171,6 @@ struct i915_gem_context {
/** ring_size: size for allocating the per-engine ring buffer */
u32 ring_size;
- /** desc_template: invariant fields for the HW context descriptor */
- u32 desc_template;
/** guilty_count: How many times this context has caused a GPU hang. */
atomic_t guilty_count;
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 632344c163a8..5fdac40015cf 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -418,13 +418,17 @@ lrc_descriptor(struct intel_context *ce, struct intel_engine_cs *engine)
BUILD_BUG_ON(MAX_CONTEXT_HW_ID > (BIT(GEN8_CTX_ID_WIDTH)));
BUILD_BUG_ON(GEN11_MAX_CONTEXT_HW_ID > (BIT(GEN11_SW_CTX_ID_WIDTH)));
- desc = ctx->desc_template; /* bits 0-11 */
- GEM_BUG_ON(desc & GENMASK_ULL(63, 12));
+ desc = INTEL_LEGACY_32B_CONTEXT;
+ if (i915_vm_is_4lvl(ce->vm))
+ desc = INTEL_LEGACY_64B_CONTEXT;
+ desc <<= GEN8_CTX_ADDRESSING_MODE_SHIFT;
+
+ desc |= GEN8_CTX_VALID | GEN8_CTX_PRIVILEGE;
+ if (IS_GEN(engine->i915, 8))
+ desc |= GEN8_CTX_L3LLC_COHERENT;
desc |= i915_ggtt_offset(ce->state) + LRC_HEADER_PAGES * PAGE_SIZE;
/* bits 12-31 */
- GEM_BUG_ON(desc & GENMASK_ULL(63, 32));
-
/*
* The following 32bits are copied into the OA reports (dword 2).
* Consider updating oa_get_render_ctx_id in i915_perf.c when changing
diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index f68798ab1e7c..4c018fb1359c 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -291,9 +291,6 @@ shadow_context_descriptor_update(struct intel_context *ce,
* Update bits 0-11 of the context descriptor which includes flags
* like GEN8_CTX_* cached in desc_template
*/
- desc &= U64_MAX << 12;
- desc |= ce->gem_context->desc_template & ((1ULL << 12) - 1);
-
desc &= ~(0x3 << GEN8_CTX_ADDRESSING_MODE_SHIFT);
desc |= workload->ctx_desc.addressing_mode <<
GEN8_CTX_ADDRESSING_MODE_SHIFT;
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] drm/i915: Push the ring creation flags to the backend
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
2019-07-23 9:25 ` [PATCH 2/4] drm/i915/gt: Provde a local intel_context.vm Chris Wilson
2019-07-23 9:25 ` [PATCH 3/4] drm/i915: Remove lrc default desc from GEM context Chris Wilson
@ 2019-07-23 9:25 ` Chris Wilson
2019-07-23 12:28 ` [PATCH v2] " Chris Wilson
2019-07-23 12:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 9:25 UTC (permalink / raw)
To: intel-gfx
Push the ring creation flags from the outer GEM context to the inner
intel_cotnext to avoid an unsightly back-reference from inside the
backend.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 16 +++++++++++-----
.../gpu/drm/i915/gem/i915_gem_context_types.h | 3 ---
drivers/gpu/drm/i915/gt/intel_lrc.c | 5 ++---
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 1b3dc7258ef2..809400897322 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -296,6 +296,8 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx)
return ERR_CAST(ce);
}
+ ce->ring = (void *)SZ_16K;
+
e->engines[id] = ce;
}
e->num_engines = id;
@@ -434,8 +436,6 @@ __create_context(struct drm_i915_private *i915)
i915_gem_context_set_bannable(ctx);
i915_gem_context_set_recoverable(ctx);
- ctx->ring_size = 4 * PAGE_SIZE;
-
for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp); i++)
ctx->hang_timestamp[i] = jiffies - CONTEXT_FAST_HANG_JIFFIES;
@@ -565,8 +565,15 @@ i915_gem_context_create_gvt(struct drm_device *dev)
i915_gem_context_set_closed(ctx); /* not user accessible */
i915_gem_context_clear_bannable(ctx);
i915_gem_context_set_force_single_submission(ctx);
- if (!USES_GUC_SUBMISSION(to_i915(dev)))
- ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
+ if (!USES_GUC_SUBMISSION(to_i915(dev))) {
+ const unsigned long ring_size = 512 * SZ_4K; /* max */
+ struct i915_gem_engines_iter it;
+ struct intel_context *ce;
+
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
+ ce->ring = (void *)ring_size;
+ i915_gem_context_unlock_engines(ctx);
+ }
GEM_BUG_ON(i915_gem_context_is_kernel(ctx));
out:
@@ -605,7 +612,6 @@ i915_gem_context_create_kernel(struct drm_i915_private *i915, int prio)
i915_gem_context_clear_bannable(ctx);
ctx->sched.priority = I915_USER_PRIORITY(prio);
- ctx->ring_size = PAGE_SIZE;
GEM_BUG_ON(!i915_gem_context_is_kernel(ctx));
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index a02d98494078..260d59cc3de8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -169,9 +169,6 @@ struct i915_gem_context {
struct i915_sched_attr sched;
- /** ring_size: size for allocating the per-engine ring buffer */
- u32 ring_size;
-
/** guilty_count: How many times this context has caused a GPU hang. */
atomic_t guilty_count;
/**
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 5fdac40015cf..3f1b20cc50c2 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3140,9 +3140,8 @@ static int execlists_context_deferred_alloc(struct intel_context *ce,
goto error_deref_obj;
}
- ring = intel_engine_create_ring(engine,
- timeline,
- ce->gem_context->ring_size);
+ ring = intel_engine_create_ring(engine, timeline,
+ (unsigned long)ce->ring);
intel_timeline_put(timeline);
if (IS_ERR(ring)) {
ret = PTR_ERR(ring);
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
` (2 preceding siblings ...)
2019-07-23 9:25 ` [PATCH 4/4] drm/i915: Push the ring creation flags to the backend Chris Wilson
@ 2019-07-23 12:15 ` Patchwork
2019-07-23 13:40 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-07-23 12:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
URL : https://patchwork.freedesktop.org/series/64068/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6539 -> Patchwork_13721
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13721 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13721, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13721:
### IGT changes ###
#### Possible regressions ####
* igt@debugfs_test@read_all_entries:
- fi-ivb-3770: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
- fi-hsw-peppy: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
- fi-bdw-gvtdvm: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bdw-gvtdvm/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bdw-gvtdvm/igt@debugfs_test@read_all_entries.html
- fi-kbl-7500u: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
- fi-snb-2520m: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
- fi-ilk-650: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-ilk-650/igt@debugfs_test@read_all_entries.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-ilk-650/igt@debugfs_test@read_all_entries.html
- fi-hsw-4770r: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-hsw-4770r/igt@debugfs_test@read_all_entries.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-hsw-4770r/igt@debugfs_test@read_all_entries.html
- fi-kbl-guc: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
- fi-bsw-kefka: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
- fi-kbl-x1275: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
- fi-blb-e6850: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
- fi-bwr-2160: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
- fi-bdw-5557u: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
- fi-kbl-r: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-kbl-r/igt@debugfs_test@read_all_entries.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-r/igt@debugfs_test@read_all_entries.html
- fi-kbl-7567u: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-kbl-7567u/igt@debugfs_test@read_all_entries.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-7567u/igt@debugfs_test@read_all_entries.html
- fi-kbl-8809g: NOTRUN -> [INCOMPLETE][31]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
- fi-cfl-8700k: [PASS][32] -> [INCOMPLETE][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
- fi-whl-u: [PASS][34] -> [INCOMPLETE][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-whl-u/igt@debugfs_test@read_all_entries.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-whl-u/igt@debugfs_test@read_all_entries.html
- fi-bsw-n3050: [PASS][36] -> [INCOMPLETE][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
- fi-hsw-4770: [PASS][38] -> [INCOMPLETE][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
- fi-cfl-guc: [PASS][40] -> [INCOMPLETE][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
Known issues
------------
Here are the changes found in Patchwork_13721 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-skl-iommu: [PASS][42] -> [INCOMPLETE][43] ([fdo#108901])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
- fi-glk-dsi: [PASS][44] -> [INCOMPLETE][45] ([fdo#103359] / [k.org#198133])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
- fi-cml-u: [PASS][46] -> [INCOMPLETE][47] ([fdo#110566])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-cml-u/igt@debugfs_test@read_all_entries.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-cml-u/igt@debugfs_test@read_all_entries.html
- fi-icl-u3: [PASS][48] -> [INCOMPLETE][49] ([fdo#107713])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-icl-u3/igt@debugfs_test@read_all_entries.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-icl-u3/igt@debugfs_test@read_all_entries.html
- fi-bxt-j4205: [PASS][50] -> [INCOMPLETE][51] ([fdo#103927])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bxt-j4205/igt@debugfs_test@read_all_entries.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bxt-j4205/igt@debugfs_test@read_all_entries.html
- fi-gdg-551: [PASS][52] -> [INCOMPLETE][53] ([fdo#108316])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-gdg-551/igt@debugfs_test@read_all_entries.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-gdg-551/igt@debugfs_test@read_all_entries.html
- fi-icl-u2: [PASS][54] -> [INCOMPLETE][55] ([fdo#107713])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-icl-u2/igt@debugfs_test@read_all_entries.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-icl-u2/igt@debugfs_test@read_all_entries.html
- fi-skl-6770hq: [PASS][56] -> [INCOMPLETE][57] ([fdo#108901])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
- fi-byt-n2820: [PASS][58] -> [INCOMPLETE][59] ([fdo#102657])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
- fi-elk-e7500: [PASS][60] -> [INCOMPLETE][61] ([fdo#103989])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
- fi-skl-lmem: [PASS][62] -> [INCOMPLETE][63] ([fdo#108901])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
- fi-skl-6260u: [PASS][64] -> [INCOMPLETE][65] ([fdo#108901])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-6260u/igt@debugfs_test@read_all_entries.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-6260u/igt@debugfs_test@read_all_entries.html
- fi-snb-2600: [PASS][66] -> [INCOMPLETE][67] ([fdo#105411])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-snb-2600/igt@debugfs_test@read_all_entries.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-snb-2600/igt@debugfs_test@read_all_entries.html
- fi-skl-gvtdvm: [PASS][68] -> [INCOMPLETE][69] ([fdo#108901])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-gvtdvm/igt@debugfs_test@read_all_entries.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-gvtdvm/igt@debugfs_test@read_all_entries.html
- fi-skl-guc: [PASS][70] -> [INCOMPLETE][71] ([fdo#108901])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-guc/igt@debugfs_test@read_all_entries.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-guc/igt@debugfs_test@read_all_entries.html
- fi-apl-guc: [PASS][72] -> [INCOMPLETE][73] ([fdo#103927])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-apl-guc/igt@debugfs_test@read_all_entries.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-apl-guc/igt@debugfs_test@read_all_entries.html
- fi-skl-6600u: [PASS][74] -> [INCOMPLETE][75] ([fdo#108901])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
- fi-byt-j1900: [PASS][76] -> [INCOMPLETE][77] ([fdo#102657])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
- fi-bxt-dsi: [PASS][78] -> [INCOMPLETE][79] ([fdo#103927])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
- fi-cml-u2: [PASS][80] -> [INCOMPLETE][81] ([fdo#110566])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-cml-u2/igt@debugfs_test@read_all_entries.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-cml-u2/igt@debugfs_test@read_all_entries.html
- fi-skl-6700k2: [PASS][82] -> [INCOMPLETE][83] ([fdo#108901])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
- fi-icl-guc: [PASS][84] -> [INCOMPLETE][85] ([fdo#107713])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6539/fi-icl-guc/igt@debugfs_test@read_all_entries.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/fi-icl-guc/igt@debugfs_test@read_all_entries.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#103989]: https://bugs.freedesktop.org/show_bug.cgi?id=103989
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108316]: https://bugs.freedesktop.org/show_bug.cgi?id=108316
[fdo#108901]: https://bugs.freedesktop.org/show_bug.cgi?id=108901
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (53 -> 44)
------------------------------
Additional (1): fi-kbl-8809g
Missing (10): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-cfl-8109u fi-pnv-d510 fi-icl-y fi-icl-dsi fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6539 -> Patchwork_13721
CI-20190529: 20190529
CI_DRM_6539: eb32ea98a6fe6d924f28f8b8f3ee43b9e56bf12e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13721: 8e47a57f2dfc1ebd548f9165eac04a2d2262af7e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8e47a57f2dfc drm/i915: Push the ring creation flags to the backend
1704e2c77720 drm/i915: Remove lrc default desc from GEM context
ea1161b79f45 drm/i915/gt: Provde a local intel_context.vm
dbe5c820b3da drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13721/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] drm/i915: Push the ring creation flags to the backend
2019-07-23 9:25 ` [PATCH 4/4] drm/i915: Push the ring creation flags to the backend Chris Wilson
@ 2019-07-23 12:28 ` Chris Wilson
2019-07-23 14:22 ` [PATCH v3] " Chris Wilson
0 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 12:28 UTC (permalink / raw)
To: intel-gfx
Push the ring creation flags from the outer GEM context to the inner
intel_cotnext to avoid an unsightly back-reference from inside the
backend.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 16 +++++++++----
.../gpu/drm/i915/gem/i915_gem_context_types.h | 3 ---
drivers/gpu/drm/i915/gt/intel_lrc.c | 5 ++--
drivers/gpu/drm/i915/i915_debugfs.c | 23 ++++++++++++-------
4 files changed, 28 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 1b3dc7258ef2..809400897322 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -296,6 +296,8 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx)
return ERR_CAST(ce);
}
+ ce->ring = (void *)SZ_16K;
+
e->engines[id] = ce;
}
e->num_engines = id;
@@ -434,8 +436,6 @@ __create_context(struct drm_i915_private *i915)
i915_gem_context_set_bannable(ctx);
i915_gem_context_set_recoverable(ctx);
- ctx->ring_size = 4 * PAGE_SIZE;
-
for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp); i++)
ctx->hang_timestamp[i] = jiffies - CONTEXT_FAST_HANG_JIFFIES;
@@ -565,8 +565,15 @@ i915_gem_context_create_gvt(struct drm_device *dev)
i915_gem_context_set_closed(ctx); /* not user accessible */
i915_gem_context_clear_bannable(ctx);
i915_gem_context_set_force_single_submission(ctx);
- if (!USES_GUC_SUBMISSION(to_i915(dev)))
- ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
+ if (!USES_GUC_SUBMISSION(to_i915(dev))) {
+ const unsigned long ring_size = 512 * SZ_4K; /* max */
+ struct i915_gem_engines_iter it;
+ struct intel_context *ce;
+
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
+ ce->ring = (void *)ring_size;
+ i915_gem_context_unlock_engines(ctx);
+ }
GEM_BUG_ON(i915_gem_context_is_kernel(ctx));
out:
@@ -605,7 +612,6 @@ i915_gem_context_create_kernel(struct drm_i915_private *i915, int prio)
i915_gem_context_clear_bannable(ctx);
ctx->sched.priority = I915_USER_PRIORITY(prio);
- ctx->ring_size = PAGE_SIZE;
GEM_BUG_ON(!i915_gem_context_is_kernel(ctx));
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index a02d98494078..260d59cc3de8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -169,9 +169,6 @@ struct i915_gem_context {
struct i915_sched_attr sched;
- /** ring_size: size for allocating the per-engine ring buffer */
- u32 ring_size;
-
/** guilty_count: How many times this context has caused a GPU hang. */
atomic_t guilty_count;
/**
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 5fdac40015cf..3f1b20cc50c2 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3140,9 +3140,8 @@ static int execlists_context_deferred_alloc(struct intel_context *ce,
goto error_deref_obj;
}
- ring = intel_engine_create_ring(engine,
- timeline,
- ce->gem_context->ring_size);
+ ring = intel_engine_create_ring(engine, timeline,
+ (unsigned long)ce->ring);
intel_timeline_put(timeline);
if (IS_ERR(ring)) {
ret = PTR_ERR(ring);
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 6d3911469801..e237bcecfa1f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -328,10 +328,14 @@ static void print_context_stats(struct seq_file *m,
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
- if (ce->state)
- per_file_stats(0, ce->state->obj, &kstats);
- if (ce->ring)
+ intel_context_lock_pinned(ce);
+ if (intel_context_is_pinned(ce)) {
+ if (ce->state)
+ per_file_stats(0,
+ ce->state->obj, &kstats);
per_file_stats(0, ce->ring->vma->obj, &kstats);
+ }
+ intel_context_unlock_pinned(ce);
}
i915_gem_context_unlock_engines(ctx);
@@ -1677,12 +1681,15 @@ static int i915_context_status(struct seq_file *m, void *unused)
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
- seq_printf(m, "%s: ", ce->engine->name);
- if (ce->state)
- describe_obj(m, ce->state->obj);
- if (ce->ring)
+ intel_context_lock_pinned(ce);
+ if (intel_context_is_pinned(ce)) {
+ seq_printf(m, "%s: ", ce->engine->name);
+ if (ce->state)
+ describe_obj(m, ce->state->obj);
describe_ctx_ring(m, ce->ring);
- seq_putc(m, '\n');
+ seq_putc(m, '\n');
+ }
+ intel_context_unlock_pinned(ce);
}
i915_gem_context_unlock_engines(ctx);
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2)
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
` (3 preceding siblings ...)
2019-07-23 12:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
@ 2019-07-23 13:40 ` Patchwork
2019-07-23 15:57 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3) Patchwork
2019-07-23 20:52 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-07-23 13:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2)
URL : https://patchwork.freedesktop.org/series/64068/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6540 -> Patchwork_13724
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13724 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13724, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13724:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@busy-all:
- fi-bdw-5557u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bdw-5557u/igt@gem_busy@busy-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bdw-5557u/igt@gem_busy@busy-all.html
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bsw-kefka/igt@gem_busy@busy-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bsw-kefka/igt@gem_busy@busy-all.html
- fi-kbl-guc: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-guc/igt@gem_busy@busy-all.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-guc/igt@gem_busy@busy-all.html
- fi-kbl-7500u: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-7500u/igt@gem_busy@busy-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-7500u/igt@gem_busy@busy-all.html
- fi-cfl-8700k: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-cfl-8700k/igt@gem_busy@busy-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-8700k/igt@gem_busy@busy-all.html
- fi-skl-guc: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-guc/igt@gem_busy@busy-all.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-guc/igt@gem_busy@busy-all.html
- fi-cfl-guc: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-cfl-guc/igt@gem_busy@busy-all.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-guc/igt@gem_busy@busy-all.html
- fi-bdw-gvtdvm: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bdw-gvtdvm/igt@gem_busy@busy-all.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bdw-gvtdvm/igt@gem_busy@busy-all.html
- fi-bsw-n3050: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bsw-n3050/igt@gem_busy@busy-all.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bsw-n3050/igt@gem_busy@busy-all.html
- fi-skl-gvtdvm: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-gvtdvm/igt@gem_busy@busy-all.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-gvtdvm/igt@gem_busy@busy-all.html
- fi-skl-6260u: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-6260u/igt@gem_busy@busy-all.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-6260u/igt@gem_busy@busy-all.html
- fi-skl-lmem: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-lmem/igt@gem_busy@busy-all.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-lmem/igt@gem_busy@busy-all.html
- fi-kbl-8809g: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-8809g/igt@gem_busy@busy-all.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-8809g/igt@gem_busy@busy-all.html
- fi-skl-6770hq: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-6770hq/igt@gem_busy@busy-all.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-6770hq/igt@gem_busy@busy-all.html
- fi-kbl-r: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-r/igt@gem_busy@busy-all.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-r/igt@gem_busy@busy-all.html
- fi-kbl-x1275: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-x1275/igt@gem_busy@busy-all.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-x1275/igt@gem_busy@busy-all.html
- fi-skl-6600u: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-6600u/igt@gem_busy@busy-all.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-6600u/igt@gem_busy@busy-all.html
- fi-kbl-7567u: [PASS][35] -> [INCOMPLETE][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-kbl-7567u/igt@gem_busy@busy-all.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-7567u/igt@gem_busy@busy-all.html
- fi-skl-iommu: [PASS][37] -> [INCOMPLETE][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-iommu/igt@gem_busy@busy-all.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-iommu/igt@gem_busy@busy-all.html
- fi-skl-6700k2: [PASS][39] -> [INCOMPLETE][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-skl-6700k2/igt@gem_busy@busy-all.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-skl-6700k2/igt@gem_busy@busy-all.html
- fi-whl-u: [PASS][41] -> [INCOMPLETE][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-whl-u/igt@gem_busy@busy-all.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-whl-u/igt@gem_busy@busy-all.html
- fi-cfl-8109u: NOTRUN -> [INCOMPLETE][43]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-8109u/igt@gem_busy@busy-all.html
* igt@runner@aborted:
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][44]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bdw-gvtdvm/igt@runner@aborted.html
- fi-cfl-8109u: NOTRUN -> [FAIL][45]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-8109u/igt@runner@aborted.html
- fi-kbl-7500u: NOTRUN -> [FAIL][46]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-7500u/igt@runner@aborted.html
- fi-bxt-j4205: NOTRUN -> [FAIL][47]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bxt-j4205/igt@runner@aborted.html
- fi-whl-u: NOTRUN -> [FAIL][48]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-whl-u/igt@runner@aborted.html
- fi-cml-u2: NOTRUN -> [FAIL][49]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cml-u2/igt@runner@aborted.html
- fi-cml-u: NOTRUN -> [FAIL][50]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cml-u/igt@runner@aborted.html
- fi-bxt-dsi: NOTRUN -> [FAIL][51]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bxt-dsi/igt@runner@aborted.html
- fi-cfl-guc: NOTRUN -> [FAIL][52]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-guc/igt@runner@aborted.html
- fi-kbl-7567u: NOTRUN -> [FAIL][53]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-7567u/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][54]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bsw-n3050/igt@runner@aborted.html
- fi-kbl-x1275: NOTRUN -> [FAIL][55]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-x1275/igt@runner@aborted.html
- fi-bsw-kefka: NOTRUN -> [FAIL][56]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bsw-kefka/igt@runner@aborted.html
- fi-cfl-8700k: NOTRUN -> [FAIL][57]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cfl-8700k/igt@runner@aborted.html
- fi-kbl-8809g: NOTRUN -> [FAIL][58]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-8809g/igt@runner@aborted.html
- fi-kbl-r: NOTRUN -> [FAIL][59]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-r/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][60]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bdw-5557u/igt@runner@aborted.html
- fi-kbl-guc: NOTRUN -> [FAIL][61]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-kbl-guc/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_13724 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-all:
- fi-icl-guc: [PASS][62] -> [INCOMPLETE][63] ([fdo#107713])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-icl-guc/igt@gem_busy@busy-all.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-icl-guc/igt@gem_busy@busy-all.html
- fi-glk-dsi: [PASS][64] -> [INCOMPLETE][65] ([fdo#103359] / [k.org#198133])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-glk-dsi/igt@gem_busy@busy-all.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-glk-dsi/igt@gem_busy@busy-all.html
- fi-bxt-j4205: [PASS][66] -> [INCOMPLETE][67] ([fdo#103927])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bxt-j4205/igt@gem_busy@busy-all.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bxt-j4205/igt@gem_busy@busy-all.html
- fi-icl-u3: [PASS][68] -> [INCOMPLETE][69] ([fdo#107713])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-icl-u3/igt@gem_busy@busy-all.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-icl-u3/igt@gem_busy@busy-all.html
- fi-cml-u2: [PASS][70] -> [INCOMPLETE][71] ([fdo#110566])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-cml-u2/igt@gem_busy@busy-all.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-cml-u2/igt@gem_busy@busy-all.html
- fi-bxt-dsi: [PASS][72] -> [INCOMPLETE][73] ([fdo#103927])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bxt-dsi/igt@gem_busy@busy-all.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bxt-dsi/igt@gem_busy@busy-all.html
- fi-icl-dsi: [PASS][74] -> [INCOMPLETE][75] ([fdo#107713])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-icl-dsi/igt@gem_busy@busy-all.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-icl-dsi/igt@gem_busy@busy-all.html
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][76] -> [INCOMPLETE][77] ([fdo#107718])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-bwr-2160: [DMESG-WARN][78] ([fdo#111115]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bwr-2160/igt@i915_selftest@live_execlists.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bwr-2160/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: [DMESG-FAIL][80] ([fdo#111115]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6540/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (54 -> 45)
------------------------------
Additional (2): fi-cfl-8109u fi-pnv-d510
Missing (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-apl-guc fi-ctg-p8600 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6540 -> Patchwork_13724
CI-20190529: 20190529
CI_DRM_6540: 23b909d90e1203a172548f7fc0328baea0e39648 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13724: 32bab451d5160167adc989f8f7d55e298f2f9699 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
32bab451d516 drm/i915: Push the ring creation flags to the backend
f8295275a93d drm/i915: Remove lrc default desc from GEM context
610e130927c9 drm/i915/gt: Provde a local intel_context.vm
761e894abbfb drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13724/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] drm/i915: Push the ring creation flags to the backend
2019-07-23 12:28 ` [PATCH v2] " Chris Wilson
@ 2019-07-23 14:22 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-07-23 14:22 UTC (permalink / raw)
To: intel-gfx
Push the ring creation flags from the outer GEM context to the inner
intel_cotnext to avoid an unsightly back-reference from inside the
backend.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 25 +++++++++++++------
.../gpu/drm/i915/gem/i915_gem_context_types.h | 3 ---
drivers/gpu/drm/i915/gt/intel_context.c | 1 +
drivers/gpu/drm/i915/gt/intel_context.h | 5 ++++
drivers/gpu/drm/i915/gt/intel_lrc.c | 5 ++--
drivers/gpu/drm/i915/i915_debugfs.c | 23 +++++++++++------
6 files changed, 41 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 1b3dc7258ef2..18b226bc5e3a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -296,6 +296,8 @@ static struct i915_gem_engines *default_engines(struct i915_gem_context *ctx)
return ERR_CAST(ce);
}
+ ce->ring = __intel_context_ring_size(SZ_16K);
+
e->engines[id] = ce;
}
e->num_engines = id;
@@ -434,8 +436,6 @@ __create_context(struct drm_i915_private *i915)
i915_gem_context_set_bannable(ctx);
i915_gem_context_set_recoverable(ctx);
- ctx->ring_size = 4 * PAGE_SIZE;
-
for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp); i++)
ctx->hang_timestamp[i] = jiffies - CONTEXT_FAST_HANG_JIFFIES;
@@ -565,8 +565,15 @@ i915_gem_context_create_gvt(struct drm_device *dev)
i915_gem_context_set_closed(ctx); /* not user accessible */
i915_gem_context_clear_bannable(ctx);
i915_gem_context_set_force_single_submission(ctx);
- if (!USES_GUC_SUBMISSION(to_i915(dev)))
- ctx->ring_size = 512 * PAGE_SIZE; /* Max ring buffer size */
+ if (!USES_GUC_SUBMISSION(to_i915(dev))) {
+ const unsigned long ring_size = 512 * SZ_4K; /* max */
+ struct i915_gem_engines_iter it;
+ struct intel_context *ce;
+
+ for_each_gem_engine(ce, i915_gem_context_lock_engines(ctx), it)
+ ce->ring = __intel_context_ring_size(ring_size);
+ i915_gem_context_unlock_engines(ctx);
+ }
GEM_BUG_ON(i915_gem_context_is_kernel(ctx));
out:
@@ -605,7 +612,6 @@ i915_gem_context_create_kernel(struct drm_i915_private *i915, int prio)
i915_gem_context_clear_bannable(ctx);
ctx->sched.priority = I915_USER_PRIORITY(prio);
- ctx->ring_size = PAGE_SIZE;
GEM_BUG_ON(!i915_gem_context_is_kernel(ctx));
@@ -1589,6 +1595,7 @@ set_engines(struct i915_gem_context *ctx,
for (n = 0; n < num_engines; n++) {
struct i915_engine_class_instance ci;
struct intel_engine_cs *engine;
+ struct intel_context *ce;
if (copy_from_user(&ci, &user->engines[n], sizeof(ci))) {
__free_engines(set.engines, n);
@@ -1611,11 +1618,15 @@ set_engines(struct i915_gem_context *ctx,
return -ENOENT;
}
- set.engines->engines[n] = intel_context_create(ctx, engine);
- if (!set.engines->engines[n]) {
+ ce = intel_context_create(ctx, engine);
+ if (!ce) {
__free_engines(set.engines, n);
return -ENOMEM;
}
+
+ ce->ring = __intel_context_ring_size(SZ_16K);
+
+ set.engines->engines[n] = ce;
}
set.engines->num_engines = num_engines;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
index a02d98494078..260d59cc3de8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h
@@ -169,9 +169,6 @@ struct i915_gem_context {
struct i915_sched_attr sched;
- /** ring_size: size for allocating the per-engine ring buffer */
- u32 ring_size;
-
/** guilty_count: How many times this context has caused a GPU hang. */
atomic_t guilty_count;
/**
diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c
index 9e4f51ce52ff..295fa0ddbcac 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.c
+++ b/drivers/gpu/drm/i915/gt/intel_context.c
@@ -196,6 +196,7 @@ intel_context_init(struct intel_context *ce,
ce->engine = engine;
ce->ops = engine->cops;
ce->sseu = engine->sseu;
+ ce->ring = __intel_context_ring_size(SZ_4K);
INIT_LIST_HEAD(&ce->signal_link);
INIT_LIST_HEAD(&ce->signals);
diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h
index 23c7e4c0ce7c..3f54eb3d10ab 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.h
+++ b/drivers/gpu/drm/i915/gt/intel_context.h
@@ -145,4 +145,9 @@ int intel_context_prepare_remote_request(struct intel_context *ce,
struct i915_request *intel_context_create_request(struct intel_context *ce);
+static inline struct intel_ring *__intel_context_ring_size(u64 sz)
+{
+ return u64_to_ptr(struct intel_ring, sz);
+}
+
#endif /* __INTEL_CONTEXT_H__ */
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 5fdac40015cf..3f1b20cc50c2 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3140,9 +3140,8 @@ static int execlists_context_deferred_alloc(struct intel_context *ce,
goto error_deref_obj;
}
- ring = intel_engine_create_ring(engine,
- timeline,
- ce->gem_context->ring_size);
+ ring = intel_engine_create_ring(engine, timeline,
+ (unsigned long)ce->ring);
intel_timeline_put(timeline);
if (IS_ERR(ring)) {
ret = PTR_ERR(ring);
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 6d3911469801..e237bcecfa1f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -328,10 +328,14 @@ static void print_context_stats(struct seq_file *m,
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
- if (ce->state)
- per_file_stats(0, ce->state->obj, &kstats);
- if (ce->ring)
+ intel_context_lock_pinned(ce);
+ if (intel_context_is_pinned(ce)) {
+ if (ce->state)
+ per_file_stats(0,
+ ce->state->obj, &kstats);
per_file_stats(0, ce->ring->vma->obj, &kstats);
+ }
+ intel_context_unlock_pinned(ce);
}
i915_gem_context_unlock_engines(ctx);
@@ -1677,12 +1681,15 @@ static int i915_context_status(struct seq_file *m, void *unused)
for_each_gem_engine(ce,
i915_gem_context_lock_engines(ctx), it) {
- seq_printf(m, "%s: ", ce->engine->name);
- if (ce->state)
- describe_obj(m, ce->state->obj);
- if (ce->ring)
+ intel_context_lock_pinned(ce);
+ if (intel_context_is_pinned(ce)) {
+ seq_printf(m, "%s: ", ce->engine->name);
+ if (ce->state)
+ describe_obj(m, ce->state->obj);
describe_ctx_ring(m, ce->ring);
- seq_putc(m, '\n');
+ seq_putc(m, '\n');
+ }
+ intel_context_unlock_pinned(ce);
}
i915_gem_context_unlock_engines(ctx);
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3)
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
` (4 preceding siblings ...)
2019-07-23 13:40 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2) Patchwork
@ 2019-07-23 15:57 ` Patchwork
2019-07-23 20:52 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-07-23 15:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3)
URL : https://patchwork.freedesktop.org/series/64068/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6541 -> Patchwork_13727
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/
Known issues
------------
Here are the changes found in Patchwork_13727 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-icl-u3/igt@core_auth@basic-auth.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-icl-u3/igt@core_auth@basic-auth.html
* igt@i915_selftest@live_execlists:
- fi-bwr-2160: [PASS][3] -> [DMESG-WARN][4] ([fdo#111115])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-bwr-2160/igt@i915_selftest@live_execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-bwr-2160/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111115])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html
- fi-icl-u2: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713] / [fdo#108569])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: [PASS][9] -> [SKIP][10] ([fdo#109271] / [fdo#109278]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
* igt@kms_busy@basic-flip-c:
- fi-kbl-7500u: [PASS][11] -> [SKIP][12] ([fdo#109271] / [fdo#109278]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][13] -> [FAIL][14] ([fdo#109485])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: [DMESG-WARN][15] ([fdo#105128] / [fdo#107139]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: [WARN][17] ([fdo#109380]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-7567u: [SKIP][19] ([fdo#109271]) -> [PASS][20] +23 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115
Participating hosts (54 -> 45)
------------------------------
Additional (1): fi-icl-dsi
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-icl-y fi-icl-guc fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6541 -> Patchwork_13727
CI-20190529: 20190529
CI_DRM_6541: 9f1fa88f2b89b7ee8789cd51f8762a947719d574 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13727: d9515951e9d931f841373111718212e4d7adb15c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d9515951e9d9 drm/i915: Push the ring creation flags to the backend
98aa69315b60 drm/i915: Remove lrc default desc from GEM context
bc3cb3d9838a drm/i915/gt: Provde a local intel_context.vm
dca2c74063ed drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3)
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
` (5 preceding siblings ...)
2019-07-23 15:57 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3) Patchwork
@ 2019-07-23 20:52 ` Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-07-23 20:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3)
URL : https://patchwork.freedesktop.org/series/64068/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6541_full -> Patchwork_13727_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13727_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13727_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13727_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_balancer@busy:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-apl3/igt@gem_exec_balancer@busy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-apl5/igt@gem_exec_balancer@busy.html
* igt@i915_selftest@mock_timelines:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl4/igt@i915_selftest@mock_timelines.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl1/igt@i915_selftest@mock_timelines.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-glk: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-glk6/igt@kms_color@pipe-a-ctm-red-to-blue.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-glk4/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@runner@aborted:
- shard-hsw: NOTRUN -> [FAIL][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-hsw6/igt@runner@aborted.html
- shard-kbl: NOTRUN -> [FAIL][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl2/igt@runner@aborted.html
- shard-apl: NOTRUN -> [FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-apl5/igt@runner@aborted.html
- shard-snb: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-snb6/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_13727_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-glk: [PASS][11] -> [FAIL][12] ([fdo#109661])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-glk9/igt@gem_eio@reset-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-glk9/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@busy:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#110946])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb7/igt@gem_exec_balancer@busy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb8/igt@gem_exec_balancer@busy.html
- shard-kbl: [PASS][15] -> [FAIL][16] ([fdo#110946])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-kbl3/igt@gem_exec_balancer@busy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl3/igt@gem_exec_balancer@busy.html
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#110946])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl4/igt@gem_exec_balancer@busy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl4/igt@gem_exec_balancer@busy.html
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#110946])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-glk1/igt@gem_exec_balancer@busy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-glk7/igt@gem_exec_balancer@busy.html
* igt@i915_selftest@mock_timelines:
- shard-glk: [PASS][21] -> [INCOMPLETE][22] ([fdo#103359] / [k.org#198133])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-glk3/igt@i915_selftest@mock_timelines.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-glk3/igt@i915_selftest@mock_timelines.html
- shard-hsw: [PASS][23] -> [INCOMPLETE][24] ([fdo#103540])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-hsw6/igt@i915_selftest@mock_timelines.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-hsw6/igt@i915_selftest@mock_timelines.html
- shard-kbl: [PASS][25] -> [INCOMPLETE][26] ([fdo#103665])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-kbl2/igt@i915_selftest@mock_timelines.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl2/igt@i915_selftest@mock_timelines.html
- shard-iclb: [PASS][27] -> [INCOMPLETE][28] ([fdo#107713])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb6/igt@i915_selftest@mock_timelines.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb4/igt@i915_selftest@mock_timelines.html
- shard-snb: [PASS][29] -> [INCOMPLETE][30] ([fdo#105411])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-snb2/igt@i915_selftest@mock_timelines.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-snb6/igt@i915_selftest@mock_timelines.html
- shard-apl: [PASS][31] -> [INCOMPLETE][32] ([fdo#103927])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-apl5/igt@i915_selftest@mock_timelines.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-apl5/igt@i915_selftest@mock_timelines.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][33] -> [FAIL][34] ([fdo#105363])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@dpms-vs-vblank-race:
- shard-kbl: [PASS][35] -> [FAIL][36] ([fdo#103060])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-kbl7/igt@kms_flip@dpms-vs-vblank-race.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl7/igt@kms_flip@dpms-vs-vblank-race.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][37] -> [FAIL][38] ([fdo#103167]) +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][39] -> [DMESG-WARN][40] ([fdo#108566]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][43] -> [FAIL][44] ([fdo#99912])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-apl1/igt@kms_setmode@basic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-apl3/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][45] -> [DMESG-WARN][46] ([fdo#108566]) +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [INCOMPLETE][47] ([fdo#104108] / [fdo#107807]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl2/igt@i915_pm_rpm@system-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl9/igt@i915_pm_rpm@system-suspend.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [INCOMPLETE][49] ([fdo#110741]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-snb: [SKIP][51] ([fdo#109271]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][53] ([fdo#105767]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][55] ([fdo#103167]) -> [PASS][56] +10 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][57] ([fdo#108566]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][59] ([fdo#108145]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][61] ([fdo#103166]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][63] ([fdo#108341]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb1/igt@kms_psr@no_drrs.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb7/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-skl: [FAIL][67] ([fdo#103167]) -> [FAIL][68] ([fdo#108040])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6541/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6541 -> Patchwork_13727
CI-20190529: 20190529
CI_DRM_6541: 9f1fa88f2b89b7ee8789cd51f8762a947719d574 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5107: 1a5b48671e0863cb723e3d0239e54c828360dc99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13727: d9515951e9d931f841373111718212e4d7adb15c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13727/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-07-23 20:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 9:25 [PATCH 1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
2019-07-23 9:25 ` [PATCH 2/4] drm/i915/gt: Provde a local intel_context.vm Chris Wilson
2019-07-23 9:25 ` [PATCH 3/4] drm/i915: Remove lrc default desc from GEM context Chris Wilson
2019-07-23 9:25 ` [PATCH 4/4] drm/i915: Push the ring creation flags to the backend Chris Wilson
2019-07-23 12:28 ` [PATCH v2] " Chris Wilson
2019-07-23 14:22 ` [PATCH v3] " Chris Wilson
2019-07-23 12:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
2019-07-23 13:40 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev2) Patchwork
2019-07-23 15:57 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt (rev3) Patchwork
2019-07-23 20:52 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.