Re: [PATCH net-next v3 8/8] net: mscc: PTP Hardware Clock (PHC) support

[David Miller <davem@davemloft.net>]

From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Wed, 24 Jul 2019 10:17:15 +0200

> +static int ocelot_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
> +{
> +	struct ocelot *ocelot = container_of(ptp, struct ocelot, ptp_info);
> +	u32 unit = 0, direction = 0;
> +	unsigned long flags;
                      ^^^^
> +	u64 adj = 0;
> +
> +	if (!scaled_ppm)
> +		goto disable_adj;
 ...
> +disable_adj:
> +	ocelot_write(ocelot, 0, PTP_CLK_CFG_ADJ_CFG);
> +
> +	spin_unlock_irqrestore(&ocelot->ptp_clock_lock, flags);
                                                        ^^^^^


Did GCC really not warn about this in your build like it did immediately
on mine?

drivers/net/ethernet/mscc/ocelot.c: In function ‘ocelot_ptp_adjfine’:
./include/linux/spinlock.h:288:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Please fix this and when you respin please just elide the MIPS tree
patches and just keep all the ones that I should apply to net-next.

Thank you.