From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559CFC76186 for ; Wed, 24 Jul 2019 20:11:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C40420665 for ; Wed, 24 Jul 2019 20:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392594AbfGXULb (ORCPT ); Wed, 24 Jul 2019 16:11:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51146 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392080AbfGXULa (ORCPT ); Wed, 24 Jul 2019 16:11:30 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8A4A715431988; Wed, 24 Jul 2019 13:11:29 -0700 (PDT) Date: Wed, 24 Jul 2019 13:11:29 -0700 (PDT) Message-Id: <20190724.131129.622443430636097975.davem@davemloft.net> To: nhorman@tuxdriver.com Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org Subject: Re: [PATCH net-next 0/4] sctp: clean up __sctp_connect function From: David Miller In-Reply-To: <20190724184729.GD7212@hmswarspite.think-freely.org> References: <20190724142512.GG6204@localhost.localdomain> <20190724184729.GD7212@hmswarspite.think-freely.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jul 2019 13:11:29 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Neil Horman Date: Wed, 24 Jul 2019 14:47:29 -0400 > On Wed, Jul 24, 2019 at 11:25:12AM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, Jul 23, 2019 at 01:37:56AM +0800, Xin Long wrote: >> > This patchset is to factor out some common code for >> > sctp_sendmsg_new_asoc() and __sctp_connect() into 2 >> > new functioins. >> > >> > Xin Long (4): >> > sctp: check addr_size with sa_family_t size in >> > __sctp_setsockopt_connectx >> > sctp: clean up __sctp_connect >> > sctp: factor out sctp_connect_new_asoc >> > sctp: factor out sctp_connect_add_peer >> >> Nice cleanup! These patches LGTM. Hopefully for Neil as well. >> >> Acked-by: Marcelo Ricardo Leitner >> > > Yes, agreed, this all looks good, but I would like to resolve the addr_length > check issue before I ack it. Once that's resolved please just respin this series with Marcelo's ACK retained in the series introduction email. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 24 Jul 2019 20:11:29 +0000 Subject: Re: [PATCH net-next 0/4] sctp: clean up __sctp_connect function Message-Id: <20190724.131129.622443430636097975.davem@davemloft.net> List-Id: References: <20190724142512.GG6204@localhost.localdomain> <20190724184729.GD7212@hmswarspite.think-freely.org> In-Reply-To: <20190724184729.GD7212@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: nhorman@tuxdriver.com Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org From: Neil Horman Date: Wed, 24 Jul 2019 14:47:29 -0400 > On Wed, Jul 24, 2019 at 11:25:12AM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, Jul 23, 2019 at 01:37:56AM +0800, Xin Long wrote: >> > This patchset is to factor out some common code for >> > sctp_sendmsg_new_asoc() and __sctp_connect() into 2 >> > new functioins. >> > >> > Xin Long (4): >> > sctp: check addr_size with sa_family_t size in >> > __sctp_setsockopt_connectx >> > sctp: clean up __sctp_connect >> > sctp: factor out sctp_connect_new_asoc >> > sctp: factor out sctp_connect_add_peer >> >> Nice cleanup! These patches LGTM. Hopefully for Neil as well. >> >> Acked-by: Marcelo Ricardo Leitner >> > > Yes, agreed, this all looks good, but I would like to resolve the addr_length > check issue before I ack it. Once that's resolved please just respin this series with Marcelo's ACK retained in the series introduction email.