[PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume GARDET]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.
Tested with kmscube on Chromebook snow.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org

---
 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..5ce4b2853cf2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -1097,6 +1097,53 @@
 		 */
 		clock-frequency = <24000000>;
 	};
+
+	mali: gpu@0x11800000 {
+		compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+		reg = <0x11800000 0x5000>;
+		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+		             <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "job", "mmu", "gpu";
+		clocks = <&clock CLK_G3D>;
+		clock-names = "g3d";
+		operating-points-v2 = <&gpu_opp_table>;
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+	};
+
+	gpu_opp_table: gpu-opp-table {
+		compatible = "operating-points-v2";
+
+		opp-100000000 {
+			opp-hz = /bits/ 64 <100000000>;
+			opp-microvolt = <925000>;
+		};
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <925000>;
+		};
+		opp-266000000 {
+			opp-hz = /bits/ 64 <266000000>;
+			opp-microvolt = <1025000>;
+		};
+		opp-350000000 {
+			opp-hz = /bits/ 64 <350000000>;
+			opp-microvolt = <1075000>;
+		};
+		opp-400000000 {
+			opp-hz = /bits/ 64 <400000000>;
+			opp-microvolt = <1125000>;
+		};
+		opp-450000000 {
+			opp-hz = /bits/ 64 <450000000>;
+			opp-microvolt = <1150000>;
+		};
+		opp-533000000 {
+			opp-hz = /bits/ 64 <533000000>;
+			opp-microvolt = <1250000>;
+		};
+	};
 };
 
 &dp {
-- 
2.22.0

[PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume GARDET]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.
Tested with kmscube on Chromebook snow.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org

---
 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..5ce4b2853cf2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -1097,6 +1097,53 @@
 		 */
 		clock-frequency = <24000000>;
 	};
+
+	mali: gpu@0x11800000 {
+		compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+		reg = <0x11800000 0x5000>;
+		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+		             <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "job", "mmu", "gpu";
+		clocks = <&clock CLK_G3D>;
+		clock-names = "g3d";
+		operating-points-v2 = <&gpu_opp_table>;
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+	};
+
+	gpu_opp_table: gpu-opp-table {
+		compatible = "operating-points-v2";
+
+		opp-100000000 {
+			opp-hz = /bits/ 64 <100000000>;
+			opp-microvolt = <925000>;
+		};
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <925000>;
+		};
+		opp-266000000 {
+			opp-hz = /bits/ 64 <266000000>;
+			opp-microvolt = <1025000>;
+		};
+		opp-350000000 {
+			opp-hz = /bits/ 64 <350000000>;
+			opp-microvolt = <1075000>;
+		};
+		opp-400000000 {
+			opp-hz = /bits/ 64 <400000000>;
+			opp-microvolt = <1125000>;
+		};
+		opp-450000000 {
+			opp-hz = /bits/ 64 <450000000>;
+			opp-microvolt = <1150000>;
+		};
+		opp-533000000 {
+			opp-hz = /bits/ 64 <533000000>;
+			opp-microvolt = <1250000>;
+		};
+	};
 };
 
 &dp {
-- 
2.22.0



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

Hi,

Thanks for the patch.

On Wed, Jul 24, 2019 at 09:20:08AM +0200, Guillaume GARDET wrote:
> From: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.

Why disabled? If tested I would expect it to be enabled at least on
tested platforms.

> Tested with kmscube on Chromebook snow.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> 
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..5ce4b2853cf2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -1097,6 +1097,53 @@
>  		 */
>  		clock-frequency = <24000000>;
>  	};
> +
> +	mali: gpu@0x11800000 {

1. Put the node under /soc (as recently pointed out by Marek Szyprowski)
in an address-sorted mode... if possible (nodes are mixed so find some
reasonable place based on address_.
2. Fix errors from:
make dtbs W=1

> +		compatible = "samsung,exynos5250-mali", "arm,mali-t604";

You also need to update the bindings.

> +		reg = <0x11800000 0x5000>;
> +		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> +		             <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,

Please run checkpatch and fix the errors.

> +			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "job", "mmu", "gpu";
> +		clocks = <&clock CLK_G3D>;
> +		clock-names = "g3d";
> +		operating-points-v2 = <&gpu_opp_table>;
> +		power-domains = <&pd_g3d>;
> +		status = "disabled";
> +	};
> +
> +	gpu_opp_table: gpu-opp-table {

GPU opp table as subnode of Mali node.

Best regards,
Krzysztof

Re: [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

Hi,

Thanks for the patch.

On Wed, Jul 24, 2019 at 09:20:08AM +0200, Guillaume GARDET wrote:
> From: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.

Why disabled? If tested I would expect it to be enabled at least on
tested platforms.

> Tested with kmscube on Chromebook snow.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> 
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..5ce4b2853cf2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -1097,6 +1097,53 @@
>  		 */
>  		clock-frequency = <24000000>;
>  	};
> +
> +	mali: gpu@0x11800000 {

1. Put the node under /soc (as recently pointed out by Marek Szyprowski)
in an address-sorted mode... if possible (nodes are mixed so find some
reasonable place based on address_.
2. Fix errors from:
make dtbs W=1

> +		compatible = "samsung,exynos5250-mali", "arm,mali-t604";

You also need to update the bindings.

> +		reg = <0x11800000 0x5000>;
> +		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> +		             <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,

Please run checkpatch and fix the errors.

> +			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "job", "mmu", "gpu";
> +		clocks = <&clock CLK_G3D>;
> +		clock-names = "g3d";
> +		operating-points-v2 = <&gpu_opp_table>;
> +		power-domains = <&pd_g3d>;
> +		status = "disabled";
> +	};
> +
> +	gpu_opp_table: gpu-opp-table {

GPU opp table as subnode of Mali node.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add nodes for GPU (Mali T604) to Exynos5250.
Tested with kmscube and glmark2-es2-drm on Chromebook snow.
Load tested on arndale board.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch

 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..f7f34d469bde 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -328,6 +328,52 @@
 			iommus = <&sysmmu_rotator>;
 		};
 
+		mali: gpu@11800000 {
+			compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+			reg = <0x11800000 0x5000>;
+			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&clock CLK_G3D>;
+			clock-names = "g3d";
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&pd_g3d>;
+
+			gpu_opp_table: gpu-opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-160000000 {
+					opp-hz = /bits/ 64 <160000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-266000000 {
+					opp-hz = /bits/ 64 <266000000>;
+					opp-microvolt = <1025000>;
+				};
+				opp-350000000 {
+					opp-hz = /bits/ 64 <350000000>;
+					opp-microvolt = <1075000>;
+				};
+				opp-400000000 {
+					opp-hz = /bits/ 64 <400000000>;
+					opp-microvolt = <1125000>;
+				};
+				opp-450000000 {
+					opp-hz = /bits/ 64 <450000000>;
+					opp-microvolt = <1150000>;
+				};
+				opp-533000000 {
+					opp-hz = /bits/ 64 <533000000>;
+					opp-microvolt = <1250000>;
+				};
+			};
+		};
+
 		tmu: tmu@10060000 {
 			compatible = "samsung,exynos5250-tmu";
 			reg = <0x10060000 0x100>;
-- 
2.22.0

[PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add nodes for GPU (Mali T604) to Exynos5250.
Tested with kmscube and glmark2-es2-drm on Chromebook snow.
Load tested on arndale board.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch

 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..f7f34d469bde 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -328,6 +328,52 @@
 			iommus = <&sysmmu_rotator>;
 		};
 
+		mali: gpu@11800000 {
+			compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+			reg = <0x11800000 0x5000>;
+			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&clock CLK_G3D>;
+			clock-names = "g3d";
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&pd_g3d>;
+
+			gpu_opp_table: gpu-opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-160000000 {
+					opp-hz = /bits/ 64 <160000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-266000000 {
+					opp-hz = /bits/ 64 <266000000>;
+					opp-microvolt = <1025000>;
+				};
+				opp-350000000 {
+					opp-hz = /bits/ 64 <350000000>;
+					opp-microvolt = <1075000>;
+				};
+				opp-400000000 {
+					opp-hz = /bits/ 64 <400000000>;
+					opp-microvolt = <1125000>;
+				};
+				opp-450000000 {
+					opp-hz = /bits/ 64 <450000000>;
+					opp-microvolt = <1150000>;
+				};
+				opp-533000000 {
+					opp-hz = /bits/ 64 <533000000>;
+					opp-microvolt = <1250000>;
+				};
+			};
+		};
+
 		tmu: tmu@10060000 {
 			compatible = "samsung,exynos5250-tmu";
 			reg = <0x10060000 0x100>;
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 2/2] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
V2 changes: new patch for V2 serie

 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index 9b298edec5b2..bdd1396d9cc3 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -17,6 +17,7 @@ Required properties:
   * which must be preceded by one of the following vendor specifics:
     + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
+    + "samsung,exynos5250-mali"
     + "samsung,exynos5433-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"
-- 
2.22.0

[PATCH V2 2/2] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume]

From: Guillaume GARDET <guillaume.gardet@arm.com>

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
V2 changes: new patch for V2 serie

 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index 9b298edec5b2..bdd1396d9cc3 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -17,6 +17,7 @@ Required properties:
   * which must be preceded by one of the following vendor specifics:
     + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
+    + "samsung,exynos5250-mali"
     + "samsung,exynos5433-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
>
> From: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Add nodes for GPU (Mali T604) to Exynos5250.
> Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> Load tested on arndale board.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V2 changes:
>   * move mali node as /soc sub-node
>   * move gpu_opp_table as mali sub-node
>   * minor style updates
>   * test on arndale board
>   * enable by default

I was not specific enough. It can stay disabled in the DTSI because
not all resources are provided. The board DTSes (all or ones which are
tested) will enable it and provide missing resources - mali-supply.
Just like:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f0a6208b90bdd44f48f5718c8bb0eb1e763d14c0

>   * add dt bindings, in a separate patch

Put the bindings before DTS change.

>
>  arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..f7f34d469bde 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -328,6 +328,52 @@
>                         iommus = <&sysmmu_rotator>;
>                 };
>
> +               mali: gpu@11800000 {
> +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> +                       reg = <0x11800000 0x5000>;
> +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "job", "mmu", "gpu";
> +                       clocks = <&clock CLK_G3D>;
> +                       clock-names = "g3d";

According to bindings this is not proper clock name. I wonder why it
was working... it seems the driver expects first clock to be always
the core clock.

Best regards,
Krzysztof

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
>
> From: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Add nodes for GPU (Mali T604) to Exynos5250.
> Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> Load tested on arndale board.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V2 changes:
>   * move mali node as /soc sub-node
>   * move gpu_opp_table as mali sub-node
>   * minor style updates
>   * test on arndale board
>   * enable by default

I was not specific enough. It can stay disabled in the DTSI because
not all resources are provided. The board DTSes (all or ones which are
tested) will enable it and provide missing resources - mali-supply.
Just like:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f0a6208b90bdd44f48f5718c8bb0eb1e763d14c0

>   * add dt bindings, in a separate patch

Put the bindings before DTS change.

>
>  arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..f7f34d469bde 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -328,6 +328,52 @@
>                         iommus = <&sysmmu_rotator>;
>                 };
>
> +               mali: gpu@11800000 {
> +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> +                       reg = <0x11800000 0x5000>;
> +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "job", "mmu", "gpu";
> +                       clocks = <&clock CLK_G3D>;
> +                       clock-names = "g3d";

According to bindings this is not proper clock name. I wonder why it
was working... it seems the driver expects first clock to be always
the core clock.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 25 July 2019 13:19
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
> >
> > From: Guillaume GARDET <guillaume.gardet@arm.com>
> >
> > Add nodes for GPU (Mali T604) to Exynos5250.
> > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > Load tested on arndale board.
> >
> > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: linux-arm-kernel@lists.infradead.org
> > ---
> > V2 changes:
> >   * move mali node as /soc sub-node
> >   * move gpu_opp_table as mali sub-node
> >   * minor style updates
> >   * test on arndale board
> >   * enable by default
>
> I was not specific enough. It can stay disabled in the DTSI because not all
> resources are provided. The board DTSes (all or ones which are
> tested) will enable it and provide missing resources - mali-supply.

I think all resources are provided, since no mali-supply property is needed here.
So, I can either enable it by default for all exynos5250 platforms there, or I can enable it only for Arndale board and Chromebook snow. What do you prefer?

> Just like:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f
> 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
>
> >   * add dt bindings, in a separate patch
>
> Put the bindings before DTS change.

Yes, makes sense.

>
> >
> >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > +++++++++++++++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > b/arch/arm/boot/dts/exynos5250.dtsi
> > index d5e0392b409e..f7f34d469bde 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -328,6 +328,52 @@
> >                         iommus = <&sysmmu_rotator>;
> >                 };
> >
> > +               mali: gpu@11800000 {
> > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > +                       reg = <0x11800000 0x5000>;
> > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "job", "mmu", "gpu";
> > +                       clocks = <&clock CLK_G3D>;
> > +                       clock-names = "g3d";
>
> According to bindings this is not proper clock name. I wonder why it was
> working... it seems the driver expects first clock to be always the core clock.

Yes, it works, because 1st clock is assumed to be the core clock.
Clock names are optional and could be omitted as in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?

Thanks,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 25 July 2019 13:19
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
> >
> > From: Guillaume GARDET <guillaume.gardet@arm.com>
> >
> > Add nodes for GPU (Mali T604) to Exynos5250.
> > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > Load tested on arndale board.
> >
> > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: linux-arm-kernel@lists.infradead.org
> > ---
> > V2 changes:
> >   * move mali node as /soc sub-node
> >   * move gpu_opp_table as mali sub-node
> >   * minor style updates
> >   * test on arndale board
> >   * enable by default
>
> I was not specific enough. It can stay disabled in the DTSI because not all
> resources are provided. The board DTSes (all or ones which are
> tested) will enable it and provide missing resources - mali-supply.

I think all resources are provided, since no mali-supply property is needed here.
So, I can either enable it by default for all exynos5250 platforms there, or I can enable it only for Arndale board and Chromebook snow. What do you prefer?

> Just like:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f
> 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
>
> >   * add dt bindings, in a separate patch
>
> Put the bindings before DTS change.

Yes, makes sense.

>
> >
> >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > +++++++++++++++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > b/arch/arm/boot/dts/exynos5250.dtsi
> > index d5e0392b409e..f7f34d469bde 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -328,6 +328,52 @@
> >                         iommus = <&sysmmu_rotator>;
> >                 };
> >
> > +               mali: gpu@11800000 {
> > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > +                       reg = <0x11800000 0x5000>;
> > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "job", "mmu", "gpu";
> > +                       clocks = <&clock CLK_G3D>;
> > +                       clock-names = "g3d";
>
> According to bindings this is not proper clock name. I wonder why it was
> working... it seems the driver expects first clock to be always the core clock.

Yes, it works, because 1st clock is assumed to be the core clock.
Clock names are optional and could be omitted as in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?

Thanks,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 13:35, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 25 July 2019 13:19
> > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> > arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> > exynos5250
> >
> > On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
> > >
> > > From: Guillaume GARDET <guillaume.gardet@arm.com>
> > >
> > > Add nodes for GPU (Mali T604) to Exynos5250.
> > > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > > Load tested on arndale board.
> > >
> > > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > ---
> > > V2 changes:
> > >   * move mali node as /soc sub-node
> > >   * move gpu_opp_table as mali sub-node
> > >   * minor style updates
> > >   * test on arndale board
> > >   * enable by default
> >
> > I was not specific enough. It can stay disabled in the DTSI because not all
> > resources are provided. The board DTSes (all or ones which are
> > tested) will enable it and provide missing resources - mali-supply.
>
> I think all resources are provided, since no mali-supply property is needed here.

No, regulator is not provided. On all Exynos boards Mali uses its own
dedicated regulator (and sometimes additional one). It worked in your
case because the regulator was set as always-on but this is a
workaround for lack of consumers. Once there is a consumer, the
regulator should not be always-on to save the energy when not used.

> So, I can either enable it by default for all exynos5250 platforms there, or I can enable it only for Arndale board and Chromebook snow. What do you prefer?

Then please enable it on tested platforms.

>
> > Just like:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f
> > 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
> >
> > >   * add dt bindings, in a separate patch
> >
> > Put the bindings before DTS change.
>
> Yes, makes sense.
>
> >
> > >
> > >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > > +++++++++++++++++++++++++++++++
> > >  1 file changed, 47 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > > b/arch/arm/boot/dts/exynos5250.dtsi
> > > index d5e0392b409e..f7f34d469bde 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -328,6 +328,52 @@
> > >                         iommus = <&sysmmu_rotator>;
> > >                 };
> > >
> > > +               mali: gpu@11800000 {
> > > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > > +                       reg = <0x11800000 0x5000>;
> > > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > > +                       interrupt-names = "job", "mmu", "gpu";
> > > +                       clocks = <&clock CLK_G3D>;
> > > +                       clock-names = "g3d";
> >
> > According to bindings this is not proper clock name. I wonder why it was
> > working... it seems the driver expects first clock to be always the core clock.
>
> Yes, it works, because 1st clock is assumed to be the core clock.
> Clock names are optional and could be omitted as in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
> Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?

The driver can change anytime and it might look for "core" so DTS
should follow the bindings. Additionally, Panfrost might behave
differently than Arm driver. So "core" please.

Best regards,
Krzysztof

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 13:35, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 25 July 2019 13:19
> > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> > arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> > exynos5250
> >
> > On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com> wrote:
> > >
> > > From: Guillaume GARDET <guillaume.gardet@arm.com>
> > >
> > > Add nodes for GPU (Mali T604) to Exynos5250.
> > > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > > Load tested on arndale board.
> > >
> > > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > ---
> > > V2 changes:
> > >   * move mali node as /soc sub-node
> > >   * move gpu_opp_table as mali sub-node
> > >   * minor style updates
> > >   * test on arndale board
> > >   * enable by default
> >
> > I was not specific enough. It can stay disabled in the DTSI because not all
> > resources are provided. The board DTSes (all or ones which are
> > tested) will enable it and provide missing resources - mali-supply.
>
> I think all resources are provided, since no mali-supply property is needed here.

No, regulator is not provided. On all Exynos boards Mali uses its own
dedicated regulator (and sometimes additional one). It worked in your
case because the regulator was set as always-on but this is a
workaround for lack of consumers. Once there is a consumer, the
regulator should not be always-on to save the energy when not used.

> So, I can either enable it by default for all exynos5250 platforms there, or I can enable it only for Arndale board and Chromebook snow. What do you prefer?

Then please enable it on tested platforms.

>
> > Just like:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f
> > 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
> >
> > >   * add dt bindings, in a separate patch
> >
> > Put the bindings before DTS change.
>
> Yes, makes sense.
>
> >
> > >
> > >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > > +++++++++++++++++++++++++++++++
> > >  1 file changed, 47 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > > b/arch/arm/boot/dts/exynos5250.dtsi
> > > index d5e0392b409e..f7f34d469bde 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -328,6 +328,52 @@
> > >                         iommus = <&sysmmu_rotator>;
> > >                 };
> > >
> > > +               mali: gpu@11800000 {
> > > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > > +                       reg = <0x11800000 0x5000>;
> > > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > > +                       interrupt-names = "job", "mmu", "gpu";
> > > +                       clocks = <&clock CLK_G3D>;
> > > +                       clock-names = "g3d";
> >
> > According to bindings this is not proper clock name. I wonder why it was
> > working... it seems the driver expects first clock to be always the core clock.
>
> Yes, it works, because 1st clock is assumed to be the core clock.
> Clock names are optional and could be omitted as in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
> Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?

The driver can change anytime and it might look for "core" so DTS
should follow the bindings. Additionally, Panfrost might behave
differently than Arm driver. So "core" please.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 25 July 2019 14:27
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 13:35, Guillaume Gardet <Guillaume.Gardet@arm.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: 25 July 2019 13:19
> > > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim
> > > <kgene@kernel.org>; linux- arm-kernel@lists.infradead.org
> > > Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node
> > > to
> > > exynos5250
> > >
> > > On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com>
> wrote:
> > > >
> > > > From: Guillaume GARDET <guillaume.gardet@arm.com>
> > > >
> > > > Add nodes for GPU (Mali T604) to Exynos5250.
> > > > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > > > Load tested on arndale board.
> > > >
> > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> > > >
> > > > Cc: Kukjin Kim <kgene@kernel.org>
> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > > V2 changes:
> > > >   * move mali node as /soc sub-node
> > > >   * move gpu_opp_table as mali sub-node
> > > >   * minor style updates
> > > >   * test on arndale board
> > > >   * enable by default
> > >
> > > I was not specific enough. It can stay disabled in the DTSI because
> > > not all resources are provided. The board DTSes (all or ones which
> > > are
> > > tested) will enable it and provide missing resources - mali-supply.
> >
> > I think all resources are provided, since no mali-supply property is needed here.
>
> No, regulator is not provided. On all Exynos boards Mali uses its own dedicated
> regulator (and sometimes additional one). It worked in your case because the
> regulator was set as always-on but this is a workaround for lack of consumers.
> Once there is a consumer, the regulator should not be always-on to save the
> energy when not used.

I do not have the required info here. Do you have it, or could I skip the mali-supply for now?

>
> > So, I can either enable it by default for all exynos5250 platforms there, or I can
> enable it only for Arndale board and Chromebook snow. What do you prefer?
>
> Then please enable it on tested platforms.

Ok.

>
> >
> > > Just like:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/c
> > > ommit/?id=f
> > > 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
> > >
> > > >   * add dt bindings, in a separate patch
> > >
> > > Put the bindings before DTS change.
> >
> > Yes, makes sense.
> >
> > >
> > > >
> > > >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > > > +++++++++++++++++++++++++++++++
> > > >  1 file changed, 47 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > > > b/arch/arm/boot/dts/exynos5250.dtsi
> > > > index d5e0392b409e..f7f34d469bde 100644
> > > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > > @@ -328,6 +328,52 @@
> > > >                         iommus = <&sysmmu_rotator>;
> > > >                 };
> > > >
> > > > +               mali: gpu@11800000 {
> > > > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > > > +                       reg = <0x11800000 0x5000>;
> > > > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > > > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > > > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > > > +                       interrupt-names = "job", "mmu", "gpu";
> > > > +                       clocks = <&clock CLK_G3D>;
> > > > +                       clock-names = "g3d";
> > >
> > > According to bindings this is not proper clock name. I wonder why it
> > > was working... it seems the driver expects first clock to be always the core
> clock.
> >
> > Yes, it works, because 1st clock is assumed to be the core clock.
> > Clock names are optional and could be omitted as in
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre
> > e/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
> > Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?
>
> The driver can change anytime and it might look for "core" so DTS should follow
> the bindings. Additionally, Panfrost might behave differently than Arm driver. So
> "core" please.

Ok.

Thanks,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 25 July 2019 14:27
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 13:35, Guillaume Gardet <Guillaume.Gardet@arm.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: 25 July 2019 13:19
> > > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim
> > > <kgene@kernel.org>; linux- arm-kernel@lists.infradead.org
> > > Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node
> > > to
> > > exynos5250
> > >
> > > On Thu, 25 Jul 2019 at 10:34, Guillaume <guillaume.gardet@arm.com>
> wrote:
> > > >
> > > > From: Guillaume GARDET <guillaume.gardet@arm.com>
> > > >
> > > > Add nodes for GPU (Mali T604) to Exynos5250.
> > > > Tested with kmscube and glmark2-es2-drm on Chromebook snow.
> > > > Load tested on arndale board.
> > > >
> > > > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> > > >
> > > > Cc: Kukjin Kim <kgene@kernel.org>
> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > > V2 changes:
> > > >   * move mali node as /soc sub-node
> > > >   * move gpu_opp_table as mali sub-node
> > > >   * minor style updates
> > > >   * test on arndale board
> > > >   * enable by default
> > >
> > > I was not specific enough. It can stay disabled in the DTSI because
> > > not all resources are provided. The board DTSes (all or ones which
> > > are
> > > tested) will enable it and provide missing resources - mali-supply.
> >
> > I think all resources are provided, since no mali-supply property is needed here.
>
> No, regulator is not provided. On all Exynos boards Mali uses its own dedicated
> regulator (and sometimes additional one). It worked in your case because the
> regulator was set as always-on but this is a workaround for lack of consumers.
> Once there is a consumer, the regulator should not be always-on to save the
> energy when not used.

I do not have the required info here. Do you have it, or could I skip the mali-supply for now?

>
> > So, I can either enable it by default for all exynos5250 platforms there, or I can
> enable it only for Arndale board and Chromebook snow. What do you prefer?
>
> Then please enable it on tested platforms.

Ok.

>
> >
> > > Just like:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/c
> > > ommit/?id=f
> > > 0a6208b90bdd44f48f5718c8bb0eb1e763d14c0
> > >
> > > >   * add dt bindings, in a separate patch
> > >
> > > Put the bindings before DTS change.
> >
> > Yes, makes sense.
> >
> > >
> > > >
> > > >  arch/arm/boot/dts/exynos5250.dtsi | 47
> > > > +++++++++++++++++++++++++++++++
> > > >  1 file changed, 47 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > > > b/arch/arm/boot/dts/exynos5250.dtsi
> > > > index d5e0392b409e..f7f34d469bde 100644
> > > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > > @@ -328,6 +328,52 @@
> > > >                         iommus = <&sysmmu_rotator>;
> > > >                 };
> > > >
> > > > +               mali: gpu@11800000 {
> > > > +                       compatible = "samsung,exynos5250-mali", "arm,mali-t604";
> > > > +                       reg = <0x11800000 0x5000>;
> > > > +                       interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> > > > +                                    <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> > > > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > > > +                       interrupt-names = "job", "mmu", "gpu";
> > > > +                       clocks = <&clock CLK_G3D>;
> > > > +                       clock-names = "g3d";
> > >
> > > According to bindings this is not proper clock name. I wonder why it
> > > was working... it seems the driver expects first clock to be always the core
> clock.
> >
> > Yes, it works, because 1st clock is assumed to be the core clock.
> > Clock names are optional and could be omitted as in
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre
> > e/arch/arm/boot/dts/rk3288.dtsi?h=v5.3-rc1#n1284
> > Not sure if it would be better to rename it to 'core', or  just skip it? Any opinion?
>
> The driver can change anytime and it might look for "core" so DTS should follow
> the bindings. Additionally, Panfrost might behave differently than Arm driver. So
> "core" please.

Ok.

Thanks,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
> > No, regulator is not provided. On all Exynos boards Mali uses its own dedicated
> > regulator (and sometimes additional one). It worked in your case because the
> > regulator was set as always-on but this is a workaround for lack of consumers.
> > Once there is a consumer, the regulator should not be always-on to save the
> > energy when not used.
>
> I do not have the required info here. Do you have it, or could I skip the mali-supply for now?

You can guess from regulator name :)
For the Arndale, the schematics are saying it is buck4.

Best regards,
Krzysztof

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski]

On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
> > No, regulator is not provided. On all Exynos boards Mali uses its own dedicated
> > regulator (and sometimes additional one). It worked in your case because the
> > regulator was set as always-on but this is a workaround for lack of consumers.
> > Once there is a consumer, the regulator should not be always-on to save the
> > energy when not used.
>
> I do not have the required info here. Do you have it, or could I skip the mali-supply for now?

You can guess from regulator name :)
For the Arndale, the schematics are saying it is buck4.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 26 July 2019 12:40
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
> wrote:
> > > No, regulator is not provided. On all Exynos boards Mali uses its
> > > own dedicated regulator (and sometimes additional one). It worked in
> > > your case because the regulator was set as always-on but this is a
> workaround for lack of consumers.
> > > Once there is a consumer, the regulator should not be always-on to
> > > save the energy when not used.
> >
> > I do not have the required info here. Do you have it, or could I skip the
> mali-supply for now?
>
> You can guess from regulator name :)
> For the Arndale, the schematics are saying it is buck4.

Thanks. This is buck4 as well for snow.

On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
[   21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV

The following change fixes the previous error:
-                               regulator-min-microvolt = <1000000>;
-                               regulator-max-microvolt = <1000000>;
+                               regulator-min-microvolt = <850000>;
+                               regulator-max-microvolt = <1300000>;

Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?

Regards,
Guillaume


>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 26 July 2019 12:40
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
> wrote:
> > > No, regulator is not provided. On all Exynos boards Mali uses its
> > > own dedicated regulator (and sometimes additional one). It worked in
> > > your case because the regulator was set as always-on but this is a
> workaround for lack of consumers.
> > > Once there is a consumer, the regulator should not be always-on to
> > > save the energy when not used.
> >
> > I do not have the required info here. Do you have it, or could I skip the
> mali-supply for now?
>
> You can guess from regulator name :)
> For the Arndale, the schematics are saying it is buck4.

Thanks. This is buck4 as well for snow.

On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
[   21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV

The following change fixes the previous error:
-                               regulator-min-microvolt = <1000000>;
-                               regulator-max-microvolt = <1000000>;
+                               regulator-min-microvolt = <850000>;
+                               regulator-max-microvolt = <1300000>;

Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?

Regards,
Guillaume


>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Marek Szyprowski]

Hi Guillaume,

On 2019-07-31 16:37, Guillaume Gardet wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 26 July 2019 12:40
>> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
>> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
>> linux-arm-kernel@lists.infradead.org
>> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
>> exynos5250
>>
>> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
>> wrote:
>>>> No, regulator is not provided. On all Exynos boards Mali uses its
>>>> own dedicated regulator (and sometimes additional one). It worked in
>>>> your case because the regulator was set as always-on but this is a
>> workaround for lack of consumers.
>>>> Once there is a consumer, the regulator should not be always-on to
>>>> save the energy when not used.
>>> I do not have the required info here. Do you have it, or could I skip the
>> mali-supply for now?
>>
>> You can guess from regulator name :)
>> For the Arndale, the schematics are saying it is buck4.
> Thanks. This is buck4 as well for snow.
>
> On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
> [   21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV
>
> The following change fixes the previous error:
> -                               regulator-min-microvolt = <1000000>;
> -                               regulator-max-microvolt = <1000000>;
> +                               regulator-min-microvolt = <850000>;
> +                               regulator-max-microvolt = <1300000>;
>
> Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?

It is okay to add this fixup to the patch, which sets mali regulator on 
arndale board.


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Marek Szyprowski]

Hi Guillaume,

On 2019-07-31 16:37, Guillaume Gardet wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 26 July 2019 12:40
>> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
>> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
>> linux-arm-kernel@lists.infradead.org
>> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
>> exynos5250
>>
>> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
>> wrote:
>>>> No, regulator is not provided. On all Exynos boards Mali uses its
>>>> own dedicated regulator (and sometimes additional one). It worked in
>>>> your case because the regulator was set as always-on but this is a
>> workaround for lack of consumers.
>>>> Once there is a consumer, the regulator should not be always-on to
>>>> save the energy when not used.
>>> I do not have the required info here. Do you have it, or could I skip the
>> mali-supply for now?
>>
>> You can guess from regulator name :)
>> For the Arndale, the schematics are saying it is buck4.
> Thanks. This is buck4 as well for snow.
>
> On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
> [   21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV
>
> The following change fixes the previous error:
> -                               regulator-min-microvolt = <1000000>;
> -                               regulator-max-microvolt = <1000000>;
> +                               regulator-min-microvolt = <850000>;
> +                               regulator-max-microvolt = <1300000>;
>
> Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?

It is okay to add this fixup to the patch, which sets mali regulator on 
arndale board.


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 0/4] Add GPU/Mali T604 node to arndale and snow (exynos5250)

[Guillaume Gardet]

Add nodes for GPU (Mali T604) to Exynos5250.
Tested with kmscube and some glmark2* tests on Chromebook snow and
arndale board.

V3 changes:
  * change clock name from 'g3d' to 'core'
  * disable node by default in exynos5250.dtsi
  * move dt-bindings before node addition in device tree
  * enable node for arndale and snow, with mali-supply, separetly
  * add patch to fix min/max values for buck4 regulator for gpu
    on arndale board

V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch


Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org

Guillaume Gardet (5):
  dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible
  arm: dts: exynos: Add GPU/Mali T604 node to exynos5250
  arm: dts: exynos: snow: Enable GPU/Mali T604 node
  arm: dts: exynos: arndale: Enable GPU/Mali T604 node
  arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu

 .../bindings/gpu/arm,mali-midgard.txt         |  1 +
 arch/arm/boot/dts/exynos5250-arndale.dts      |  9 +++-
 arch/arm/boot/dts/exynos5250-snow-common.dtsi |  5 ++
 arch/arm/boot/dts/exynos5250.dtsi             | 47 +++++++++++++++++++
 4 files changed, 60 insertions(+), 2 deletions(-)

-- 
2.22.1

[PATCH V3 0/4] Add GPU/Mali T604 node to arndale and snow (exynos5250)

[Guillaume Gardet]

Add nodes for GPU (Mali T604) to Exynos5250.
Tested with kmscube and some glmark2* tests on Chromebook snow and
arndale board.

V3 changes:
  * change clock name from 'g3d' to 'core'
  * disable node by default in exynos5250.dtsi
  * move dt-bindings before node addition in device tree
  * enable node for arndale and snow, with mali-supply, separetly
  * add patch to fix min/max values for buck4 regulator for gpu
    on arndale board

V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch


Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org

Guillaume Gardet (5):
  dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible
  arm: dts: exynos: Add GPU/Mali T604 node to exynos5250
  arm: dts: exynos: snow: Enable GPU/Mali T604 node
  arm: dts: exynos: arndale: Enable GPU/Mali T604 node
  arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu

 .../bindings/gpu/arm,mali-midgard.txt         |  1 +
 arch/arm/boot/dts/exynos5250-arndale.dts      |  9 +++-
 arch/arm/boot/dts/exynos5250-snow-common.dtsi |  5 ++
 arch/arm/boot/dts/exynos5250.dtsi             | 47 +++++++++++++++++++
 4 files changed, 60 insertions(+), 2 deletions(-)

-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * add dt-bindings before node in device tree
V2 changes:
  * new file

 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index 9b298edec5b2..bdd1396d9cc3 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -17,6 +17,7 @@ Required properties:
   * which must be preceded by one of the following vendor specifics:
     + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
+    + "samsung,exynos5250-mali"
     + "samsung,exynos5433-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"
-- 
2.22.1

[PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * add dt-bindings before node in device tree
V2 changes:
  * new file

 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
index 9b298edec5b2..bdd1396d9cc3 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
@@ -17,6 +17,7 @@ Required properties:
   * which must be preceded by one of the following vendor specifics:
     + "allwinner,sun50i-h6-mali"
     + "amlogic,meson-gxm-mali"
+    + "samsung,exynos5250-mali"
     + "samsung,exynos5433-mali"
     + "rockchip,rk3288-mali"
     + "rockchip,rk3399-mali"
-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 2/5] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

Add nodes for GPU (Mali T604) to Exynos5250.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * change clock name from 'g3d' to 'core'
  * disable node by default in exynos5250.dtsi
  * move dt-bindings before node addition in device tree

V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch

 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..05b4d8755cfa 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -328,6 +328,53 @@
 			iommus = <&sysmmu_rotator>;
 		};
 
+		mali: gpu@11800000 {
+			compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+			reg = <0x11800000 0x5000>;
+			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&clock CLK_G3D>;
+			clock-names = "core";
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&pd_g3d>;
+			status = "disabled";
+
+			gpu_opp_table: gpu-opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-160000000 {
+					opp-hz = /bits/ 64 <160000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-266000000 {
+					opp-hz = /bits/ 64 <266000000>;
+					opp-microvolt = <1025000>;
+				};
+				opp-350000000 {
+					opp-hz = /bits/ 64 <350000000>;
+					opp-microvolt = <1075000>;
+				};
+				opp-400000000 {
+					opp-hz = /bits/ 64 <400000000>;
+					opp-microvolt = <1125000>;
+				};
+				opp-450000000 {
+					opp-hz = /bits/ 64 <450000000>;
+					opp-microvolt = <1150000>;
+				};
+				opp-533000000 {
+					opp-hz = /bits/ 64 <533000000>;
+					opp-microvolt = <1250000>;
+				};
+			};
+		};
+
 		tmu: tmu@10060000 {
 			compatible = "samsung,exynos5250-tmu";
 			reg = <0x10060000 0x100>;
-- 
2.22.1

[PATCH V3 2/5] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet]

Add nodes for GPU (Mali T604) to Exynos5250.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * change clock name from 'g3d' to 'core'
  * disable node by default in exynos5250.dtsi
  * move dt-bindings before node addition in device tree

V2 changes: 
  * move mali node as /soc sub-node
  * move gpu_opp_table as mali sub-node
  * minor style updates
  * test on arndale board
  * enable by default
  * add dt bindings, in a separate patch

 arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index d5e0392b409e..05b4d8755cfa 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -328,6 +328,53 @@
 			iommus = <&sysmmu_rotator>;
 		};
 
+		mali: gpu@11800000 {
+			compatible = "samsung,exynos5250-mali", "arm,mali-t604";
+			reg = <0x11800000 0x5000>;
+			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "job", "mmu", "gpu";
+			clocks = <&clock CLK_G3D>;
+			clock-names = "core";
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&pd_g3d>;
+			status = "disabled";
+
+			gpu_opp_table: gpu-opp-table {
+				compatible = "operating-points-v2";
+
+				opp-100000000 {
+					opp-hz = /bits/ 64 <100000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-160000000 {
+					opp-hz = /bits/ 64 <160000000>;
+					opp-microvolt = <925000>;
+				};
+				opp-266000000 {
+					opp-hz = /bits/ 64 <266000000>;
+					opp-microvolt = <1025000>;
+				};
+				opp-350000000 {
+					opp-hz = /bits/ 64 <350000000>;
+					opp-microvolt = <1075000>;
+				};
+				opp-400000000 {
+					opp-hz = /bits/ 64 <400000000>;
+					opp-microvolt = <1125000>;
+				};
+				opp-450000000 {
+					opp-hz = /bits/ 64 <450000000>;
+					opp-microvolt = <1150000>;
+				};
+				opp-533000000 {
+					opp-hz = /bits/ 64 <533000000>;
+					opp-microvolt = <1250000>;
+				};
+			};
+		};
+
 		tmu: tmu@10060000 {
 			compatible = "samsung,exynos5250-tmu";
 			reg = <0x10060000 0x100>;
-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 3/5] arm: dts: exynos: snow: Enable GPU/Mali T604 node

[Guillaume Gardet]

Tested with kmscube and some glmark2* tests on Chromebook snow.
Frequency adapts with load.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-snow-common.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index fd9226d3b207..c952a615148e 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -529,6 +529,11 @@
 	status = "okay";
 };
 
+&mali {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &mixer {
 	status = "okay";
 };
-- 
2.22.1

[PATCH V3 3/5] arm: dts: exynos: snow: Enable GPU/Mali T604 node

[Guillaume Gardet]

Tested with kmscube and some glmark2* tests on Chromebook snow.
Frequency adapts with load.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-snow-common.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index fd9226d3b207..c952a615148e 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -529,6 +529,11 @@
 	status = "okay";
 };
 
+&mali {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &mixer {
 	status = "okay";
 };
-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 4/5] arm: dts: exynos: arndale: Enable GPU/Mali T604 node

[Guillaume Gardet]

Tested with kmscube and some glmark2* tests on arndale board.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index dc6fa6fe83f1..cf5a758f1927 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -543,6 +543,11 @@
 	status = "okay";
 };
 
+&mali {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &mixer {
 	status = "okay";
 };
-- 
2.22.1

[PATCH V3 4/5] arm: dts: exynos: arndale: Enable GPU/Mali T604 node

[Guillaume Gardet]

Tested with kmscube and some glmark2* tests on arndale board.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index dc6fa6fe83f1..cf5a758f1927 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -543,6 +543,11 @@
 	status = "okay";
 };
 
+&mali {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &mixer {
 	status = "okay";
 };
-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 5/5] arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu

[Guillaume Gardet]

Required to have gpu opp working properly.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index cf5a758f1927..6fcb78a354fe 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -461,8 +461,8 @@
 
 			buck4_reg: BUCK4 {
 				regulator-name = "vdd_g3d";
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1300000>;
 				regulator-always-on;
 				regulator-boot-on;
 				op_mode = <1>;
-- 
2.22.1

[PATCH V3 5/5] arm: dts: exynos: arndale: Fix min/max for buck4 regulator for gpu

[Guillaume Gardet]

Required to have gpu opp working properly.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
---
V3 changes:
  * new file

 arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index cf5a758f1927..6fcb78a354fe 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -461,8 +461,8 @@
 
 			buck4_reg: BUCK4 {
 				regulator-name = "vdd_g3d";
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1300000>;
 				regulator-always-on;
 				regulator-boot-on;
 				op_mode = <1>;
-- 
2.22.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> Add "samsung,exynos5250-mali" binding.
> 
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V3 changes:
>   * add dt-bindings before node in device tree
> V2 changes:
>   * new file
> 
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +

Thanks, entire set applied (with re-ordering and minor description
changes).

Best regards,
Krzysztof

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> Add "samsung,exynos5250-mali" binding.
> 
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V3 changes:
>   * add dt-bindings before node in device tree
> V2 changes:
>   * new file
> 
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +

Thanks, entire set applied (with re-ordering and minor description
changes).

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > Add "samsung,exynos5250-mali" binding.
> >
> > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > ---
> > V3 changes:
> >   * add dt-bindings before node in device tree
> > V2 changes:
> >   * new file
> >
> >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
>
> Thanks, entire set applied (with re-ordering and minor description
> changes).

Hi Guillaume,

I applied yesterday entire patchset but this dt-bindings patch causes
big merge conflict which will not be reasonable to resolve by Linus.
Can you rebase this patch on top of latest linux-next? Basically you
would need to add respective entries to new YAML file:
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml

Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

Best regards,
Krzysztof

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > Add "samsung,exynos5250-mali" binding.
> >
> > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > ---
> > V3 changes:
> >   * add dt-bindings before node in device tree
> > V2 changes:
> >   * new file
> >
> >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
>
> Thanks, entire set applied (with re-ordering and minor description
> changes).

Hi Guillaume,

I applied yesterday entire patchset but this dt-bindings patch causes
big merge conflict which will not be reasonable to resolve by Linus.
Can you rebase this patch on top of latest linux-next? Basically you
would need to add respective entries to new YAML file:
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml

Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 03 September 2019 08:56
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> exynos5250 compatible
>
> On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > Add "samsung,exynos5250-mali" binding.
> > >
> > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > ---
> > > V3 changes:
> > >   * add dt-bindings before node in device tree
> > > V2 changes:
> > >   * new file
> > >
> > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> >
> > Thanks, entire set applied (with re-ordering and minor description
> > changes).
>
> Hi Guillaume,

Hi,

>
> I applied yesterday entire patchset but this dt-bindings patch causes big
> merge conflict which will not be reasonable to resolve by Linus.
> Can you rebase this patch on top of latest linux-next? Basically you would
> need to add respective entries to new YAML file:
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
>
> Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Regards,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

RE: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 03 September 2019 08:56
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> exynos5250 compatible
>
> On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > Add "samsung,exynos5250-mali" binding.
> > >
> > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > ---
> > > V3 changes:
> > >   * add dt-bindings before node in device tree
> > > V2 changes:
> > >   * new file
> > >
> > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> >
> > Thanks, entire set applied (with re-ordering and minor description
> > changes).
>
> Hi Guillaume,

Hi,

>
> I applied yesterday entire patchset but this dt-bindings patch causes big
> merge conflict which will not be reasonable to resolve by Linus.
> Can you rebase this patch on top of latest linux-next? Basically you would
> need to add respective entries to new YAML file:
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
>
> Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).

IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Regards,
Guillaume

>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Tue, 3 Sep 2019 at 09:03, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 03 September 2019 08:56
> > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> > Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> > exynos5250 compatible
> >
> > On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > > Add "samsung,exynos5250-mali" binding.
> > > >
> > > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > > >
> > > > Cc: Kukjin Kim <kgene@kernel.org>
> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > > V3 changes:
> > > >   * add dt-bindings before node in device tree
> > > > V2 changes:
> > > >   * new file
> > > >
> > > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> > >
> > > Thanks, entire set applied (with re-ordering and minor description
> > > changes).
> >
> > Hi Guillaume,
>
> Hi,
>
> >
> > I applied yesterday entire patchset but this dt-bindings patch causes big
> > merge conflict which will not be reasonable to resolve by Linus.
> > Can you rebase this patch on top of latest linux-next? Basically you would
> > need to add respective entries to new YAML file:
> > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> >
> > Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).
>
> IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Yes, correct. Just remember to send it to proper maintainers (previous
one skipped DT guys).

Best regards,
Krzysztof

Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Tue, 3 Sep 2019 at 09:03, Guillaume Gardet <Guillaume.Gardet@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 03 September 2019 08:56
> > To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> > Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> > Marek Szyprowski <m.szyprowski@samsung.com>; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH V3 1/5] dt-bindings: gpu: mali-midgard: Add samsung
> > exynos5250 compatible
> >
> > On Mon, 2 Sep 2019 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > On Fri, Aug 30, 2019 at 12:44:58PM +0200, Guillaume Gardet wrote:
> > > > Add "samsung,exynos5250-mali" binding.
> > > >
> > > > Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
> > > >
> > > > Cc: Kukjin Kim <kgene@kernel.org>
> > > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > ---
> > > > V3 changes:
> > > >   * add dt-bindings before node in device tree
> > > > V2 changes:
> > > >   * new file
> > > >
> > > >  Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 +
> > >
> > > Thanks, entire set applied (with re-ordering and minor description
> > > changes).
> >
> > Hi Guillaume,
>
> Hi,
>
> >
> > I applied yesterday entire patchset but this dt-bindings patch causes big
> > merge conflict which will not be reasonable to resolve by Linus.
> > Can you rebase this patch on top of latest linux-next? Basically you would
> > need to add respective entries to new YAML file:
> > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> >
> > Send it to regular dt-bindings maintainers (scripts/get_maintainers.pl).
>
> IIUC, I just need to resend this patch (1/5) rebased to use yaml, instead of txt, no need to resend other patches, right?

Yes, correct. Just remember to send it to proper maintainers (previous
one skipped DT guys).

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
index b99a43bb471a..47bc1ac36426 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
@@ -30,12 +30,15 @@ properties:
           - enum:
              - rockchip,rk3399-mali
           - const: arm,mali-t860
+      - items:
+          - enum:
+             - samsung,exynos5250-mali
+          - const: arm,mali-t604
       - items:
           - enum:
              - samsung,exynos5433-mali
           - const: arm,mali-t760
 
-          # "arm,mali-t604"
           # "arm,mali-t624"
           # "arm,mali-t628"
           # "arm,mali-t830"
-- 
2.23.0

[PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Guillaume Gardet]

Add "samsung,exynos5250-mali" binding.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
index b99a43bb471a..47bc1ac36426 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
@@ -30,12 +30,15 @@ properties:
           - enum:
              - rockchip,rk3399-mali
           - const: arm,mali-t860
+      - items:
+          - enum:
+             - samsung,exynos5250-mali
+          - const: arm,mali-t604
       - items:
           - enum:
              - samsung,exynos5433-mali
           - const: arm,mali-t760
 
-          # "arm,mali-t604"
           # "arm,mali-t624"
           # "arm,mali-t628"
           # "arm,mali-t830"
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Tue, 3 Sep 2019 at 09:33, Guillaume Gardet <guillaume.gardet@arm.com> wrote:
>
> Add "samsung,exynos5250-mali" binding.
>
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Krzysztof Kozlowski]

On Tue, 3 Sep 2019 at 09:33, Guillaume Gardet <guillaume.gardet@arm.com> wrote:
>
> Add "samsung,exynos5250-mali" binding.
>
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Rob Herring]

On Tue, Sep 3, 2019 at 8:33 AM Guillaume Gardet
<guillaume.gardet@arm.com> wrote:
>
> Add "samsung,exynos5250-mali" binding.
>
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks.

Rob

Re: [PATCH] dt-bindings: gpu: mali-midgard: Add samsung exynos5250 compatible

[Rob Herring]

On Tue, Sep 3, 2019 at 8:33 AM Guillaume Gardet
<guillaume.gardet@arm.com> wrote:
>
> Add "samsung,exynos5250-mali" binding.
>
> Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel