All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qlge: Fix build error without CONFIG_ETHERNET
@ 2019-07-24 13:01 YueHaibing
  2019-07-24 21:12 ` David Miller
  2019-07-24 21:12 ` David Miller
  0 siblings, 2 replies; 6+ messages in thread
From: YueHaibing @ 2019-07-24 13:01 UTC (permalink / raw)
  To: manishc, GR-Linux-NIC-Dev, gregkh, bpoirier
  Cc: linux-kernel, devel, netdev, YueHaibing

Now if CONFIG_ETHERNET is not set, QLGE driver
building fails:

drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/staging/qlge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig
index ae9ed2c..a3cb25a3 100644
--- a/drivers/staging/qlge/Kconfig
+++ b/drivers/staging/qlge/Kconfig
@@ -2,7 +2,7 @@
 
 config QLGE
 	tristate "QLogic QLGE 10Gb Ethernet Driver Support"
-	depends on PCI
+	depends on ETHERNET && PCI
 	help
 	This driver supports QLogic ISP8XXX 10Gb Ethernet cards.
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
  2019-07-24 13:01 [PATCH] qlge: Fix build error without CONFIG_ETHERNET YueHaibing
@ 2019-07-24 21:12 ` David Miller
  2019-07-24 21:12   ` David Miller
  2019-07-24 21:12 ` David Miller
  1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2019-07-24 21:12 UTC (permalink / raw)
  To: yuehaibing
  Cc: manishc, GR-Linux-NIC-Dev, gregkh, bpoirier, linux-kernel, devel, netdev

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 24 Jul 2019 21:01:26 +0800

> Now if CONFIG_ETHERNET is not set, QLGE driver
> building fails:
> 
> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

I'll let Greg take this.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
  2019-07-24 13:01 [PATCH] qlge: Fix build error without CONFIG_ETHERNET YueHaibing
  2019-07-24 21:12 ` David Miller
@ 2019-07-24 21:12 ` David Miller
  1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2019-07-24 21:12 UTC (permalink / raw)
  To: yuehaibing
  Cc: bpoirier, devel, GR-Linux-NIC-Dev, manishc, gregkh, linux-kernel, netdev

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 24 Jul 2019 21:01:26 +0800

> Now if CONFIG_ETHERNET is not set, QLGE driver
> building fails:
> 
> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

I'll let Greg take this.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
  2019-07-24 21:12 ` David Miller
@ 2019-07-24 21:12   ` David Miller
  2019-07-25 11:14     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2019-07-24 21:12 UTC (permalink / raw)
  To: yuehaibing
  Cc: manishc, GR-Linux-NIC-Dev, gregkh, bpoirier, linux-kernel, devel, netdev

From: David Miller <davem@davemloft.net>
Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)

> From: YueHaibing <yuehaibing@huawei.com>
> Date: Wed, 24 Jul 2019 21:01:26 +0800
> 
>> Now if CONFIG_ETHERNET is not set, QLGE driver
>> building fails:
>> 
>> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
>> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
>> 
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> I'll let Greg take this.

Actually, I take that back.

Since the move to staging happened in my tree I will take this ;-)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET
  2019-07-24 21:12   ` David Miller
@ 2019-07-25 11:14     ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-07-25 11:14 UTC (permalink / raw)
  To: David Miller
  Cc: yuehaibing, bpoirier, devel, GR-Linux-NIC-Dev, manishc,
	linux-kernel, netdev

On Wed, Jul 24, 2019 at 02:12:28PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)
> 
> > From: YueHaibing <yuehaibing@huawei.com>
> > Date: Wed, 24 Jul 2019 21:01:26 +0800
> > 
> >> Now if CONFIG_ETHERNET is not set, QLGE driver
> >> building fails:
> >> 
> >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> >> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
> >> 
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > 
> > I'll let Greg take this.
> 
> Actually, I take that back.
> 
> Since the move to staging happened in my tree I will take this ;-)

Thanks.  If you want to push that "move" to Linus soon, I can then take
any cleanup patches that show up for this driver, otherwise feel free to
ignore them until 5.4-rc1.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] qlge: Fix build error without CONFIG_ETHERNET
@ 2019-07-24 13:01 YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-07-24 13:01 UTC (permalink / raw)
  To: manishc, GR-Linux-NIC-Dev, gregkh, bpoirier
  Cc: devel, netdev, YueHaibing, linux-kernel

Now if CONFIG_ETHERNET is not set, QLGE driver
building fails:

drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/staging/qlge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig
index ae9ed2c..a3cb25a3 100644
--- a/drivers/staging/qlge/Kconfig
+++ b/drivers/staging/qlge/Kconfig
@@ -2,7 +2,7 @@
 
 config QLGE
 	tristate "QLogic QLGE 10Gb Ethernet Driver Support"
-	depends on PCI
+	depends on ETHERNET && PCI
 	help
 	This driver supports QLogic ISP8XXX 10Gb Ethernet cards.
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-25 11:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 13:01 [PATCH] qlge: Fix build error without CONFIG_ETHERNET YueHaibing
2019-07-24 21:12 ` David Miller
2019-07-24 21:12   ` David Miller
2019-07-25 11:14     ` Greg KH
2019-07-24 21:12 ` David Miller
2019-07-24 13:01 YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.