From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E75C76186 for ; Wed, 24 Jul 2019 19:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96D3922387 for ; Wed, 24 Jul 2019 19:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996299; bh=5bptGHajZUwUTZMdRKkgDXJz6lb2zVBlsJAl/ajIdiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kxXAHo/znziqOyk+lfY8D9qxJkH4aZpFLTvloJ1ETXO+bJgpni06K49ivcTPFgqai Yyx5XJ2E6u2sJOK+Dnz/apOhydJVjEHYoavKEKYI9EOW+GVXebdMjWJqIwAhiGvdHq xyuApRJ//oYbz3ySvRdMina3zoA3j7cG6MvXk2j0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbfGXTY6 (ORCPT ); Wed, 24 Jul 2019 15:24:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:41356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387986AbfGXTYv (ORCPT ); Wed, 24 Jul 2019 15:24:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6129122387; Wed, 24 Jul 2019 19:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996290; bh=5bptGHajZUwUTZMdRKkgDXJz6lb2zVBlsJAl/ajIdiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pz/S7DCowoGPEC4t0Laf6pN9IQ1+RzJHOIAPjXZMTE7beCSg4lpdrH50JBvWxWjBr 9/TQ5SypHyurojNrARwGN0j4MjMwXwUoqBNHKinSZAy+Ax73eFupmfTQf6bcnlE4uw u5Mf5LBIFyClX/6Oc7tbj1kpzIW6dcUfTyGFYztQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.2 047/413] media: mc-device.c: dont memset __user pointer contents Date: Wed, 24 Jul 2019 21:15:38 +0200 Message-Id: <20190724191738.920214613@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 518fa4e0e0da97ea2e17c95ab57647ce748a96e2 ] You can't memset the contents of a __user pointer. Instead, call copy_to_user to copy links.reserved (which is zeroed) to the user memory. This fixes this sparse warning: SPARSE:drivers/media/mc/mc-device.c drivers/media/mc/mc-device.c:521:16: warning: incorrect type in argument 1 (different address spaces) Fixes: f49308878d720 ("media: media_device_enum_links32: clean a reserved field") Signed-off-by: Hans Verkuil Reviewed-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/media-device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index b9bb4904bba1..e19df5165e78 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -510,8 +510,9 @@ static long media_device_enum_links32(struct media_device *mdev, if (ret) return ret; - memset(ulinks->reserved, 0, sizeof(ulinks->reserved)); - + if (copy_to_user(ulinks->reserved, links.reserved, + sizeof(ulinks->reserved))) + return -EFAULT; return 0; } -- 2.20.1